Re: RFR: JDK-8031767 Support system or alternative implementations of zlib

2016-03-24 Thread Xueming Shen
Thanks Erik! Webrev has been updated accordingly. http://cr.openjdk.java.net/~sherman/8031767/webrev/ -Sherman On 03/24/2016 01:57 PM, Erik Joelsson wrote: Hello, Yes, I believe we still need to, the reason being that configure automatically falls back to bundled if the headers are not avai

Re: RFR: JDK-8031767 Support system or alternative implementations of zlib

2016-03-24 Thread Erik Joelsson
Hello, Yes, I believe we still need to, the reason being that configure automatically falls back to bundled if the headers are not available. This is what happened when you initially tried your patch in JPRT. I still think this is a good way for configure to behave in the general case. In the

Re: RFR: JDK-8031767 Support system or alternative implementations of zlib

2016-03-24 Thread Xueming Shen
Erik, I'm not familiar with the jib-profiles.js. So just want to confirm before putting into the webrev. The proposal is to build with system zlib by default for non-windows platforms, without the need of specifying the configuration/build opton --with-zlib=system. Do we still need to update thi

Re: State of Java printing on Mac

2016-03-24 Thread Tres Finocchiaro
Phil, Much obliged. I'm sorry to have posted in the incorrect location and to have wasted developers's time, this was never the intention. but that is still not a support channel, it is for developers working on > the source. Can you direct me to a channel that would be better suit such discus

Re: State of Java printing on Mac

2016-03-24 Thread Phil Race
Hi, First, this is the wrong list entirely - this is list is about how to build openjdk from source, and all lists on this site are about source development so this is the one -and-only reply on this list. If you really need to follow up go to [email protected] which superseded a differe

State of Java printing on Mac

2016-03-24 Thread Tres Finocchiaro
I hope this message is well received. Over the past year, I've been trying to leverage Java as a cross-platform desktop printing solution. My success has varied. Below are some items that have caused hiccups or hard-fails specifically to the Mac OS... - PDFBOX just released a major update "2

Re: RFR: JDK-8031767 Support system or alternative implementations of zlib

2016-03-24 Thread Xueming Shen
On 3/24/16 1:05 AM, Erik Joelsson wrote: Hello, As I wrote in the bug, jdk9/dev currently fails when using --with-zlib=system with the new devkit on Linux. That will need to be fixed first. Has the JDK-8152352 fixed all the problems or there is something other warning missing? https://bugs

Re: RFR: JDK-8031767 Support system or alternative implementations of zlib

2016-03-24 Thread Erik Joelsson
Hello again. Here is my suggested patch for the jib-profiles.js file. This will enforce system zlib for Oracle builds on Linux, Solaris and Macosx. /Erik diff -r 6da9e0c79eac common/conf/jib-profiles.js --- a/common/conf/jib-profiles.js +++ b/common/conf/jib-profiles.js @@ -241,7 +241,7 @@

Re: RFR: JDK-8152545: Use preprocessor instead of compiling a program to generate native nio constants

2016-03-24 Thread Alan Bateman
On 24/03/2016 12:15, Erik Joelsson wrote: New webrev with shorter lines in SocketOptionRegistry.java.template. http://cr.openjdk.java.net/~erikj/8152545/webrev.jdk.02/ This looks good. -Alan.

Re: RFR: JDK-8152545: Use preprocessor instead of compiling a program to generate native nio constants

2016-03-24 Thread Erik Joelsson
New webrev with shorter lines in SocketOptionRegistry.java.template. http://cr.openjdk.java.net/~erikj/8152545/webrev.jdk.02/ /Erik On 2016-03-24 12:57, Erik Joelsson wrote: On 2016-03-24 12:15, Alan Bateman wrote: On 23/03/2016 16:14, Erik Joelsson wrote: : On 2016-03-23 12:13, Erik Joe

Re: RFR: JDK-8152545: Use preprocessor instead of compiling a program to generate native nio constants

2016-03-24 Thread Erik Joelsson
On 2016-03-24 12:15, Alan Bateman wrote: On 23/03/2016 16:14, Erik Joelsson wrote: : On 2016-03-23 12:13, Erik Joelsson wrote: There are however 3 that, at least on Linux, are defined as an enum and not constants, which makes them unavailable to the preprocessor. These are: IPPROTO_TCP =

Re: RFR: JDK-8152545: Use preprocessor instead of compiling a program to generate native nio constants

2016-03-24 Thread Alan Bateman
On 23/03/2016 16:14, Erik Joelsson wrote: : On 2016-03-23 12:13, Erik Joelsson wrote: There are however 3 that, at least on Linux, are defined as an enum and not constants, which makes them unavailable to the preprocessor. These are: IPPROTO_TCP = 6 IPPROTO_IP = 0 IPPROTO_PV6 = 41 I would

Re: RFR: JDK-8031767 Support system or alternative implementations of zlib

2016-03-24 Thread Erik Joelsson
I see now you fixed the build warnings separately. Nice. I will provide the necessary changes to jib-profiles.js. /Erik On 2016-03-24 09:05, Erik Joelsson wrote: Hello, As I wrote in the bug, jdk9/dev currently fails when using --with-zlib=system with the new devkit on Linux. That will need

Re: RFR: JDK-8031767 Support system or alternative implementations of zlib

2016-03-24 Thread Erik Joelsson
Hello, As I wrote in the bug, jdk9/dev currently fails when using --with-zlib=system with the new devkit on Linux. That will need to be fixed first. If the intention of this change is to enforce --with-zlib=system on OracleJDK builds, we should also update the Jib profile definitions for Li