On 26/04/2016 11:21 PM, Erik Joelsson wrote:
New webrev: http://cr.openjdk.java.net/~erikj/8154841/webrev.top.02/
Thanks - much clearer to me now. Plus I see that docs is "aliased" to
docs-image.
David
-
/Erik
On 2016-04-26 15:20, Erik Joelsson wrote:
Thank you David for looking it t
On 26/04/2016 10:16, Chris Hegarty wrote:
On 26 Apr 2016, at 09:20, Alan Bateman wrote:
On 25/04/2016 22:01, Chris Hegarty wrote:
One of the remaining open issues in JEP 200 [1] is that the base module
exports the jdk.net package, thereby violating Principle 4 of JEP 200:
a Java SE module m
Erik:
Looks good to me as well.
/Tim
New webrev: http://cr.openjdk.java.net/~erikj/8154841/webrev.top.02/
/Erik
On 2016-04-26 15:20, Erik Joelsson wrote:
Thank you David for looking it this!
On 2016-04-26 14:47, David Holmes wrote:
On 26/04/2016 10:01 PM, Erik Joelsson wrote:
It would be
Hi Erik, The boot jdk was 64 bit 8u60 b25. I'll send you a log
shortly. -Pete
On 4/26/16 4:29 AM, Erik Joelsson wrote:
> What do you use as boot jdk? I would recommend using a 64bit JDK 8.
> Could you rerun with LOG=debug and send me the build.log?
>
> /Erik
>
> On 2016-04-26 02:55, Pete Brunet
This was fixed by adding this to config:
--with-sdk-name=macosx10.9
On 4/1/16 5:26 PM, Phil Race wrote:
> This is bug https://bugs.openjdk.java.net/browse/JDK-8134884
>
> I am not sure about the bit where refreshing your repo triggered it since
> I don't think the source code changed recently, so
Thank you David for looking it this!
On 2016-04-26 14:47, David Holmes wrote:
On 26/04/2016 10:01 PM, Erik Joelsson wrote:
It would be really nice to get this reviewed as I have a lot of further
work depending on this feature.
I'm not fluent in .js but those changes seemed relatively straight
New webrev: http://cr.openjdk.java.net/~erikj/8154841/webrev.top.02/
/Erik
On 2016-04-26 15:20, Erik Joelsson wrote:
Thank you David for looking it this!
On 2016-04-26 14:47, David Holmes wrote:
On 26/04/2016 10:01 PM, Erik Joelsson wrote:
It would be really nice to get this reviewed as I ha
On 26/04/2016 10:01 PM, Erik Joelsson wrote:
It would be really nice to get this reviewed as I have a lot of further
work depending on this feature.
I'm not fluent in .js but those changes seemed relatively straight
forward to understand. More so than the rest ...
make/Main.gmk
Don't really
It would be really nice to get this reviewed as I have a lot of further
work depending on this feature.
/Erik
On 2016-04-22 10:32, Erik Joelsson wrote:
Currently all Jib profiles define the default make target configure
arg to be "all". While this works ok for our current main profiles,
it's
Thanks, looks good!
/Erik
On 2016-04-26 12:02, Chris Hegarty wrote:
On 26 Apr 2016, at 10:57, Erik Joelsson wrote:
On 2016-04-26 11:51, Chris Hegarty wrote:
On 26 Apr 2016, at 10:35, Erik Joelsson wrote:
Hello Chris,
In general it looks good.
Thanks for the review Erik.
Just a coupl
On 26 Apr 2016, at 10:57, Erik Joelsson wrote:
>
>
> On 2016-04-26 11:51, Chris Hegarty wrote:
>> On 26 Apr 2016, at 10:35, Erik Joelsson wrote:
>>
>>> Hello Chris,
>>>
>>> In general it looks good.
>> Thanks for the review Erik.
>>
>>> Just a couple style [1] nits that I would like to get
On 2016-04-26 11:57, Erik Joelsson wrote:
On 2016-04-26 11:51, Chris Hegarty wrote:
On 26 Apr 2016, at 10:35, Erik Joelsson
wrote:
Hello Chris,
In general it looks good.
Thanks for the review Erik.
Just a couple style [1] nits that I would like to get sorted. In
Lib-jdk.net.gmk, the
On 2016-04-26 11:51, Chris Hegarty wrote:
On 26 Apr 2016, at 10:35, Erik Joelsson wrote:
Hello Chris,
In general it looks good.
Thanks for the review Erik.
Just a couple style [1] nits that I would like to get sorted. In
Lib-jdk.net.gmk, the arguments to SetupNativeCompilation should be
On 26 Apr 2016, at 10:35, Erik Joelsson wrote:
> Hello Chris,
>
> In general it looks good.
Thanks for the review Erik.
> Just a couple style [1] nits that I would like to get sorted. In
> Lib-jdk.net.gmk, the arguments to SetupNativeCompilation should be indented 4
> spaces relative to the
Hello Chris,
In general it looks good. Just a couple style [1] nits that I would like
to get sorted. In Lib-jdk.net.gmk, the arguments to
SetupNativeCompilation should be indented 4 spaces relative to the call
(continuation). Also line 32 and 45 needs a space after comma.
/Erik
[1] http://o
What do you use as boot jdk? I would recommend using a 64bit JDK 8.
Could you rerun with LOG=debug and send me the build.log?
/Erik
On 2016-04-26 02:55, Pete Brunet wrote:
I did a 64 bit build OK but my 32 bit build is failing:
Building configuration 'windows-x86-normal-server-release' (match
On 26 Apr 2016, at 09:20, Alan Bateman wrote:
> On 25/04/2016 22:01, Chris Hegarty wrote:
>> One of the remaining open issues in JEP 200 [1] is that the base module
>> exports the jdk.net package, thereby violating Principle 4 of JEP 200:
>> a Java SE module must not export any non-SE API package
On 25/04/2016 22:01, Chris Hegarty wrote:
One of the remaining open issues in JEP 200 [1] is that the base module
exports the jdk.net package, thereby violating Principle 4 of JEP 200:
a Java SE module must not export any non-SE API packages without
qualification.
http://cr.openjdk.java.net/~c
18 matches
Mail list logo
