Re: Cannot build on OS X 10.11.4

2016-04-28 Thread David Holmes
On 29/04/2016 7:22 AM, John Crowley wrote: Cannot build JDK 9 on a Mac. This was building successfully about 10 days ago, but since pulling down all new changes, have been getting the failures below. Have tried this over several days, pulling down updates each day with no change. Are you sur

Re: Urgent (S) RFR: 8155689: Build failing for install on jdk9/dev when using -testset hotspot

2016-04-28 Thread David Holmes
Thanks Tim! David On 29/04/2016 3:15 PM, Tim Bell wrote: I'm OK with this due to the urgent nature of the issue. Tim On 04/28/16 20:37, David Holmes wrote: On 29/04/2016 1:19 PM, Jon Masamitsu wrote: David, Change looks good but I'm not part of the infrastructure team. Thanks Jon - me n

Re: Urgent (S) RFR: 8155689: Build failing for install on jdk9/dev when using -testset hotspot

2016-04-28 Thread Tim Bell
I'm OK with this due to the urgent nature of the issue. Tim On 04/28/16 20:37, David Holmes wrote: On 29/04/2016 1:19 PM, Jon Masamitsu wrote: David, Change looks good but I'm not part of the infrastructure team. Thanks Jon - me neither :) David Jon On 4/28/2016 7:17 PM, David Holmes w

Re: Urgent (S) RFR: 8155689: Build failing for install on jdk9/dev when using -testset hotspot

2016-04-28 Thread David Holmes
On 29/04/2016 1:19 PM, Jon Masamitsu wrote: David, Change looks good but I'm not part of the infrastructure team. Thanks Jon - me neither :) David Jon On 4/28/2016 7:17 PM, David Holmes wrote: Bug report is not public as it relates to issues with our internal jib builds, but the fix for t

Re: Urgent (S) RFR: 8155689: Build failing for install on jdk9/dev when using -testset hotspot

2016-04-28 Thread Jon Masamitsu
David, Change looks good but I'm not part of the infrastructure team. Jon On 4/28/2016 7:17 PM, David Holmes wrote: Bug report is not public as it relates to issues with our internal jib builds, but the fix for this needs a tweak to the open Main.gmk file. This is a follow up to the fix a co

Urgent (S) RFR: 8155689: Build failing for install on jdk9/dev when using -testset hotspot

2016-04-28 Thread David Holmes
Bug report is not public as it relates to issues with our internal jib builds, but the fix for this needs a tweak to the open Main.gmk file. This is a follow up to the fix a couple of days ago for JDK-8154841: Let different Jib profiles have different default make targets A side-effect of that

Cannot build on OS X 10.11.4

2016-04-28 Thread John Crowley
Cannot build JDK 9 on a Mac. This was building successfully about 10 days ago, but since pulling down all new changes, have been getting the failures below. Have tried this over several days, pulling down updates each day with no change. Any suggestions appreciated, this has had me stuck for

Re: RFR: JDK-8155632: Remove debuginfo from jmod files

2016-04-28 Thread Alan Bateman
On 28/04/2016 14:22, Erik Joelsson wrote: The jmod files currently contain debug information and it has been concluded that they shouldn't. This patch filters out the debug information from the jmod files and adds a new build step in images to copy the appropriate set of debuginfo into the im

Re: RFR: JDK-8155629: MODULES_FILTER should apply to imported modules

2016-04-28 Thread Mandy Chung
> On Apr 28, 2016, at 5:33 AM, Erik Joelsson wrote: > > We have a mechanism to exclude certain modules completely from a build. This > is handled with the MODULES_FILTER variable. It's currently flawed in that it > doesn't apply to imported modules (--with-import-modules). > > Bug: https://bu

Re: RFR: JDK-8155632: Remove debuginfo from jmod files

2016-04-28 Thread Mandy Chung
> On Apr 28, 2016, at 6:22 AM, Erik Joelsson wrote: > > The jmod files currently contain debug information and it has been concluded > that they shouldn't. This patch filters out the debug information from the > jmod files and adds a new build step in images to copy the appropriate set of > d

Re: RFR: JDK-8155641: Correct merge typo in compare script

2016-04-28 Thread Tim Bell
Hi Erik On 04/28/16 07:06, Chris Hegarty wrote: On 28 Apr 2016, at 15:00, Erik Joelsson wrote: An apparent typo has appeared in common/autoconf/compare.sh.in which I think originates from a merge changeset. It prevents clean comparisons from being done so I would like to have it fixed asap.

Re: RFR: JDK-8155632: Remove debuginfo from jmod files

2016-04-28 Thread Tim Bell
Hi Erik: The jmod files currently contain debug information and it has been concluded that they shouldn't. This patch filters out the debug information from the jmod files and adds a new build step in images to copy the appropriate set of debuginfo into the images. Note that this patch does n

Re: RFR: JDK-8155629: MODULES_FILTER should apply to imported modules

2016-04-28 Thread Tim Bell
Erik: On 04/28/16 05:43, David Holmes wrote: On 28/04/2016 10:33 PM, Erik Joelsson wrote: We have a mechanism to exclude certain modules completely from a build. This is handled with the MODULES_FILTER variable. It's currently flawed in that it doesn't apply to imported modules (--with-import-m

Re: RFR: JDK-8155641: Correct merge typo in compare script

2016-04-28 Thread Chris Hegarty
On 28 Apr 2016, at 15:00, Erik Joelsson wrote: > An apparent typo has appeared in common/autoconf/compare.sh.in which I think > originates from a merge changeset. It prevents clean comparisons from being > done so I would like to have it fixed asap. > > Bug: https://bugs.openjdk.java.net/brow

RFR: JDK-8155641: Correct merge typo in compare script

2016-04-28 Thread Erik Joelsson
An apparent typo has appeared in common/autoconf/compare.sh.in which I think originates from a merge changeset. It prevents clean comparisons from being done so I would like to have it fixed asap. Bug: https://bugs.openjdk.java.net/browse/JDK-8155641 Patch: diff -r d8b1e1832b0e common/autoconf/

RFR: JDK-8155632: Remove debuginfo from jmod files

2016-04-28 Thread Erik Joelsson
The jmod files currently contain debug information and it has been concluded that they shouldn't. This patch filters out the debug information from the jmod files and adds a new build step in images to copy the appropriate set of debuginfo into the images. Note that this patch does not aim on c

Re: Fix for JDK-8074829 : Resolve disabled warnings for libawt_headless

2016-04-28 Thread Erik Joelsson
Then I'm happy, thanks! /Erik On 2016-04-28 14:44, Ajit Ghaisas wrote: Hi, I tried excluding files under directory : jdk/src/java.desktop/share/native/common/java2d/opengl from libawt_headless. It resulted in compilation errors - as the headers in this directory (and under sub-di

RE: Fix for JDK-8074829 : Resolve disabled warnings for libawt_headless

2016-04-28 Thread Ajit Ghaisas
Hi, I tried excluding files under directory : jdk/src/java.desktop/share/native/common/java2d/opengl from libawt_headless. It resulted in compilation errors - as the headers in this directory (and under sub-directory J2D_GL) are used in other places. To Phil's question on -

Re: RFR: JDK-8155629: MODULES_FILTER should apply to imported modules

2016-04-28 Thread David Holmes
On 28/04/2016 10:33 PM, Erik Joelsson wrote: We have a mechanism to exclude certain modules completely from a build. This is handled with the MODULES_FILTER variable. It's currently flawed in that it doesn't apply to imported modules (--with-import-modules). Bug: https://bugs.openjdk.java.net/br

RFR: JDK-8155629: MODULES_FILTER should apply to imported modules

2016-04-28 Thread Erik Joelsson
We have a mechanism to exclude certain modules completely from a build. This is handled with the MODULES_FILTER variable. It's currently flawed in that it doesn't apply to imported modules (--with-import-modules). Bug: https://bugs.openjdk.java.net/browse/JDK-8155629 Patch: diff -r d8b1e1832b0e