Re: Questions about including a library for a JTREG native test being built in JPRT

2016-05-17 Thread Gerald Thornbrugh
Hi Eric, Thanks for the information! Jerry Hello, This really has nothing to do with JPRT. What you are introducing is a new kind of native test binary that has a dependency on libjvm.so. So far we haven't had any of these, so the native jtreg compilation does not depend on building hotspot

Re: Questions about including a library for a JTREG native test being built in JPRT

2016-05-17 Thread Erik Joelsson
Hello, This really has nothing to do with JPRT. What you are introducing is a new kind of native test binary that has a dependency on libjvm.so. So far we haven't had any of these, so the native jtreg compilation does not depend on building hotspot first, and the LDFLAGS used for linking do n

Questions about including a library for a JTREG native test being built in JPRT

2016-05-17 Thread Gerald Thornbrugh
Hi Everyone I am trying to fix JDK-8144278 which is a bug to convert a "c" source file test from being built at test run time to being built and included in the test bundle. The test relies on the "jvm" library to call JVM functions from a "c" program. Here are my changes to JtregNative.gmk:

Re: Add top-level Makefile target for running gtest

2016-05-17 Thread Jesper Wilhelmsson
Looks good! /Jesper Den 17/5/16 kl. 10:16, skrev Erik Helin: Hi all, this small patch adds a top-level Makefile target for conveniently running the gtest unit tests. Bug: https://bugs.openjdk.java.net/browse/JDK-8157028 Webrev: http://cr.openjdk.java.net/~ehelin/8157028/webrev.00/ Testing: -

Re: Add top-level Makefile target for running gtest

2016-05-17 Thread Erik Joelsson
Looks good! /Erik On 2016-05-17 10:16, Erik Helin wrote: Hi all, this small patch adds a top-level Makefile target for conveniently running the gtest unit tests. Bug: https://bugs.openjdk.java.net/browse/JDK-8157028 Webrev: http://cr.openjdk.java.net/~ehelin/8157028/webrev.00/ Testing: - Ru

Add top-level Makefile target for running gtest

2016-05-17 Thread Erik Helin
Hi all, this small patch adds a top-level Makefile target for conveniently running the gtest unit tests. Bug: https://bugs.openjdk.java.net/browse/JDK-8157028 Webrev: http://cr.openjdk.java.net/~ehelin/8157028/webrev.00/ Testing: - Running locally on Linux x86-64 Thanks, Erik