Re: RFR(XS) 8161915: Linking gtestLauncher may end up linking with non-gtest libjvm

2016-07-20 Thread David Holmes
Hi Mikael, On 20/07/2016 11:54 PM, Mikael Gerdin wrote: Hi all, Please review this small fix to work around a problem where incremental builds of hotspot would fail due to the symbol runUnitTests missing. The cause for the problem is that the unit tests launcher linker command line contains a

Re: [9] RFR: 8160873: (cs) JDK9 Build failure on Hindi locale

2016-07-20 Thread Tim Bell
On 07/20/16 17:48, Naoto Sato wrote: Thanks for the review Tim! On 7/20/16 5:40 PM, Tim Bell wrote: Naoto: Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8160873 The proposed fix is located at: http://cr.openjdk.java.net/~naoto/8160873/webrev.01/

Re: [9] RFR: 8160873: (cs) JDK9 Build failure on Hindi locale

2016-07-20 Thread Naoto Sato
Thanks for the review Tim! On 7/20/16 5:40 PM, Tim Bell wrote: Naoto: Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8160873 The proposed fix is located at: http://cr.openjdk.java.net/~naoto/8160873/webrev.01/ The gist of the issue is that those

Re: [9] RFR: 8160873: (cs) JDK9 Build failure on Hindi locale

2016-07-20 Thread Tim Bell
Naoto: Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8160873 The proposed fix is located at: http://cr.openjdk.java.net/~naoto/8160873/webrev.01/ The gist of the issue is that those tools used to generate sources at build time were affected by the

Problem running configure on El Capitan

2016-07-20 Thread Lance Andersen
Hi, Has there been any changes to the build requirements recently as I am getting the error: —— configure: error: Could not find freetype! /Users/ljanders/Documents/hg-workspaces/openjdk9/javadoc-mod/common/autoconf/generated-configure.sh: line 82: 5: Bad file descriptor configure

Cloning issues anyone seeing them?

2016-07-20 Thread Lance Andersen
Hi all, Seeing issues with a openjdk9 clone today source get_source.sh WARNING: Mercurial version 2.6.3 or later is recommended. /usr/local/bin/hg is version 2.2 # Repositories: langtools langtools: hg clone http://hg.openjdk.java.net/jdk9/dev/langtools langtools

Re: RFR: JDK-8161057 Solaris: deprecated/obsolete compiler flags should be removed

2016-07-20 Thread Alan Burlison
On 20/07/2016 18:11, Daniel D. Daugherty wrote: We have three reviewers on this changeset. We don't have a review from a current Serviceability team member, but I think Tim and I can be considered as sufficient review since we're both former Serviceability team members. :-) Alan, please

Re: RFR: JDK-8161057 Solaris: deprecated/obsolete compiler flags should be removed

2016-07-20 Thread Daniel D. Daugherty
We have three reviewers on this changeset. We don't have a review from a current Serviceability team member, but I think Tim and I can be considered as sufficient review since we're both former Serviceability team members. :-) Alan, please confirm that this is good to go. This change is applied

Re: RFR: JDK-8161057 Solaris: deprecated/obsolete compiler flags should be removed

2016-07-20 Thread Alan Burlison
On 20/07/2016 03:17, David Holmes wrote: There were some JPRT test failures on OSX and Windows, as this changeset doesn't affect those platforms I believe they can be ignored. If this is with "-testset hotspot" then it shouldn't happen, in that case please drop me an email pointing to the

RFR(XS) 8161915: Linking gtestLauncher may end up linking with non-gtest libjvm

2016-07-20 Thread Mikael Gerdin
Hi all, Please review this small fix to work around a problem where incremental builds of hotspot would fail due to the symbol runUnitTests missing. The cause for the problem is that the unit tests launcher linker command line contains a -L path containing the standard libjvm.so [10]