Re: RFR: JDK-8165158: Fix zero builds for non-listed architectures

2016-08-31 Thread Matthias Klose
On 31.08.2016 17:11, Tim Bell wrote: > Erik Joelsson wrote: > >> Sponsoring the suggested patch. >> >> Matthias, could you verify that I got it right and that it works for >> you? I don't have a setup where I can test such a platform. >> >> Webrev: http://cr.openjdk.java.net/~erikj/8165158/webrev.

Re: RFR: JDK-8165158: Fix zero builds for non-listed architectures

2016-08-31 Thread Tim Bell
Erik Joelsson wrote: Sponsoring the suggested patch. Matthias, could you verify that I got it right and that it works for you? I don't have a setup where I can test such a platform. Webrev: http://cr.openjdk.java.net/~erikj/8165158/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8165

RFR: JDK-8165158: Fix zero builds for non-listed architectures

2016-08-31 Thread Erik Joelsson
Sponsoring the suggested patch. Matthias, could you verify that I got it right and that it works for you? I don't have a setup where I can test such a platform. Webrev: http://cr.openjdk.java.net/~erikj/8165158/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8165158 /Erik On 2016-0

Re: [patch] Fix zero builds for non-listed architectures

2016-08-31 Thread Erik Joelsson
Hello, I think the second one is better. Is there a bug filed for this? /Erik On 2016-08-30 14:33, Matthias Klose wrote: The zero build for architectures not explicitly listed fails currently in hotspot, because of an unset macro, and the compiler complains about a single -D option passed. H

[patch] Fix zero builds for non-listed architectures

2016-08-31 Thread Matthias Klose
The zero build for architectures not explicitly listed fails currently in hotspot, because of an unset macro, and the compiler complains about a single -D option passed. Here are two proposals how to fix these: - Not passing the -D if it is not set. Afaik the define is only used for hotspot b

PING: RFR: JDK-8160354: uninitialized value warning and VM crash are occurred with GCC 6

2016-08-31 Thread Yasumasa Suenaga
PING: Could you review it? http://cr.openjdk.java.net/~ysuenaga/JDK-8160354/webrev.01/ Yasumasa On 2016/08/23 21:48, Yasumasa Suenaga wrote: Hi Kim, and all, Sorry for my late reply. I've fixed them in new webrev. Could you review it? http://cr.openjdk.java.net/~ysuenaga/JDK-8160354/

Re: RFR: 8164858: Enable build-time use of java.lang.invoke resolve tracing

2016-08-31 Thread Claes Redestad
Thanks! Can I get a review of the plugin changes? Mostly ensuring we generate methods in a deterministic order (and weed out duplicates early). /Claes On 2016-08-30 10:20, Erik Joelsson wrote: Build changes look good. /Erik On 2016-08-29 20:10, Claes Redestad wrote: Hi, this patch adds ge