Hi Kumar,
On 8/11/2016 4:47 AM, Kumar Srinivasan wrote:
Hello,
Please review the fix for:
https://bugs.openjdk.java.net/browse/JDK-8169001
Webrev at:
http://cr.openjdk.java.net/~ksrini/8169001/webrev.00/
Overall this looks like a complete eradication of the launcher
ergonomics. A few speci
Great, thanks. Looks good.
Brad
On 11/7/2016 3:34 AM, Seán Coffey wrote:
Thanks for review Brad. I've included an extra check in CryptoLevel to
check for "limited/unlimited" input. Addressed the JceSecurity
indentation issue also.
http://cr.openjdk.java.net/~coffeys/webrev.8157561.8u.jdk.v5
Hello,
Please review the fix for:
https://bugs.openjdk.java.net/browse/JDK-8169001
Webrev at:
http://cr.openjdk.java.net/~ksrini/8169001/webrev.00/
Background:
Launcher ergonomics was introduced last decade to help determine
if the execution system is "Server Class", this was necessary to
cho
Good catch, but unfortunately this has already been pushed.
/Erik
On 2016-11-07 13:43, Magnus Ihse Bursie wrote:
Hi,
On 2016-11-01 17:56, Erik Joelsson wrote:
New webrev: http://cr.openjdk.java.net/~erikj/8063154/webrev.02/
I had not managed to revert all changes from another patch.
Looks
Hello,
On 2016-11-07 13:40, Magnus Ihse Bursie wrote:
Hi,
The webrev haven't picked up the relationship between the LinkOpt and
Classlist files. It seems that it is a rename + modifications. Can you
please redo it using hg mv? And update the webrev so the changes in
the file is visible.
Th
Hi,
On 2016-11-01 17:56, Erik Joelsson wrote:
New webrev: http://cr.openjdk.java.net/~erikj/8063154/webrev.02/
I had not managed to revert all changes from another patch.
Looks good to me, but please remove this comment as well:
# Disable copy of jvmti.h from hotspot until this has been cle
Hi,
The webrev haven't picked up the relationship between the LinkOpt and
Classlist files. It seems that it is a rename + modifications. Can you
please redo it using hg mv? And update the webrev so the changes in the
file is visible.
The name "LinkOptData", is it supposed to be read "link op
On 2016-11-03 19:04, Erik Joelsson wrote:
Here is a new webrev that actually works.
http://cr.openjdk.java.net/~erikj/8160491/webrev.02/
It looks reasonable, but these kinds of changes are always scary. The
new solution, if it works correctly, seems easier to understand, though.
If you fe
Thanks for review Brad. I've included an extra check in CryptoLevel to
check for "limited/unlimited" input. Addressed the JceSecurity
indentation issue also.
http://cr.openjdk.java.net/~coffeys/webrev.8157561.8u.jdk.v5/webrev/
Regards,
Sean.
On 04/11/16 22:56, Bradford Wetmore wrote:
I didn't
