Re: RFR: JDK-8170629 Remove code duplication in test makefiles

No further comments on the hotspot changes. Thanks, David On 6/12/2016 8:15 PM, Magnus Ihse Bursie wrote: On 2016-12-05 05:34, David Holmes wrote: Hi Magnus, Some independent changes are going to collide here. :) hotspot/make/test/JtregNative.gmk This change has already happened in hs rep

RFR(XXS): JDK-8170530: bash configure output contains a typo in a suggested library name

Hi, please review this minor fix of a typo I have noticed in "bash configure” output when required X11 libraries are missing. JBS: https://bugs.openjdk.java.net/browse/JDK-8170530 webrev: http://cr.openjdk.java.net/~stsmirno/8170530/webrev.00 <

Re: Compile error with jdk9-dev latest HEAD - missing com.sun.tools.jdi - on Mac OS X 10.12.1

Martijn, Could I ask you to clone fresh sources? SA-JDI classes was removed in Aug see - JDK-8158050 -Dmitry On 2016-12-06 16:44, Martijn Verburg wrote: > Hi all, > > Just ran make clean image this morning and got: > > ... > ... > === Output from failing command(s) repeated here === > * For t

Compile error with jdk9-dev latest HEAD - missing com.sun.tools.jdi - on Mac OS X 10.12.1

Hi all, Just ran make clean image this morning and got: ... ... === Output from failing command(s) repeated here === * For target jdk_modules_jdk.hotspot.agent__the.jdk.hotspot.agent_batch: /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/jdk9-dev/hotspot/src/jdk.hotspot.agent/share/clas

Re: RFR: 8168503 JEP 297: Unified arm32/arm64 Port

Build changes look ok to me. /Erik On 2016-12-05 16:23, Bob Vandette wrote: On Dec 2, 2016, at 8:04 PM, Vladimir Kozlov wrote: hi Bob, I would suggest to have separate webrevs for different repositories because different groups should look on them. There are only 3 non hotspot files and t

Re: RFR: JDK-8170784: JDK-8170651 broke cross compilation

On 2016-12-06 10:59, David Holmes wrote: Thanks Erik. Looks good. I suspected it might be that part but couldn't quite connect the dots. And I have to express my concern that those changes were not adequately tested! For the record, the checkin that broke the cross compilation build was for

Re: jdk9 build failure in ubuntu16.10

On 2016-12-06 09:20, Prasanta Sadhukhan wrote: On 12/6/2016 1:22 PM, David Holmes wrote: Hi Prasanta, On 6/12/2016 5:42 PM, Prasanta Sadhukhan wrote: Hi, On 12/6/2016 1:03 PM, David Holmes wrote: On 6/12/2016 4:55 PM, Prasanta Sadhukhan wrote: Hi, I was trying to build jdk9 workspace ch

Re: RFR: JDK-8170629 Remove code duplication in test makefiles

On 2016-12-05 05:34, David Holmes wrote: Hi Magnus, Some independent changes are going to collide here. :) hotspot/make/test/JtregNative.gmk This change has already happened in hs repo - JDK-8169261. Ok, I removed that fix from my patch. --- hotspot/test/Makefile 33 USE_JTREG_VERSION :=

Re: RFR: JDK-8170784: JDK-8170651 broke cross compilation

Thanks! When cross compiling arm, we use EXTRA_CFLAGS for the arm configuration specific flags. That variable is used explicitly in hotspot/make/lib/CompileLibjsig.gmk. When compiling for the build platform, we don't want the contents of that variable. I agree on the testing part. /Erik O

Re: RFR: JDK-8170784: JDK-8170651 broke cross compilation

Thanks Erik. Looks good. I suspected it might be that part but couldn't quite connect the dots. And I have to express my concern that those changes were not adequately tested! David - On 6/12/2016 6:52 PM, Erik Joelsson wrote: When cleaning up legacy hotspot settings in JDK-8170651, a b

Re: jdk9 build failure in ubuntu16.10

On Tue, 2016-12-06 at 12:25 +0530, Prasanta Sadhukhan wrote: > Hi, > > I was trying to build jdk9 workspace checked out today on ubuntu16.10  > but am encountering a build problem. I did "configure --enable-debug  > --disable-warnings-as-errors" followed by "make" > Would like to know if it is a k

RFR: JDK-8170784: JDK-8170651 broke cross compilation

When cleaning up legacy hotspot settings in JDK-8170651, a bit too much was removed. Now we can't cross compile certain arm platforms. Bug: https://bugs.openjdk.java.net/browse/JDK-8170784 Patch: diff -r 9475c1488d29 common/autoconf/buildjdk-spec.gmk.in --- a/common/autoconf/buildjdk-spec.gmk.

Re: jdk9 build failure in ubuntu16.10

On 12/6/2016 1:22 PM, David Holmes wrote: Hi Prasanta, On 6/12/2016 5:42 PM, Prasanta Sadhukhan wrote: Hi, On 12/6/2016 1:03 PM, David Holmes wrote: On 6/12/2016 4:55 PM, Prasanta Sadhukhan wrote: Hi, I was trying to build jdk9 workspace checked out today on ubuntu16.10 but am encounteri