Re: [9] RFR 8079898: Resolve disabled warnings for libj2ucrypto

Looks good to me. /Magnus > 8 dec. 2016 kl. 00:21 skrev Valerie Peng : > > Anyone can help reviewing this? > > The fix is straight forward, just renamed the DEBUG to J2UC_DEBUG to address > the E_MACRO_REDEFINED warning. > In addition, I also updated the nativeCrypto.h to remove the workarou

Re: Review Request JDK-8169925: Organize licenses by module in source, JMOD file, and run-time image

Hi Mandy, Just noticed that the CLDR license is located under jdk.localedata module. That needs to be moved into java.base, as its English resource files are derived from CLDR too. Naoto On 12/7/16 1:28 PM, Mandy Chung wrote: This proposes to organize license files by module in source, JMOD

Re: [9] RFR 8079898: Resolve disabled warnings for libj2ucrypto

On 12/07/2016 03:21 PM, Valerie Peng wrote: Anyone can help reviewing this? The fix is straight forward, just renamed the DEBUG to J2UC_DEBUG to address the E_MACRO_REDEFINED warning. In addition, I also updated the nativeCrypto.h to remove the workaround for a Solaris12-specific issue which has

[9] RFR 8079898: Resolve disabled warnings for libj2ucrypto

Anyone can help reviewing this? The fix is straight forward, just renamed the DEBUG to J2UC_DEBUG to address the E_MACRO_REDEFINED warning. In addition, I also updated the nativeCrypto.h to remove the workaround for a Solaris12-specific issue which has now been fixed. Bug: https://bugs.openj

Re: [9] RFR(XL) 8166417: Integrate Graal-core into JDK for AOT compiler

Perfect. :) Reviewed. igor > On Dec 7, 2016, at 2:10 PM, Vladimir Kozlov > wrote: > > https://bugs.openjdk.java.net/browse/JDK-8166417 > > It is part of JEP 295: Ahead-of-Time Compilation > https://bugs.openjdk.java.net/browse/JDK-8166089 > > http://cr.openjdk.java.net/~kvn/8166417/top.webre

[9] RFR(XL) 8166417: Integrate Graal-core into JDK for AOT compiler

https://bugs.openjdk.java.net/browse/JDK-8166417 It is part of JEP 295: Ahead-of-Time Compilation https://bugs.openjdk.java.net/browse/JDK-8166089 http://cr.openjdk.java.net/~kvn/8166417/top.webrev/ http://cr.openjdk.java.net/~kvn/8166417/jdk.webrev/ http://cr.openjdk.java.net/~kvn/8166417/hotsp

Review Request JDK-8169925: Organize licenses by module in source, JMOD file, and run-time image

This proposes to organize license files by module in source, JMOD, and run-time image. A summary of the proposal: 1. Organize third party notices by module in the source as follows: src/$MODULE/{share,$OS}/legal/* The `legal` directory contains one file for each third party library in the m

Re: [aarch64-port-dev ] RFR: 8168503 JEP 297: Unified arm32/arm64 Port

Thanks Magnus, see comments below .. > On Dec 7, 2016, at 3:44 AM, Magnus Ihse Bursie > wrote: > > On 2016-12-05 16:23, Bob Vandette wrote: >>> On Dec 2, 2016, at 8:04 PM, Vladimir Kozlov >>> wrote: >>> >>> hi Bob, >>> >>> I would suggest to have separat

RFR: JDK-8170863 Always pass MAKE_ARGS to MAKE in Main.gmk

In JDK-8170284, the hotspot build logic was better integrated with the top make level. However, the calls to make there was not provided with MAKE_ARGS. I will push this to jdk9-hs, since JDK-8170284 has still not reached jdk9/dev. Bug: https://bugs.openjdk.java.net/browse/JDK-8170863 WebRev

Re: RFR: JDK-8170863 Always pass MAKE_ARGS to MAKE in Main.gmk

Looks good. /Erik On 2016-12-07 16:07, Magnus Ihse Bursie wrote: In JDK-8170284, the hotspot build logic was better integrated with the top make level. However, the calls to make there was not provided with MAKE_ARGS. I will push this to jdk9-hs, since JDK-8170284 has still not reached jdk

Re: RFR: JDK-8170629 Remove code duplication in test makefiles

Looks good to me. /Erik On 2016-12-06 11:15, Magnus Ihse Bursie wrote: On 2016-12-05 05:34, David Holmes wrote: Hi Magnus, Some independent changes are going to collide here. :) hotspot/make/test/JtregNative.gmk This change has already happened in hs repo - JDK-8169261. Ok, I removed th

Re: RFR: JDK-8141590: Cannot build Zero with devkit

On 2016-12-05 11:07, Erik Joelsson wrote: This patch adds libffi to the linux devkit to enable building of zero. It also adds optional bundling of the libffi library with the JDK. The reason for this is that the devkit sysroot is based on a distro that uses libffi.so.5 while most distros we bui

Re: RFR(XXS): JDK-8170530: bash configure output contains a typo in a suggested library name

Thank you Magnus Best regards, Stanislav Smirnov > 7 дек. 2016 г., в 11:23, Magnus Ihse Bursie > написал(а): > >> On 2016-11-30 12:09, Stanislav Smirnov wrote: >> Hi, >> >> please review this minor fix of a typo I have noticed in "bash configure” >> output when required X11 libraries are mis

Re: [aarch64-port-dev ] RFR: 8168503 JEP 297: Unified arm32/arm64 Port

On 2016-12-05 16:23, Bob Vandette wrote: On Dec 2, 2016, at 8:04 PM, Vladimir Kozlov wrote: hi Bob, I would suggest to have separate webrevs for different repositories because different groups should look on them. There are only 3 non hotspot files and they are on top. Forwarding to build-

Re: RFR(XXS): JDK-8170530: bash configure output contains a typo in a suggested library name

On 2016-11-30 12:09, Stanislav Smirnov wrote: Hi, please review this minor fix of a typo I have noticed in "bash configure” output when required X11 libraries are missing. JBS: https://bugs.openjdk.java.net/browse/JDK-8170530 webrev: http://cr