> On Dec 9, 2016, at 11:51 PM, Erik Joelsson wrote:
>
> Hello Mandy,
>
> In Copy-java.base.gmk. Modules.gmk is no longer needed. JMOD_* varaibles are
> no longer used.
>
Good catch.
> In Main.gmk, it would be good with a comment explaining why the jmods need
> java.base-copy. Something like
Hello Mandy,
In Copy-java.base.gmk. Modules.gmk is no longer needed. JMOD_* varaibles
are no longer used.
In Main.gmk, it would be good with a comment explaining why the jmods
need java.base-copy. Something like:
# All modules include the main license files from java.base.
Otherwise I'm ok
This looks ok to me.
/Erik
On 2016-12-09 10:13, Vladimir Kozlov wrote:
Thank you, Magnus, for review.
I updated webrevs with merge from latest jdk9/hs which now has Jigsaw
update.
http://cr.openjdk.java.net/~kvn/8166417.v2/top.webrev/
http://cr.openjdk.java.net/~kvn/8166417.v2/jdk.webrev/
Erik, Magnus,
I have made the change per your suggestion:
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8169925/webrev.01/
Jeannette, Jeff, and I went through all .md files and I think asm.md is the
only one got the characters messed up. These files are contributed by
Jeannette.
Also, pe
Thank you, Mandy
Vladimir
On 12/9/16 11:00 AM, Mandy Chung wrote:
On Dec 9, 2016, at 10:40 AM, Vladimir Kozlov wrote:
It is very hard to drop the last comma from makefile code. I don't know how to
do that. Please, don't fix this in tool and allow such output.
Otherwise I will have to ret
> On Dec 9, 2016, at 10:40 AM, Vladimir Kozlov
> wrote:
>
>
> It is very hard to drop the last comma from makefile code. I don't know how
> to do that. Please, don't fix this in tool and allow such output.
>
> Otherwise I will have to return back to produces multiple `provides` of the
> sam
On 12/9/16 8:40 AM, Mandy Chung wrote:
On Dec 8, 2016, at 11:07 PM, Vladimir Kozlov wrote:
The new syntax for provides is to have one `provides` clause of the same SPI
with comma-separated implementation classes (see [1] for reference)
Previous loop in this makefile also produces multiple
> On Dec 8, 2016, at 11:07 PM, Vladimir Kozlov
> wrote:
>
>>
>> The new syntax for provides is to have one `provides` clause of the same SPI
>> with comma-separated implementation classes (see [1] for reference)
>
> Previous loop in this makefile also produces multiple `provides` of the same
> On Dec 9, 2016, at 12:25 AM, Doug Simon wrote:
>
> The reason we use VM.savedProps is that initialization of JVMCI and Graal is
> lazy (to avoid impacting VM startup) and can take place after application
> code has been executed. As such, we want to avoid the possibility of
> tampering with
Hello
New webrev: http://cr.openjdk.java.net/~erikj/8170741/webrev.02/
On 2016-12-08 14:19, Magnus Ihse Bursie wrote:
On 2016-12-05 16:35, Erik Joelsson wrote:
For a while now, Oracle engineers have been able to configure builds
of JDK 9 with binary dependencies automatically downloaded from
Hello,
The bundles and the jprt_bundles targets fail when enabling native code
coverage in the build. Currently enabling code coverage is the only way
to generate data for the "symbols" image (because we are still putting
the actual debug symbols in the regular jdk/jre images).
One of the pr
Thank you, Magnus, for review.
I updated webrevs with merge from latest jdk9/hs which now has Jigsaw
update.
http://cr.openjdk.java.net/~kvn/8166417.v2/top.webrev/
http://cr.openjdk.java.net/~kvn/8166417.v2/jdk.webrev/
http://cr.openjdk.java.net/~kvn/8166417.v2/hotspot.webrev/
Removed hotspot
Looks ok to me.
/Erik
On 2016-12-09 03:26, David Buck wrote:
Hi!
Please review this trivial makefile change to disable a problematic
warning.
bug report: https://bugs.openjdk.java.net/browse/JDK-8170954
webrev: http://cr.openjdk.java.net/~dbuck/jdk8170954_ver00/
Cheers,
-Buck
> On 9 Dec 2016, at 08:07, Vladimir Kozlov wrote:
>
> Thank you, Mandy
>
> On 12/8/16 7:46 PM, Mandy Chung wrote:
>>
>>> On Dec 7, 2016, at 2:10 PM, Vladimir Kozlov
>>> wrote:
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8166417
>>>
>>> It is part of JEP 295: Ahead-of-Time Compilation
14 matches
Mail list logo
