Re: RFR(xs): 8171408: [aix] TOC overflow when linking the gtest libjvm.so

Looks good. /Erik On 2016-12-20 09:30, Thomas Stüfe wrote: Hi guys, updated webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8171408-aix-TOC-overflow-when-linking-the-gtest-libjvm/webrev.01/webrev/

Re: RFR(xs): 8171408: [aix] TOC overflow when linking the gtest libjvm.so

Looks good now! Thanks, Volker On Tue, Dec 20, 2016 at 9:30 AM, Thomas Stüfe wrote: > Hi guys, > > updated webrev: > http://cr.openjdk.java.net/~stuefe/webrevs/8171408-aix-TOC-overflow-when-linking-the-gtest-libjvm/webrev.01/webrev/ > > Only change is that I removed the offending filter-out exp

Re: RFR(xs): 8171408: [aix] TOC overflow when linking the gtest libjvm.so

Hi guys, updated webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8171408-aix-TOC-overflow-when-linking-the-gtest-libjvm/webrev.01/webrev/ Only change is that I removed the offending filter-out expression. This means that gtest modules are compiled with both -qpic followed by -qpic=large, but t

Re: RFR(XS): 8168137 - import-hotspot build target not removed from hotspot-ide-project

Looks good. On 2016-12-20 04:15, David Holmes wrote: Hi Christian, On 20/12/2016 8:43 AM, Christian Tornqvist wrote: Hi, Please review this small change to not use the import-hotspot make target, also updated where to find jvm.dll once the build has completed. Tested using make hotspot-

Re: RFR(xs): 8171433: [aix] switch on gtest AIX build

Hi Thomas, the change looks good. Thanks for finally getting gtest to work on AIX! And thank you David for sponsoring. Regards, Volker On Tue, Dec 20, 2016 at 5:35 AM, Thomas Stüfe wrote: > Great, David, please push them all for me. > > The TOC overflow one (8171408) is the only non trivial IM

Re: RFR: JDK-8171409 Create a smoother configure experience on macosx

Looks good. /Erik On 2016-12-18 19:48, Magnus Ihse Bursie wrote: There are some "paper cuts" when running configure on macosx. They are trivial to fix and makes for a smoother experience. Bug: https://bugs.openjdk.java.net/browse/JDK-8171409 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8171

Re: RFR(xs): 8171408: [aix] TOC overflow when linking the gtest libjvm.so

Hi Erik, On Tue, Dec 20, 2016 at 9:17 AM, Erik Joelsson wrote: > Hello, > > I understand why you want to filter out the -qpic flag from the general > JVM_CFLAGS, but that kind of logic is brittle so we try to avoid it unless > absolutely necessary. I prefer to just rely on the tools treating com

Re: RFR(xs): 8171408: [aix] TOC overflow when linking the gtest libjvm.so

Hello, I understand why you want to filter out the -qpic flag from the general JVM_CFLAGS, but that kind of logic is brittle so we try to avoid it unless absolutely necessary. I prefer to just rely on the tools treating command line options as the last one takes precedence. I assume the AIX c

Re: RFR(xs): 8171225: [aix] Build gtests on AIX 7.1 with xlC 12

Thanks Volker! On Tue, Dec 20, 2016 at 9:11 AM, Volker Simonis wrote: > Looks good! > > Volker > > > On Mon, Dec 19, 2016 at 2:33 PM, Thomas Stüfe > wrote: > > > > On Sun, Dec 18, 2016 at 1:13 PM, Thomas Stüfe > > wrote: > >> > >> HI all, > >> > >> after investigating I see a number of issues

Re: RFR(xs): 8171225: [aix] Build gtests on AIX 7.1 with xlC 12

Looks good! Volker On Mon, Dec 19, 2016 at 2:33 PM, Thomas Stüfe wrote: > > On Sun, Dec 18, 2016 at 1:13 PM, Thomas Stüfe > wrote: >> >> HI all, >> >> after investigating I see a number of issues preventing gtest from running >> on AIX, so I decided to get the fix for the wrong assert in the h