Re: [8u] Request for approval for 8172053: (ppc64) Downport of 8170153 breaks build on linux/ppc64 (big endian)

2016-12-27 Thread David Holmes
Hi Volker, As this is a build change I have added build-dev. The change looks fine to me. Aside: More generally it would be nice if there was a simple way to record minimum compiler versions necessary for a given flag/option. Thanks, David On 28/12/2016 3:17 AM, Volker Simonis wrote: Hi,

Re: [OpenJDK 2D-Dev] [9] Review Request: 8140266 Performance loss between jdk8 and jdk9 on Maskfill

2016-12-27 Thread Philip Race
That's fine. -phil. On 12/26/16, 7:06 AM, Sergey Bylokhov wrote: If there are no objections I’ll push this version: http://cr.openjdk.java.net/~serb/8140266/webrev.01/make/lib/Awt2dLibraries.gmk.sdiff.html

RFR: JDK-8171929: "make docs" in clean forest is broken

2016-12-27 Thread Erik Joelsson
The new module, jdk.vm.compiler (as well as jdk.vm.ci), requires access to some of the newly built class files in order to run an annotation processor in the gensrc step. The extra dependency declaration for this is currently missing one module (java.instrument) in make/Main.gmk. To avoid havin

RFR: JDK-8171500: Explicitly set --with-target-bits=64 in 64bit jib profiles

2016-12-27 Thread Erik Joelsson
Hello, If a user asks Jib to build a profile that is supposed to be 64bit, we want configure to fail early if it cannot be done. Currently, if configure thinks the build platform only supports 32bit builds, it will just default to 32bit. By explicitly setting --with-target-bits=64, we instead

RFR: JDK-8171922: Hotspot code coverage doesn't seem to work

2016-12-27 Thread Erik Joelsson
Hello, When the new hotspot build was introduced, we missed converting the support for compiling in code coverage using gcov. This patch fixes that. While making the change I discovered that the LEGACY_EXTRA_*FLAGS variables are now unused and can finally be completely removed, so I went ahea

RFR: JDK-8172037: Change log message of SetupCopyFiles

2016-12-27 Thread Erik Joelsson
The makefile macro SetupCopyFiles is sometimes used for other things than simple copying. In those cases, it would be helpful to also change the log message that the generated recipes print to reflect that. This patch adds such an option to the macro and applies different messages where appropr