RFR JDK-8173140: To upgrade bundled zlib version from 1.2.8 to 1.2.11

2017-01-20 Thread Xueming Shen
Hi, Please review the change to upgrade the zlib bundled in jdk repo from v1.2.8 to v1.2.11. jdk9 by default has been configured to build by using the native/ platform/os's zlib on all non-windows platform [1] So the change will only have effect on the Windows' binaries. issue: https://bugs.o

Re: Review request: JDK-8173085 Warning module name in --add-exports not found: jdk.jdeps when compiling for BUILD_JIGSAW_TOOLS

2017-01-20 Thread Chris Hegarty
On 19/01/17 23:37, Mandy Chung wrote: JDK-8172973 removes the warning emitted at run-time but --add-exports specified at compile-time is not removed. Hence a javac warning is emitted. diff --git a/make/CompileModuleTools.gmk b/make/CompileModuleTools.gmk --- a/make/CompileModuleTools.gmk +++ b

Re: RFR: JDK-8173107 Fix autoconf/spec.gmk mismatches

2017-01-20 Thread Erik Joelsson
Looks good. /Erik On 2017-01-20 09:58, Magnus Ihse Bursie wrote: Over the course of jdk9 development, the variables in the configure script exported using AC_SUBST, the replacement patterns in spec.gmk.in and the usage of spec.gmk in the makefiles have diverged. Fixes: * Remove AC_SUBST fo

Re: RFR: JDK-8173120 Preserve command line at build failure

2017-01-20 Thread Erik Joelsson
Looks good. /Erik On 2017-01-20 12:44, Magnus Ihse Bursie wrote: We have decorated most "typical" build command (such as a Java or native compilation) with ExecuteWithLog, which will save the command lines and output logs from all commands. It will also move the log files into an easy-to-fin

Re: RFR: JDK-8173107 Fix autoconf/spec.gmk mismatches

2017-01-20 Thread David Holmes
On 20/01/2017 8:22 PM, Magnus Ihse Bursie wrote: On 2017-01-20 10:30, David Holmes wrote: Hi Magnus, On 20/01/2017 6:58 PM, Magnus Ihse Bursie wrote: Over the course of jdk9 development, the variables in the configure script exported using AC_SUBST, the replacement patterns in spec.gmk.in and

RFR: JDK-8173120 Preserve command line at build failure

2017-01-20 Thread Magnus Ihse Bursie
We have decorated most "typical" build command (such as a Java or native compilation) with ExecuteWithLog, which will save the command lines and output logs from all commands. It will also move the log files into an easy-to-find location. The command lines used to produce (or to reproduce) a f

Re: RFR: JDK-8173107 Fix autoconf/spec.gmk mismatches

2017-01-20 Thread Magnus Ihse Bursie
On 2017-01-20 10:30, David Holmes wrote: Hi Magnus, On 20/01/2017 6:58 PM, Magnus Ihse Bursie wrote: Over the course of jdk9 development, the variables in the configure script exported using AC_SUBST, the replacement patterns in spec.gmk.in and the usage of spec.gmk in the makefiles have diverg

Re: RFR: JDK-8173107 Fix autoconf/spec.gmk mismatches

2017-01-20 Thread David Holmes
Hi Magnus, On 20/01/2017 6:58 PM, Magnus Ihse Bursie wrote: Over the course of jdk9 development, the variables in the configure script exported using AC_SUBST, the replacement patterns in spec.gmk.in and the usage of spec.gmk in the makefiles have diverged. Fixes: * Remove AC_SUBST for variabl

RFR: JDK-8173107 Fix autoconf/spec.gmk mismatches

2017-01-20 Thread Magnus Ihse Bursie
Over the course of jdk9 development, the variables in the configure script exported using AC_SUBST, the replacement patterns in spec.gmk.in and the usage of spec.gmk in the makefiles have diverged. Fixes: * Remove AC_SUBST for variables not exported or not used in make files. (BOOT_JDK_BITS,