Re: configure - gcc >4.6 needed for JDK9 build

2017-01-24 Thread David Holmes
Hi Kim, On 25/01/2017 7:25 AM, Kim Barrett wrote: On Jan 23, 2017, at 5:34 AM, Mike Burton wrote: Hello, I ran an OpenJDK Hack Day session on Saturday, at which some people got stuck on lost a fair bit of time, failing to build JDK9. Then we found that updating gcc from 4.6 to 4.8 fixed it.

Re: configure - gcc >4.6 needed for JDK9 build

2017-01-24 Thread Kim Barrett
> On Jan 23, 2017, at 5:34 AM, Mike Burton wrote: > > Hello, > > I ran an OpenJDK Hack Day session on Saturday, at which some people got stuck > on lost a fair bit of time, failing to build JDK9. Then we found that > updating gcc from 4.6 to 4.8 fixed it. > Could the `configure` script be upda

Re: RFR [9] Warning notice for types in Incubator Modules

2017-01-24 Thread Michael McMahon
Hi Chris As regards the networking changes, they look fine to me. As discussed off list, I think the link generated by the @Incubating tag might possibly point to a new page in the docs bundle rather than directly to the JEP 11 page. But, that can be the subject of another change. Thanks, Micha

Re: RFR [9] Warning notice for types in Incubator Modules

2017-01-24 Thread Erik Joelsson
Hello, Build changes look good except for one thing. In Javadoc.gmk, the dependency on $(BUILD_TOOLS_JDK) needs to be set for $$($1_INDEX_FILE) (on line 317), where the actual recipes are created. Setting it on the phony docs-javadoc target will not help incremental builds. /Erik On 2017-0

RFR [9] Warning notice for types in Incubator Modules

2017-01-24 Thread Chris Hegarty
As per the guidance in JEP 11 [1], the javadoc for types in incubator modules should have a clear and explicit warning notice. To that end, I’ve added a simple inline taglet that can be used to effectively inject a standard notice, and applied it to all public types in the HTTP module ( I’ll cleanu