Re: RFR: 8173607: JMX RMI connector should be in its own module

2017-02-01 Thread Mandy Chung
> On Feb 1, 2017, at 7:29 AM, Daniel Fuchs wrote: > > Here is the updated webrev, rebased after pulling JDK-8173608, and with > your feedback below integrated. > > I am pleased to report that java.management no longer requires > java.rmi or java.naming :-) > This is great! > Compared to prev

JDK 8 cannot be built on Sierra, correct?

2017-02-01 Thread Jim Laskey (Oracle)
I haven’t tried in a while, but I ran up against it today. Neither the xcode-select (xcode4) or configure --with-xcode-path work. dyld: Library not loaded: @rpath/DVTFoundation.framework/Versions/A/DVTFoundation Referenced from: /Volumes/Elephant/Users/jlaskey/Downloads/Xcode4.app/Contents/De

Re: RFR: 8173607: JMX RMI connector should be in its own module

2017-02-01 Thread Daniel Fuchs
Hi Mandy, On 01/02/17 05:11, Mandy Chung wrote: On Jan 31, 2017, at 10:26 AM, Daniel Fuchs wrote: Hi, Please find below a patch for: 8173607: JMX RMI connector should be in its own module https://bugs.openjdk.java.net/browse/JDK-8173607 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_81

Re: RFR:8170868: DefaultProxySelector should use system defaults on Windows, MacOS and Gnome

2017-02-01 Thread Chris Hegarty
> On 1 Feb 2017, at 12:35, Erik Joelsson wrote: > > Hello, > > In NetworkingLibraries.gmk, the explicit exclusion of > $(JDK_TOPDIR)/src/java.base/unix/native/libnet/DefaultProxySelector.c > shouldn't be necessary. SetupNativeCompilation should pick the first found > source file of the same

Re: RFR:8170868: DefaultProxySelector should use system defaults on Windows, MacOS and Gnome

2017-02-01 Thread Erik Joelsson
Hello, In NetworkingLibraries.gmk, the explicit exclusion of $(JDK_TOPDIR)/src/java.base/unix/native/libnet/DefaultProxySelector.c shouldn't be necessary. SetupNativeCompilation should pick the first found source file of the same name (or rather, that would end up as the same object) and the

Re: RFR:8170868: DefaultProxySelector should use system defaults on Windows, MacOS and Gnome

2017-02-01 Thread Chris Hegarty
Can someone from the build group please give the build part of this the once over. Thanks, -Chris. > On 31 Jan 2017, at 19:14, Zeller, Arno wrote: > > Hi Chris, > > thanks for all the improvements. I imported your webrev and prepared another > webrev: > http://cr.openjdk.java.net/~clanger/web

Re: RFR: JDK-8029942: Update VERSION_MAJOR for JDK 10

2017-02-01 Thread Erik Joelsson
Woho, thanks! /Erik On 2017-02-01 05:50, David Holmes wrote: jdk10/jdk10 is finally "JDK 10" :) David On 27/01/2017 10:26 AM, David Holmes wrote: Hi Erik, As now discovered the version can't be updated until quite a few changes are made in hotspot due to deprecated/obsolete option handling

Re: RFR: 8173607: JMX RMI connector should be in its own module

2017-02-01 Thread Erik Joelsson
Build changes look ok. /Erik On 2017-01-31 19:26, Daniel Fuchs wrote: Hi, Please find below a patch for: 8173607: JMX RMI connector should be in its own module https://bugs.openjdk.java.net/browse/JDK-8173607 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8173607/webrev.05 This patch ma

Re: Review Request: JDK-8173608: Separate JDK management agent from java.management module

2017-02-01 Thread Alan Bateman
On 30/01/2017 23:48, Mandy Chung wrote: Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173608/webrev.00/index.html Just catching up this. It looks like the native methods for jdk.internal.agent.FileSystemImpl have been moved to libmanagemtn_rmi.so, shouldn't this be libmanagem