Re: RFR [9] Warning notice for types in Incubator Modules

2017-02-10 Thread Magnus Ihse Bursie
On 2017-01-30 17:20, Chris Hegarty wrote: Thanks Erik and Magnus, Since this is already pushed, I propose to file a new issue to push these cleanups. Sounds good. Please do that. /Magnus diff --git a/make/Javadoc.gmk b/make/Javadoc.gmk --- a/make/Javadoc.gmk +++ b/make/Javadoc.gmk @@

RE: jdk10 : simplify jexec build settings

2017-02-10 Thread Baesken, Matthias
Hi Eric, thanks for the comment, I think I'll remove the macosx source file . Btw. is there already some test for jexec (a "fast grep" through the jdk tests did not show me much) ? Best regards, Matthias From: Erik Joelsson [mailto:erik.joels...@oracle.com] Sent: Freitag, 10. Februar 2017

Re: jdk10 : simplify jexec build settings

2017-02-10 Thread Erik Joelsson
Since the file has never been built, I would say remove the macosx source file. You can point directly to the unix source dir if you prefer too. No need to have dead logic for macosx in the makefile. /Erik On 2017-02-09 15:27, Baesken, Matthias wrote: I compared the jexec.c versions for

Re: libjvm.so, jmods and --with-native-debug-symbols=internal

2017-02-10 Thread Erik Joelsson
Hello, Oracle builds with external debuginfo and handles packaging of debuginfo in the build, so we don't have this problem. For us the jmods always contain stripped binaries. I guess nobody thought of your process so this is an unfortunate side effect. I don't have any good idea on how to