Re: JDK 9 RFR Enable doclint reference checking for the java.management.rmi module

2017-02-14 Thread Mandy Chung
+1 Mandy > On Feb 14, 2017, at 5:27 PM, joe darcy wrote: > > Hello, > > As a follow-up to enabling doclint reference checking in the java.compiler > modules (JDK-8174945), I checked the other modules where reference checking > is currently disabled and found one where the check could be turn

Re: JDK 9 RFR Enable doclint reference checking for the java.management.rmi module

2017-02-14 Thread Lance Andersen
+1 -- Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPhone > On Feb 14, 2017, at 8:27 PM, joe darcy wrote: > > Hello, > > As a follow-up to enabling doclint reference

JDK 9 RFR Enable doclint reference checking for the java.management.rmi module

2017-02-14 Thread joe darcy
Hello, As a follow-up to enabling doclint reference checking in the java.compiler modules (JDK-8174945), I checked the other modules where reference checking is currently disabled and found one where the check could be turned on: java.management.rmi. Please review the patch below which does

Re: jdk10 : simplify jexec build settings

2017-02-14 Thread Erik Joelsson
Hello, Looks good to me. Fixing jexec is a separate issue and not really build related. /Erik On 2017-02-14 17:27, Baesken, Matthias wrote: Hello, here is the webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8174242/ bug :

RE: jdk10 : simplify jexec build settings

2017-02-14 Thread Baesken, Matthias
Hello, here is the webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8174242/ bug : https://bugs.openjdk.java.net/browse/JDK-8174242 As discussed , I deleted the macosx jexec.c. Btw. I found out that jexec does not work (fully?) in jdk8 / 9 ( seems this has to do with

Re: RFR: JDK-8174895: test/TestCommon.gmk: value of JTREG_TESTVM_MEMORY_OPTION is missing1/2acghpy

2017-02-14 Thread David Holmes
Looks good! Thanks, David On 14/02/2017 6:42 PM, Erik Joelsson wrote: There is a small bug in the new test/TestCommon.gmk that prevents the JTREG_TESTVM_MEMORY_OPTION from propagating to the jtreg command line. The fix is to append to JTREG_TEST_OPTIONS instead of overwriting the current value

RFR: JDK-8174895: test/TestCommon.gmk: value of JTREG_TESTVM_MEMORY_OPTION is missing1/2acghpy

2017-02-14 Thread Erik Joelsson
There is a small bug in the new test/TestCommon.gmk that prevents the JTREG_TESTVM_MEMORY_OPTION from propagating to the jtreg command line. The fix is to append to JTREG_TEST_OPTIONS instead of overwriting the current value further down in the file. Patch provided by Amy Lu. Bug: https://bugs

Re: FR: 8174203: Enable AOT Jtreg tests on Windows x86_64

2017-02-14 Thread Erik Joelsson
Looks good to me. /Erik On 2017-02-13 21:30, Bob Vandette wrote: Please review this change for JDK 10, that enables jtreg testing of Hotspot AOT support on Windows. This change also includes some fixes that allow JPRT to be able to run these tests. Thanks to Erik Joelsson for providing the

Re: JDK 9 RFR Enable doclint reference checking for the java.compiler module

2017-02-14 Thread Erik Joelsson
Looks good. /Erik On 2017-02-13 21:04, joe darcy wrote: Hello, Please review the small patch below to enable the "reference" category of doclint checking (@see and @link tags, etc.) for the java.compiler module which hosts the packages javax.lang.model.*, javax.annotation.processing, and j