RFR: 8173801 Modify makefiles to not build demos and samples bundles.

2017-03-02 Thread Alexandre (Shura) Iline
Hi, Could you be so kind to review suggested changes for the makefiles to stop producing sales and demos bundle. Pls note that this request only changes the makefiles, it does not remove demos and samples source code, which will be done separately. Bug: https://bugs.openjdk.java.net/browse/JDK

Re: RFR: JDK-8176084 Developer-friendly run-test facility

2017-03-02 Thread Jonathan Gibbons
I don't know if it helps or not, but jtreg defines the following exit codes: 0: OK 1: No tests to run ... none specified, or no tests to run in the specified set 2: Some tests failed ... jtreg ran the test and but the test did not pass 3: Some tests had an error ... jtreg could not run the tes

Re: RFR: JDK-8176084 Developer-friendly run-test facility

2017-03-02 Thread Magnus Ihse Bursie
On 2017-03-02 15:37, Erik Joelsson wrote: On 2017-03-02 14:48, Magnus Ihse Bursie wrote: On 2017-03-02 12:19, Erik Joelsson wrote: I don't think I like this part. It's not uncommon to expect non zero return when tests are failing even in developer sessions. If we are to ever convert to us

Re: RFR: JDK-8176084 Developer-friendly run-test facility

2017-03-02 Thread Erik Joelsson
On 2017-03-02 14:48, Magnus Ihse Bursie wrote: On 2017-03-02 12:19, Erik Joelsson wrote: I don't think I like this part. It's not uncommon to expect non zero return when tests are failing even in developer sessions. If we are to ever convert to using this new run-test for automated systems,

Re: RFR: JDK-8176084 Developer-friendly run-test facility

2017-03-02 Thread Magnus Ihse Bursie
On 2017-03-02 12:19, Erik Joelsson wrote: I don't think I like this part. It's not uncommon to expect non zero return when tests are failing even in developer sessions. If we are to ever convert to using this new run-test for automated systems, which we really should, it must return non zero

Re: How to get full path linkage for the jvm shared library

2017-03-02 Thread Jim Laskey (Oracle)
Need a different solution then, -rpath-link doesn’t work -rpath gives me libjvm.so => /usr/lib/jvm/jre/lib/amd64/server/libjvm.so (0x7f711fdaf000) -rpath-link gives me libjvm.so => not found — Jim > On Mar 2, 2017, at 8:55 AM, Andrew Haley wrote: > > On 02/03/17 12:53

Re: How to get full path linkage for the jvm shared library

2017-03-02 Thread Andrew Haley
On 02/03/17 12:53, Jim Laskey (Oracle) wrote: > Seems that -Wl,-rpath, does what I need. -rpath is very dangerous. -rpath-link is much better. Andrew.

Re: How to get full path linkage for the jvm shared library

2017-03-02 Thread Jim Laskey (Oracle)
Seems that -Wl,-rpath, does what I need. > On Mar 1, 2017, at 5:58 PM, Jim Laskey (Oracle) > wrote: > > I have a service library that creates an instance of the jvm (on OEL linux.) > I have no control of where the library is used or how the environment is > configured, ie., it needs to be s

Re: RFR: JDK-8176084 Developer-friendly run-test facility

2017-03-02 Thread Erik Joelsson
I don't think I like this part. It's not uncommon to expect non zero return when tests are failing even in developer sessions. If we are to ever convert to using this new run-test for automated systems, which we really should, it must return non zero on failures. I'm guessing you added this to

Re: RFR: JDK-8176084 Developer-friendly run-test facility

2017-03-02 Thread Magnus Ihse Bursie
Oh no, not that one either? This time I made sure it was sent as HTML. It's probably the openjdk mailer that converts it. *sigh* :-( Here's the markdown source, it's probably more readable than the mangled mess that got through before. # TL;DR. First of all, this does not change or remove an

Re: RFR: JDK-8176084 Developer-friendly run-test facility

2017-03-02 Thread Magnus Ihse Bursie
I'm not sure why all the html formatting was stripped there. Let's give it a new try: TL;DR. First of all, this does not change or remove any current functionality, it only adds new. This new way of running tests is developer-centric. It assumes that you have built a jdk locally and want

Re: RFR: JDK-8176084 Developer-friendly run-test facility

2017-03-02 Thread Magnus Ihse Bursie
On 2017-03-02 09:27, Erik Helin wrote: Hi Magnus, thank you so much for doing this patch! Having a convenient way to run tests from the Makefiles is something I have wanted for a very long time :) Unfortunately I don't have the required Makefile knowledge to review this, but if I can help ou

Re: RFR: JDK-8176084 Developer-friendly run-test facility

2017-03-02 Thread Magnus Ihse Bursie
On 2017-03-02 08:54, David Holmes wrote: Hi Magnus, On 2/03/2017 5:42 PM, Magnus Ihse Bursie wrote: A long-time issue has been a consistent way for developers to effortlessly run tests on local builds. This patch introduces a new, alternative "run-test" target, which allows for a smoother dev

Re: RFR: JDK-8176084 Developer-friendly run-test facility

2017-03-02 Thread Erik Joelsson
Hello Magnus, Overall this is excellent work! But I still have some opinions and questions. I think the implementation of the caching mechanism is a bit weird and it will not handle changes to jtreg test groups (or other test name definition files). I don't think we can expect people to have

Re: RFR: JDK-8176084 Developer-friendly run-test facility

2017-03-02 Thread Erik Helin
Hi Magnus, thank you so much for doing this patch! Having a convenient way to run tests from the Makefiles is something I have wanted for a very long time :) Unfortunately I don't have the required Makefile knowledge to review this, but if I can help out with testing the patch, just let me kno