Re: 8174823: Module system implementation refresh (3/2017)

2017-03-24 Thread Magnus Ihse Bursie
Alright. Thanks for the answers. I'm happy with the build system changes. /Magnus On 2017-03-24 08:58, Alan Bateman wrote: On 23/03/2017 22:24, Mandy Chung wrote: REQUIRED_OS_NAME was used as OS_NAME in `release` file. Previously it was “Darwin” which is inconsistent with the value of “os.

Re: C/C++ IDE support for HotSpot

2017-03-24 Thread Mikael Gerdin
Hi Robbin, On 2017-03-24 09:02, Robbin Ehn wrote: Hi, again, On 03/24/2017 08:58 AM, Robbin Ehn wrote: Hi Mikeal, On 03/22/2017 05:20 PM, Erik Österlund wrote: Hi Mikael, In my workflow I use emacs with rtags for snytax awareness. With your cmake patch, I could easily generate the cmake fil

Re: C/C++ IDE support for HotSpot

2017-03-24 Thread Robbin Ehn
Hmmz, brain not functioning. On 03/24/2017 09:02 AM, Robbin Ehn wrote: I have still gotten my morning coffee, this step I have to do anyways of course. NOT /Robbin

Re: C/C++ IDE support for HotSpot

2017-03-24 Thread Robbin Ehn
Hi, again, On 03/24/2017 08:58 AM, Robbin Ehn wrote: Hi Mikeal, On 03/22/2017 05:20 PM, Erik Österlund wrote: Hi Mikael, In my workflow I use emacs with rtags for snytax awareness. With your cmake patch, I could easily generate the cmake files and run cmake with -DCMAKE_EXPORT_COMPILE_COMMA

Re: C/C++ IDE support for HotSpot

2017-03-24 Thread Robbin Ehn
Hi Mikeal, On 03/22/2017 05:20 PM, Erik Österlund wrote: Hi Mikael, In my workflow I use emacs with rtags for snytax awareness. With your cmake patch, I could easily generate the cmake files and run cmake with -DCMAKE_EXPORT_COMPILE_COMMANDS to generate the compiler_commands.json file used b

Re: 8174823: Module system implementation refresh (3/2017)

2017-03-24 Thread Alan Bateman
On 23/03/2017 22:24, Mandy Chung wrote: REQUIRED_OS_NAME was used as OS_NAME in `release` file. Previously it was “Darwin” which is inconsistent with the value of “os.name” system property (“Mac OS X”). This change made OS_NAME to contain the same value as “os.name” system property. Right,