Re: getting toolchain to be used

2017-05-03 Thread Xen
David Holmes schreef op 04-05-2017 4:20: Hi Xen, Quite the adventure. Note that the options I suggested were all you should need, not options you need in addition to what you had attempted. And yes you need the symlinks to the simple names - gcc etc. You are building something that was never p

Re: getting toolchain to be used

2017-05-03 Thread David Holmes
Hi Xen, Quite the adventure. Note that the options I suggested were all you should need, not options you need in addition to what you had attempted. And yes you need the symlinks to the simple names - gcc etc. You are building something that was never provided by the OpenJDK. There is no AR

Re: getting toolchain to be used

2017-05-03 Thread Xen
David Holmes schreef op 03-05-2017 6:07: For cross compilation you should need to set the following only: So basically I know have a working HotSpot build for u101 but u131 and u121 fail because a single cpp file references a variable that doesn't exist anywhere in the source code. I know it

Re: RFR: JDK-8179556 Add specs copyright file

2017-05-03 Thread Mandy Chung
Looks good. Mandy > On May 3, 2017, at 7:02 AM, Magnus Ihse Bursie > wrote: > > The new $module/specs specifications needs to point to a proper copyright > file. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8179556 > WebRev: > http://cr.openjdk.java.net/~ihse/JDK-8179556-add-legal-copy

Re: getting toolchain to be used

2017-05-03 Thread Xen
David Holmes schreef op 03-05-2017 6:07: ARCH arm ALT_COMPILER_PATH ALT_OPENWIN_HOME CROSS_COMPILE_ARCH arm EXTRA_CFLAGS In the forest of options, I actually forgot some of those :p. I am trying to compile headless though. the local toolchain will be used for things that need to be comp

Re: RFR: JDK-8179557 Update generated Javadoc footer documentation link

2017-05-03 Thread Erik Joelsson
Looks good. /Erik On 2017-05-03 07:08, Magnus Ihse Bursie wrote: Update the JDK Javadoc footer link from [1] to [2]. [1] http://docs.oracle.com/javase/9/docs/index.html [2] http://www.oracle.com/pls/topic/lookup?ctx=javase9&id=homepage Bug: https://bugs.openjdk.java.net/browse/JDK-8179557 P

Re: RFR: JDK-8179556 Add specs copyright file

2017-05-03 Thread Erik Joelsson
Looks good. /Erik On 2017-05-03 07:02, Magnus Ihse Bursie wrote: The new $module/specs specifications needs to point to a proper copyright file. Bug: https://bugs.openjdk.java.net/browse/JDK-8179556 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8179556-add-legal-copyright-html/webrev.01 /M

RFR: JDK-8179557 Update generated Javadoc footer documentation link

2017-05-03 Thread Magnus Ihse Bursie
Update the JDK Javadoc footer link from [1] to [2]. [1] http://docs.oracle.com/javase/9/docs/index.html [2] http://www.oracle.com/pls/topic/lookup?ctx=javase9&id=homepage Bug: https://bugs.openjdk.java.net/browse/JDK-8179557 Patch inline: diff --git a/make/Javadoc.gmk b/make/Javadoc.gmk --- a/m

RFR: JDK-8179556 Add specs copyright file

2017-05-03 Thread Magnus Ihse Bursie
The new $module/specs specifications needs to point to a proper copyright file. Bug: https://bugs.openjdk.java.net/browse/JDK-8179556 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8179556-add-legal-copyright-html/webrev.01 /Magnus

Graal missing from MacOS Java 9 EA download b167

2017-05-03 Thread Lennart Börjeson
Graal (e.g. the module jdk.internal.vm.compiler) seems to be missing from the Java 9 Early-Access download for MacOS. I noticed this with b166 and it is still so in b167. As it is perfectly possible (I’ve done it) to download the source, configure the build to include graal, and build it, I su

Re: RFR: JDK-8179438: Incremental builds broken on Windows

2017-05-03 Thread Magnus Ihse Bursie
On 2017-05-03 00:00, Erik Joelsson wrote: This is the same fix as I already din in JDK 10 in JDK-8179079. The problem was annoying enough that we need it fixed in 9 too. The patch is exactly the same. Bug: https://bugs.openjdk.java.net/browse/JDK-8179438 diff -r 143d4c87bc1e make/common/Nativ

Re: RFR: JDK-8179453 Add a proper SetupProcessMarkdown

2017-05-03 Thread Magnus Ihse Bursie
On 2017-05-02 20:32, Erik Joelsson wrote: Hello, Looks good. For efficiency reasons, I would recommend the following change: Assign $1_$2_OPTIONS using just = for lazy evaluation so that we only do the shell call if executing the recipe. Also remove it from VARDEPS because the contents of O