Re: RFR: 8179915: Update extLink taglet to allow not linking the description

2017-05-10 Thread David Holmes
On 11/05/2017 3:18 AM, Kumar Srinivasan wrote: On 5/10/2017 9:51 AM, Erik Joelsson wrote: Should this be set on the javadoc command line somewhere or am I missing something? Yes, one would have to set this prop, via the build system, when performing a non-oracle build. Shouldn't that be inv

Re: RFR: JDK-8180083: Adjust Jib and JDL configurations for 9 to support new generation Mach 5

2017-05-10 Thread Tim Bell
Erik: This patch contains adjustments for the jib-profiles.js configuration needed for supporting the next generation Oracle internal build and test system. This is largely the same changes as in 8180081 for JDK 10. Bug: https://bugs.openjdk.java.net/browse/JDK-8180083 Webrev: http://cr.openjd

Re: RFR: JDK-8180081: Adjust Jib and JDL configuration for 10 to support promotable builds

2017-05-10 Thread Tim Bell
Erik: Looks good to me as well. Tim On 05/10/17 14:26, Christian Tornqvist wrote: Hi Erik, This looks good, thanks for fixing this! Thanks, Christian On May 10, 2017, at 2:12 PM, Erik Joelsson wrote: This patch contains adjustments for the jib-profiles.js configuration needed for suppor

RFR: JDK-8180083: Adjust Jib and JDL configurations for 9 to support new generation Mach 5

2017-05-10 Thread Erik Joelsson
This patch contains adjustments for the jib-profiles.js configuration needed for supporting the next generation Oracle internal build and test system. This is largely the same changes as in 8180081 for JDK 10. Bug: https://bugs.openjdk.java.net/browse/JDK-8180083 Webrev: http://cr.openjdk.java

Re: RFR: XS: URGENT: JDK-8180129, , Bundles.gmk:181: *** unterminated call to function 'filter-out': missing ')'

2017-05-10 Thread Brad R. Wetmore
Looks good. Brad On 5/10/2017 3:06 PM, Tim Bell wrote: A fix for packaging changes in the closed files missed one line continuation in an open file, and without this all builds fail: % hg diff diff --git a/make/Bundles.gmk b/make/Bundles.gmk --- a/make/Bundles.gmk +++ b/make/Bundles.gmk @@ -1

Re: RFR: XS: URGENT: JDK-8180129, , Bundles.gmk:181: *** unterminated call to function 'filter-out': missing ')'

2017-05-10 Thread Erik Joelsson
Looks good. Thanks for fixing this! /Erik On 2017-05-10 15:06, Tim Bell wrote: A fix for packaging changes in the closed files missed one line continuation in an open file, and without this all builds fail: % hg diff diff --git a/make/Bundles.gmk b/make/Bundles.gmk --- a/make/Bundles.gmk +++

RFR: XS: URGENT: JDK-8180129, , Bundles.gmk:181: *** unterminated call to function 'filter-out': missing ')'

2017-05-10 Thread Tim Bell
A fix for packaging changes in the closed files missed one line continuation in an open file, and without this all builds fail: % hg diff diff --git a/make/Bundles.gmk b/make/Bundles.gmk --- a/make/Bundles.gmk +++ b/make/Bundles.gmk @@ -183,7 +183,7 @@ $(JDK_SYMBOLS_EXCLUDE_PATTERN) \

Re: RFR: JDK-8180081: Adjust Jib and JDL configuration for 10 to support promotable builds

2017-05-10 Thread Christian Tornqvist
Hi Erik, This looks good, thanks for fixing this! Thanks, Christian > On May 10, 2017, at 2:12 PM, Erik Joelsson wrote: > > This patch contains adjustments for the jib-profiles.js configuration needed > for supporting the next generation Oracle internal build and test system. > > Bug: https:

RFR: JDK-8180081: Adjust Jib and JDL configuration for 10 to support promotable builds

2017-05-10 Thread Erik Joelsson
This patch contains adjustments for the jib-profiles.js configuration needed for supporting the next generation Oracle internal build and test system. Bug: https://bugs.openjdk.java.net/browse/JDK-8180081 Webrev: http://cr.openjdk.java.net/~erikj/8180081/webrev.01/ /Erik

Re: RFR: 8179915: Update extLink taglet to allow not linking the description

2017-05-10 Thread Kumar Srinivasan
On 5/10/2017 9:51 AM, Erik Joelsson wrote: Should this be set on the javadoc command line somewhere or am I missing something? Yes, one would have to set this prop, via the build system, when performing a non-oracle build. Kumar /Erik On 2017-05-10 09:42, Kumar Srinivasan wrote: Hi, Pl

Re: RFR: 8179915: Update extLink taglet to allow not linking the description

2017-05-10 Thread Erik Joelsson
Should this be set on the javadoc command line somewhere or am I missing something? /Erik On 2017-05-10 09:42, Kumar Srinivasan wrote: Hi, Please review fix for the custom taglet to allow openjdk builds, in which case the property "build.tools.taglet.ExtLink.NO_LINK" must be set to inhibit

RFR: 8179915: Update extLink taglet to allow not linking the description

2017-05-10 Thread Kumar Srinivasan
Hi, Please review fix for the custom taglet to allow openjdk builds, in which case the property "build.tools.taglet.ExtLink.NO_LINK" must be set to inhibit server side lookups. Thanks Kumar Webrev: http://cr.openjdk.java.net/~ksrini/8179915/webrev.0 JBS: https://bugs.openjdk.java.net/browse/

Re: RFR: JDK-8179105 A new property to specify import module to be included in unified docs bundle

2017-05-10 Thread Erik Joelsson
Looks good. /Erik On 2017-05-10 01:18, Magnus Ihse Bursie wrote: javafx modules include a `build.properties` file to specify the properties when being imported in JDK image build. `make docs` currently includes all imported modules. A new property e.g. `include_in_docs` would allow FX to s

Re: RFR: JDK-8174848 Remove gpl templates from hotspot/make

2017-05-10 Thread Erik Joelsson
Looks good. /Erik On 2017-05-10 06:03, Magnus Ihse Bursie wrote: The GPL templates in hotspot/make are not used anymore. The templates in $TOPDIR/make/templates remain. Bug: https://bugs.openjdk.java.net/browse/JDK-8174848 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8174848-remove-hotspot-

Re: JDK-8175825 Stop including pubs repo

2017-05-10 Thread Erik Joelsson
Open part looks good. /Erik On 2017-05-10 02:12, Magnus Ihse Bursie wrote: Here are some externally visible changes for an internal change: we will stop copying documentation from the "pubs" repo, and some of that logic has leaked through into the open parts, and will be removed with this pa

Re: RFR: JDK-8179105 A new property to specify import module to be included in unified docs bundle

2017-05-10 Thread Mandy Chung
+1 thanks Mandy > On May 10, 2017, at 1:18 AM, Magnus Ihse Bursie > wrote: > > javafx modules include a `build.properties` file to specify the properties > when being imported in JDK image build. `make docs` currently includes all > imported modules. > > A new property e.g. `include_in_do

RFR: JDK-8174848 Remove gpl templates from hotspot/make

2017-05-10 Thread Magnus Ihse Bursie
The GPL templates in hotspot/make are not used anymore. The templates in $TOPDIR/make/templates remain. Bug: https://bugs.openjdk.java.net/browse/JDK-8174848 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8174848-remove-hotspot-gpl-templates/webrev.01 /Magnus

JDK-8175825 Stop including pubs repo

2017-05-10 Thread Magnus Ihse Bursie
Here are some externally visible changes for an internal change: we will stop copying documentation from the "pubs" repo, and some of that logic has leaked through into the open parts, and will be removed with this patch. I have also renamed Javadoc.gmk to Docs.gmk to better fit the current pu

RFR: JDK-8179105 A new property to specify import module to be included in unified docs bundle

2017-05-10 Thread Magnus Ihse Bursie
javafx modules include a `build.properties` file to specify the properties when being imported in JDK image build. `make docs` currently includes all imported modules. A new property e.g. `include_in_docs` would allow FX to select which FX modules to be included in the docs bundle. Bug: https

Re: RFR: JDK9 b167: demos exist in JDK bundles

2017-05-10 Thread Magnus Ihse Bursie
On 2017-05-10 01:28, Erik Joelsson wrote: We recently stopped building the JDK demos, or at least most of them. For client testing purposes we are still building some of them, and those are now ending up in the JDK bundle. Since we are very late in JDK 9, we do not want to interrupt the testing