Re: RFR: JDK-8180178 Restructure existing man pages according to JEP 299

2017-05-11 Thread Magnus Ihse Bursie
(Sorry if this is a bit TL, please don't DR though...) Good we started clearing this up! Let me start with a recap of the current situation: The man pages exist in the source code in OpenJDK. During the build, they get copied to the JRE and JDK image, in the normal OpenJDK build. (Let me remind

Re: RFR: JDK-8180178 Restructure existing man pages according to JEP 299

2017-05-11 Thread David Holmes
Sorry but: > Nevertheless, I believe having man pages (even if outdated) is > better for the community than not having man pages. is not something I can agree with at all. This seems quite a ridiculous situation. We have not updated and maintained these manpages, they have been slated for remo

Re: Review Request: JDK-8180208 Provide a new docs bundle page

2017-05-11 Thread Mandy Chung
> On May 11, 2017, at 4:08 PM, Jonathan Gibbons > wrote: > > Mandy, > > The tag on line 2 of > http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8180208/webrev.00/jdk/make/src/classes/build/tools/docs/docs-bundle-page.html.html > > should have >lang=“en" > Fixed. > One line 50, >cla

Re: RFR: JDK-8180178 Restructure existing man pages according to JEP 299

2017-05-11 Thread Mandy Chung
> On May 11, 2017, at 5:44 PM, Erik Joelsson wrote: > > > > On 2017-05-11 15:38, Mandy Chung wrote: >> Magnus, >> >> I’m surprised to see the man pages are moved to src/$MODULE/share/man >> directory. These man pages are not maintained and not updated. It’s agreed >> that the man pages are

Re: Review Request: JDK-8180208 Provide a new docs bundle page

2017-05-11 Thread Mandy Chung
> On May 11, 2017, at 7:25 PM, Weijun Wang wrote: > > > On 05/12/2017 06:58 AM, Mandy Chung wrote: >> The old docs bundle page (aka layer cake) is legacy and not maintained. In >> JDK 9, we replace it with a simple page listing modules by groups. This >> page can continuously be improved. >

Re: Review Request: JDK-8180208 Provide a new docs bundle page

2017-05-11 Thread Weijun Wang
On 05/12/2017 06:58 AM, Mandy Chung wrote: The old docs bundle page (aka layer cake) is legacy and not maintained. In JDK 9, we replace it with a simple page listing modules by groups. This page can continuously be improved. http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8180208/docs/do

Re: RFR: JDK-8180178 Restructure existing man pages according to JEP 299

2017-05-11 Thread Jonathan Gibbons
On 05/11/2017 05:44 PM, Erik Joelsson wrote: On 2017-05-11 15:38, Mandy Chung wrote: Magnus, I’m surprised to see the man pages are moved to src/$MODULE/share/man directory. These man pages are not maintained and not updated. It’s agreed that the man pages are specification for the tools

Re: RFR: JDK-8180178 Restructure existing man pages according to JEP 299

2017-05-11 Thread Erik Joelsson
On 2017-05-11 15:38, Mandy Chung wrote: Magnus, I’m surprised to see the man pages are moved to src/$MODULE/share/man directory. These man pages are not maintained and not updated. It’s agreed that the man pages are specification for the tools that we should write and include in the source

Re: Review Request: JDK-8180208 Provide a new docs bundle page

2017-05-11 Thread Jonathan Gibbons
Mandy, The tag on line 2 of http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8180208/webrev.00/jdk/make/src/classes/build/tools/docs/docs-bundle-page.html.html should have lang="en" One line 50, class="striped" is unnecessary, since we are not referring to a class in a stylesheet. The

Review Request: JDK-8180208 Provide a new docs bundle page

2017-05-11 Thread Mandy Chung
The old docs bundle page (aka layer cake) is legacy and not maintained. In JDK 9, we replace it with a simple page listing modules by groups. This page can continuously be improved. http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8180208/docs/docs-index.html This is generated by a build to

Re: RFR: JDK-8180178 Restructure existing man pages according to JEP 299

2017-05-11 Thread Mandy Chung
Magnus, I’m surprised to see the man pages are moved to src/$MODULE/share/man directory. These man pages are not maintained and not updated. It’s agreed that the man pages are specification for the tools that we should write and include in the source under src/$MODULE/share/man directory. How

Re: RFR: 8179915: Update extLink taglet to allow not linking the description

2017-05-11 Thread Jonathan Gibbons
Roger, We discussed this in the original design. This is a JDK-specific taglet, for use in the JDK-build, for building JDK API-specifications, that may or may not link to some commercial documentation. There is no intent to support {@extLink} for anything outside its limited use in the JDK

Re: RFR: 8179915: Update extLink taglet to allow not linking the description

2017-05-11 Thread Roger Riggs
Hi, I would generalize it just a bit by taking the URL from the system property; if the property was set it would use the URL and if not generate the citation. Then the taglet could be used a bit more broadly without complicating the build or code. $.02, Roger On 5/11/2017 4:51 PM, Kumar Sr

Re: RFR: 8179915: Update extLink taglet to allow not linking the description

2017-05-11 Thread Kumar Srinivasan
Hi, Changes in this webrev: * inverted the logic as you suggested * some doc comment changes to reflect the change http://cr.openjdk.java.net/~ksrini/8179915/webrev.1/ Thanks Kumar On 5/10/2017 7:19 PM, David Holmes wrote: On 11/05/2017 3:18 AM, Kumar Srinivasan wrote: On 5/10/2017 9:51 AM,

Re: RFR: 8179915: Update extLink taglet to allow not linking the description

2017-05-11 Thread Kumar Srinivasan
Hi Roger, This is a build tool, ie. a tool used by the build system, potentially could be documented in the build notes. Kumar Hi, That's a pretty cryptic property, where will it be documented? Release noted? Is there any build option to set it so someone doesn't have to circumvent the b

Re: RFR: JDK-8180178 Restructure existing man pages according to JEP 299

2017-05-11 Thread Erik Joelsson
Looks like this follows JEP 299 so OK by me. I do find it a bit strange that we move the man pages out of the JDK/JRE images though. /Erik On 2017-05-11 05:56, Magnus Ihse Bursie wrote: In preparation for JDK-8178317, the existing man page troff sources will be moved to their corresponding mo

Re: RFR: JDK-8180083: Adjust Jib and JDL configurations for 9 to support new generation Mach 5

2017-05-11 Thread Magnus Ihse Bursie
Looks good to me. /Magnus On 2017-05-11 00:14, Erik Joelsson wrote: This patch contains adjustments for the jib-profiles.js configuration needed for supporting the next generation Oracle internal build and test system. This is largely the same changes as in 8180081 for JDK 10. Bug: https://b

Re: RFR: JDK-8180081: Adjust Jib and JDL configuration for 10 to support promotable builds

2017-05-11 Thread Magnus Ihse Bursie
Looks good to me. /Magnus On 2017-05-10 23:12, Erik Joelsson wrote: This patch contains adjustments for the jib-profiles.js configuration needed for supporting the next generation Oracle internal build and test system. Bug: https://bugs.openjdk.java.net/browse/JDK-8180081 Webrev: http://cr.

Re: RFR: 8179915: Update extLink taglet to allow not linking the description

2017-05-11 Thread Roger Riggs
Hi, That's a pretty cryptic property, where will it be documented? Release noted? Is there any build option to set it so someone doesn't have to circumvent the build system to get the effect? Thanks, Roger On 5/10/2017 12:42 PM, Kumar Srinivasan wrote: Hi, Please review fix for the custo

RFR: JDK-8180178 Restructure existing man pages according to JEP 299

2017-05-11 Thread Magnus Ihse Bursie
In preparation for JDK-8178317, the existing man page troff sources will be moved to their corresponding modules, according to the layout determined by JEP 299. During the docs build, they will be copied to the man directory in the docs image, as specified by JEP 299. No markdown conversion wil