RFR: 8189706: javadoc for the Jdk APIs should summarize overridden methods with no specification changes

2017-10-19 Thread Kumar Srinivasan
Hello, Please review build change to enable the javadoc tool to produce concise API documentation for those classes that override a method without changing its specification see [2], this change simply enables that feature in the javadoc tool. diff --git a/make/Docs.gmk b/make/Docs.gmk ---

Re: [urgent] RFR: JDK-8189679: JDK-8189094 broke testing in Mach 5

2017-10-19 Thread mandy chung
Looks good. Mandy On 10/19/17 8:29 AM, Erik Joelsson wrote: In the change for JDK-8189094 I accidentally broke testing in Mach 5. The problem is in jib-profiles.js where the definition of boot_jdk_home is no longer defined globally in the common object, and because of this, JT_JAVA does not g

Re: [urgent] RFR: JDK-8189679: JDK-8189094 broke testing in Mach 5

2017-10-19 Thread Tim Bell
Erik: In the change for JDK-8189094 I accidentally broke testing in Mach 5. The problem is in jib-profiles.js where the definition of boot_jdk_home is no longer defined globally in the common object, and because of this, JT_JAVA does not get a good value in the run-test* profiles. This patch re

[urgent] RFR: JDK-8189679: JDK-8189094 broke testing in Mach 5

2017-10-19 Thread Erik Joelsson
In the change for JDK-8189094 I accidentally broke testing in Mach 5. The problem is in jib-profiles.js where the definition of boot_jdk_home is no longer defined globally in the common object, and because of this, JT_JAVA does not get a good value in the run-test* profiles. This patch restore

Re: RFR: JDK-8182285: Speeding up incremental build by hashing module APIs

2017-10-19 Thread Magnus Ihse Bursie
On 2017-10-19 15:47, Erik Joelsson wrote: This patch introduces a new Javac plugin as a build tool, written by Jan Lahoda. The plugin creates a hash of the public API of what is being compiled and puts it in a file. The file is only updated if there is a difference compared to the current conte

Re: RFR: JDK-8189056 javadoc target for stable specdiff comparisons

2017-10-19 Thread Magnus Ihse Bursie
On 2017-10-19 16:13, Erik Joelsson wrote: I believe this looks good for generating the docs. For consumption, we also need to define a new bundle and configure Jib to upload it. Functionality for bundling and uploading these "reference" docs would probably be a good thing to have, but I it's k

Re: RFR: JDK-8189056 javadoc target for stable specdiff comparisons

2017-10-19 Thread Erik Joelsson
I believe this looks good for generating the docs. For consumption, we also need to define a new bundle and configure Jib to upload it. /Erik On 2017-10-19 14:30, Magnus Ihse Bursie wrote: From the bug report: "For JSR 383 (Java SE 18.3), we need weekly diffs of the Java SE 18.3 API specifica

RFR: JDK-8182285: Speeding up incremental build by hashing module APIs

2017-10-19 Thread Erik Joelsson
This patch introduces a new Javac plugin as a build tool, written by Jan Lahoda. The plugin creates a hash of the public API of what is being compiled and puts it in a file. The file is only updated if there is a difference compared to the current contents of the file. I have provided the integ

Re: RFR: JDK-8189664: Stop producing ARCHIVE_BUNDLE.zip from test makefiles unless asked to

2017-10-19 Thread David Holmes
Looks okay. Thanks, David On 19/10/2017 10:32 PM, Erik Joelsson wrote: In test/TestCommon.gmk the jtreg invocation will unconditionally produce an archive bundle, a zip file consisting of all the output from jtreg. When testing in JPRT, JPRT sets JPRT_ARCHIVE_BUNDLE to override the name of th

RFR: JDK-8189664: Stop producing ARCHIVE_BUNDLE.zip from test makefiles unless asked to

2017-10-19 Thread Erik Joelsson
In test/TestCommon.gmk the jtreg invocation will unconditionally produce an archive bundle, a zip file consisting of all the output from jtreg. When testing in JPRT, JPRT sets JPRT_ARCHIVE_BUNDLE to override the name of this zip. In all other situation, I can't see the point of creating it. It

RFR: JDK-8189056 javadoc target for stable specdiff comparisons

2017-10-19 Thread Magnus Ihse Bursie
From the bug report: "For JSR 383 (Java SE 18.3), we need weekly diffs of the Java SE 18.3 API specification. The current "doc-javase" makefile target always uses the most recent version of the javadoc tool (i.e. the tool that was just built). Unfortunately, this introduces unwanted diffs that