Re: version numbers for distribution builds?

2017-10-31 Thread Matthias Klose
On 27.10.2017 12:46, Magnus Ihse Bursie wrote: > > On 2017-10-27 12:21, David Holmes wrote: >> Adding build-dev. >> >> David >> >> On 27/10/2017 9:13 AM, Matthias Klose wrote: >>> On 27.10.2017 00:56, Matthias Klose wrote: Hi, I recently learned that I should configure an openjdk bu

RFR: JDK-8190410 Help.gmk is not updated after consolidation

2017-10-31 Thread Magnus Ihse Bursie
The help text for "make help" still mentions the old repos. Also fixed some other minor issues. Bug: https://bugs.openjdk.java.net/browse/JDK-8190410 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8190410-update-make-help/webrev.01 /Magnus

Re: RFR [10] 8189800: Add support for AddressSanitizer

2017-10-31 Thread Magnus Ihse Bursie
On 2017-10-31 13:24, David Holmes wrote: Sounds reasonable. Anyone using older gcc simply won't/shouldn't enable Asan. Agree. We will probably not be keeping any pretense of supporting anything older than gcc 4.9 at some point in time anyway. I believe the only known user of the oldest gcc is

Re: RFR [10] 8189800: Add support for AddressSanitizer

2017-10-31 Thread Magnus Ihse Bursie
On 2017-10-30 10:31, Artem Smotrakov wrote: Hi Magnus, The current approach uses AddressSanitizer as a shared library (libasan.so) which is part of GCC/Clang toolkit. In case you use system toolkit, then libasan.so is available for linker and at runtime. But if you set a custom toolkit by --w

Re: RFR [10] 8189800: Add support for AddressSanitizer

2017-10-31 Thread David Holmes
Sounds reasonable. Anyone using older gcc simply won't/shouldn't enable Asan. Thanks, David On 31/10/2017 8:58 PM, Artem Smotrakov wrote: Hi David, That's a good question, I thought about it. According to [1]: - recommended versions of gcc is 4.9.2 - the minimum accepted version of gcc is 4.

Re: RFR [10] 8189800: Add support for AddressSanitizer

2017-10-31 Thread Artem Smotrakov
Hi David, That's a good question, I thought about it. According to [1]: - recommended versions of gcc is 4.9.2 - the minimum accepted version of gcc is 4.7 (Older versions will generate a warning by `configure` and are unlikely to work.) - the minimum accepted version of clang is 3.2 (Older ver

Re: RFR [10] 8189800: Add support for AddressSanitizer

2017-10-31 Thread David Holmes
Hi Artem, On 28/10/2017 6:02 AM, Artem Smotrakov wrote: Hello, Please review the following patch which adds support for AddressSanitizer. AddressSanitizer is a runtime memory error detector which looks for various memory corruption issues and leaks. Please refer to [1] for details. AddressS