Re: RFR: JDK-8189099 JTReg now supports 256 jobs

2017-11-24 Thread Martin Buchholz
Looks good. On Fri, Nov 24, 2017 at 2:22 AM, Magnus Ihse Bursie < magnus.ihse.bur...@oracle.com> wrote: > From the bug report: > "According to research by Jonathan Gibbons , JTReg now supports 256 jobs, > in contrast to the older limit of 50 jobs. This limit is enforced in the > make files, and i

Re: RFR: JDK-8191856 "make clean-test" does not work properly

2017-11-24 Thread Martin Buchholz
Should all phony targets be listed in a .PHONY line? On Fri, Nov 24, 2017 at 2:45 AM, Magnus Ihse Bursie < magnus.ihse.bur...@oracle.com> wrote: > With the new layout of make run-test, the test-results and test-support > directories are not removed by "make clean-test", and not even "make clean".

Re: Problems with JDK8 build on Ubuntu?

2017-11-24 Thread dalibor topic
The cpio message comes from OpenJDK's configure script. See http://hg.openjdk.java.net/jdk8u/jdk8u/file/a0672a294b9a/common/autoconf/basics.m4 BASIC_REQUIRE_PROG(CPIO, cpio) I would doubt that all OpenJDK build dependencies are part of the typical docker image, so you should run apt-get bu

RFR: JDK-8191856 "make clean-test" does not work properly

2017-11-24 Thread Magnus Ihse Bursie
With the new layout of make run-test, the test-results and test-support directories are not removed by "make clean-test", and not even "make clean". Bug: https://bugs.openjdk.java.net/browse/JDK-8191856 Patch inline: diff --git a/make/Main.gmk b/make/Main.gmk --- a/make/Main.gmk +++ b/make/Main

Re: problem building client variant in 9.0.1+11

2017-11-24 Thread Mete Balci
Thanks Erik, I understand. I did patch the jvm.cfg (aliased server to client) and then I had to do something for the errors below, so I added JVMCI_FLAG_CHECKED for both MaxVectorSize and ReduceInitialCardMarks to JVMCIGlobals::check_jvmci_flags_are_consistent() -no idea if this is correct but not

RFR: JDK-8179555 make run-test should always use a fresh, clean JTwork directory

2017-11-24 Thread Magnus Ihse Bursie
When running jtreg tests, make run-test should always run with a fresh, clean JTwork directory in order to avoid issues with code not being recompiled. Bug: https://bugs.openjdk.java.net/browse/JDK-8179555 Patch inline: diff --git a/make/RunTests.gmk b/make/RunTests.gmk --- a/make/RunTests.gmk

RFR: JDK-8189099 JTReg now supports 256 jobs

2017-11-24 Thread Magnus Ihse Bursie
From the bug report: "According to research by Jonathan Gibbons , JTReg now supports 256 jobs, in contrast to the older limit of 50 jobs. This limit is enforced in the make files, and it should be updated to reflect the new limit (or the check removed entirely)." I choose to remove the check.

RFR: JDK-8179554 make run-test does not respect ProblemList.txt

2017-11-24 Thread Magnus Ihse Bursie
When running tests with `make run-test`, tests from jdk/test/ProblemList.txt and/or hotspot/test/ProblemList.txt aren't excluded. Bug: https://bugs.openjdk.java.net/browse/JDK-8179554 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8179554-run-test-should-respect-problem-list/webrev.01 /Magnus

Re: Problems with JDK8 build on Ubuntu?

2017-11-24 Thread Ted Neward
Changing it up just a touch…. I got it to build fine inside of Ubuntu 16 (and, just for kicks, Kubuntu, since I prefer KDE as a GUI) without flaw. But when I try to do it in a Docker image, I get a weird configure error: “Could not find cpio!” Googling around reveals that cpio (as far as apt p

RFR: JDK-8177957 run-test summary lines look bad/misleading with long test names

2017-11-24 Thread Magnus Ihse Bursie
When running individual tests using run-test, the summary section gets hard to read. For instance: (imagine having a fixed-with font :))    TEST TOTAL PASS FAIL ERROR    jtreg:hotspot/test/gc/stress/gcbasher/TestGCBasherWithG1.java 1 1 0 0 What makes this exact example even worse is that it alig

Re: RFR: JDK-8191205 Set native-debug-symbols default to "external"

2017-11-24 Thread Magnus Ihse Bursie
On 2017-11-23 16:56, Erik Joelsson wrote: I'm pretty sure it has worked at some point because I wrote that dSYM logic and must have tested it locally at least, but it does seem weird. Sorry, I expressed myself a bit to sweeping there. Yes, obviously it has worked at some point, when you wrote

Re: RFR: JDK-8191820 run-test jtreg test selection and component calculation broken since consolidation

2017-11-24 Thread Magnus Ihse Bursie
On 2017-11-23 17:17, Erik Joelsson wrote: Looks good, except for the indentation of the value for $1_COMPONENT. Oops. Fixed. It's really a shame that you can't add comments inside the big blocks of functional logic. It sure would help in understanding what each sub block was trying to achieve.