RE: JDK-8080990: libdt_socket/socket_md.c(202) : warning C4996: 'gethostbyname': Use getaddrinfo() or GetAddrInfoW()

Hi Gary, ok, I would agree that a change like globally moving from dbgSysInetAddr to something like dbgsysPToN should at least be handled by a different change. Best regards Christoph From: Gary Adams [mailto:gary.ad...@oracle.com] Sent: Montag, 5. Februar 2018 20:15 To: gary.ad...@oracle.com C

Re: RFR: 8173401: Update VERSION_FEATURE for JDK 11

Thanks Joe! David On 6/02/2018 11:32 AM, Joseph D. Darcy wrote: Ship it :-) -Joe On 2/5/2018 5:25 PM, David Holmes wrote: It's time to increment the actual version to 11 for JDK 11. Joe Darcy and I have worked through numerous test issues that delayed the update and I've been addressing a

Re: RFR: 8173401: Update VERSION_FEATURE for JDK 11

Thanks Mandy! David On 6/02/2018 11:46 AM, mandy chung wrote: +1 Mandy On 2/5/18 5:25 PM, David Holmes wrote: It's time to increment the actual version to 11 for JDK 11. Joe Darcy and I have worked through numerous test issues that delayed the update and I've been addressing a number of is

Re: RFR: 8173401: Update VERSION_FEATURE for JDK 11

+1 Mandy On 2/5/18 5:25 PM, David Holmes wrote: It's time to increment the actual version to 11 for JDK 11. Joe Darcy and I have worked through numerous test issues that delayed the update and I've been addressing a number of issues in hotspot related to obsolete/expired flag warnings. I hav

Re: "no tests selected" running tests in the test/jdk directory

OK, I did some reading up in doc/testing.md. I noticed TEST_MODE The test mode (`-agentvm`, `-samevm` or `-othervm`). but TEST_MODE=-agentvm is rejected - it must be TEST_MODE=agentvm. I suggest removing the dashes in the doc and perhaps changing the code to accept and ignore initial dashe

Re: RFR: 8173401: Update VERSION_FEATURE for JDK 11

Ship it :-) -Joe On 2/5/2018 5:25 PM, David Holmes wrote: It's time to increment the actual version to 11 for JDK 11. Joe Darcy and I have worked through numerous test issues that delayed the update and I've been addressing a number of issues in hotspot related to obsolete/expired flag warni

RFR: 8173401: Update VERSION_FEATURE for JDK 11

It's time to increment the actual version to 11 for JDK 11. Joe Darcy and I have worked through numerous test issues that delayed the update and I've been addressing a number of issues in hotspot related to obsolete/expired flag warnings. I have tested the update with JDK tiers 1-3, and hotspo

Re: RFR: JDK-8196803: Fix build warnings in jdk libraries with Xcode 9

Erik: Webrev: http://cr.openjdk.java.net/~erikj/8196803/webrev.01/index.html Bug: https://bugs.openjdk.java.net/browse/JDK-8196803 Looks good. /Tim

RFR: JDK-8196803: Fix build warnings in jdk libraries with Xcode 9

When building with Xcode 9, we get some warnings triggered in jdk libraries. This patch tries to fix them. See bug description for more details on each of them. In short the following things are addressed: In src/java.desktop/macosx/native/libosxapp/NSApplicationAWT.m, remove the check on MAC_

Re: The generated-configure.sh script is dead, long live autoconf!

Hello, In that change I bumped the number from 2.61 to 2.67. The original 2.61 was put there by Fredrik very early in the build-infra conversion and I don't know where that came from. The main reason for us to pick just one version was because we wanted to avoid large differences in the commi

Re: "no tests selected" running tests in the test/jdk directory

Ahh, I had forgotten we are in the middle of a transition to "run-test". I need to read doc/testing.md. On Mon, Feb 5, 2018 at 11:22 AM, Magnus Ihse Bursie < magnus.ihse.bur...@oracle.com> wrote: > Use make run-test TEST="test/jdk" instead. > > /Magnus > > > 5 feb. 2018 kl. 19:39 skrev Martin Buc

Re: The generated-configure.sh script is dead, long live autoconf!

On 2018-02-05 21:05, Magnus Ihse Bursie wrote: Let's move this discussion to build-dev instead of jdk-dev. On 2018-02-05 17:30, Thomas Stüfe wrote: Hi Magnus, On Mon, Feb 5, 2018 at 9:21 AM, Magnus Ihse Bursie > wrote:     With the new solution, the ex

Re: The generated-configure.sh script is dead, long live autoconf!

Let's move this discussion to build-dev instead of jdk-dev. On 2018-02-05 17:30, Thomas Stüfe wrote: Hi Magnus, On Mon, Feb 5, 2018 at 9:21 AM, Magnus Ihse Bursie mailto:magnus.ihse.bur...@oracle.com>> wrote: With the new solution, the exact version of autoconf does not matter.

Re: "no tests selected" running tests in the test/jdk directory

Use make run-test TEST="test/jdk" instead. /Magnus > 5 feb. 2018 kl. 19:39 skrev Martin Buchholz : > > if I > cd test/jdk && make all ... > I get > > Test results: no tests selected > ... > Summary: jdk_default > TEST STATS: name=jdk_default run=0 pass=0 fail=0 > > --- > > Also I find I h

Re: JDK-8080990: libdt_socket/socket_md.c(202) : warning C4996: 'gethostbyname': Use getaddrinfo() or GetAddrInfoW()

One more to fix to cover the remaining test failures I was seeing. Previously, using inet_addr, there was a single -1 return that needed to be checked. Now that we're using inet_pton, there is a -1 and a 0 error return to be considered. My preference would be to leave the dbgSysInetAddr name

"no tests selected" running tests in the test/jdk directory

if I cd test/jdk && make all ... I get Test results: no tests selected ... Summary: jdk_default TEST STATS: name=jdk_default run=0 pass=0 fail=0 --- Also I find I have to define PRODUCT_HOME and JT_HOME as environment variables - make variables are insufficient