Re: RFR: JDK-8196895: Create devkit for Macosx with Xcode 9.2

Erik: On 2018-02-06 11:42, Magnus Ihse Bursie wrote: On 2018-02-06 20:30, Erik Joelsson wrote: This script documents how we at Oracle intends to create the new devkit for building on Macosx, once we change the toolchains used for JDK 11. Since we haven't bumped the toolchains yet, I'm adding a

Re: RFR: 8173401: Update VERSION_FEATURE for JDK 11

Thanks Erik. Pushing now. David On 7/02/2018 3:24 AM, Erik Joelsson wrote: Looks good! /Erik On 2018-02-05 17:25, David Holmes wrote: It's time to increment the actual version to 11 for JDK 11. Joe Darcy and I have worked through numerous test issues that delayed the update and I've

Re: RFR: JDK-8196911: Windows build fails with not finding zlib.h

Erik: A small typo managed to sneak itself into my previous patch, causing the build to fail on Windows. Bug: https://bugs.openjdk.java.net/browse/JDK-8196911 [...snip...] - if test "x$USER_EXTERNAL_LIBZ" = "xfalse"; then + if test "x$USE_EXTERNAL_LIBZ" = "xfalse"; then Looks good. I

RFR: JDK-8196911: Windows build fails with not finding zlib.h

A small typo managed to sneak itself into my previous patch, causing the build to fail on Windows. Bug: https://bugs.openjdk.java.net/browse/JDK-8196911 Patch inline: diff -r 0b1138ce244f make/autoconf/lib-bundled.m4 --- a/make/autoconf/lib-bundled.m4  Tue Feb 06 10:17:31 2018 -0800 +++

Re: RFR: JDK-8196803: Fix build warnings in jdk libraries with Xcode 9

Hello, The 9 was just me being sloppy and thinking 9.x, I'm actually using 9.2. These are all the warnings I found in JDK libraries. There are additional ones in other parts of the build which have been dealt with in separate issues. /Erik On 2018-02-06 12:54, Sergey Bylokhov wrote: Hi,

Re: RFR: JDK-8196803: Fix build warnings in jdk libraries with Xcode 9

Hi, Erik. Why XCode 9 was selected? It seems that 9.2 is the latest one. 9.2 produces some additional warnings even after this fix. On 05/02/2018 14:54, Erik Joelsson wrote: When building with Xcode 9, we get some warnings triggered in jdk libraries. This patch tries to fix them. See bug

Re: RFR: JDK-8196895: Create devkit for Macosx with Xcode 9.2

On 2018-02-06 11:42, Magnus Ihse Bursie wrote: On 2018-02-06 20:30, Erik Joelsson wrote: This script documents how we at Oracle intends to create the new devkit for building on Macosx, once we change the toolchains used for JDK 11. Since we haven't bumped the toolchains yet, I'm adding a new

Re: RFR: JDK-8196895: Create devkit for Macosx with Xcode 9.2

On 2018-02-06 20:30, Erik Joelsson wrote: This script documents how we at Oracle intends to create the new devkit for building on Macosx, once we change the toolchains used for JDK 11. Since we haven't bumped the toolchains yet, I'm adding a new script instead of replacing the existing one.

RFR: JDK-8196895: Create devkit for Macosx with Xcode 9.2

This script documents how we at Oracle intends to create the new devkit for building on Macosx, once we change the toolchains used for JDK 11. Since we haven't bumped the toolchains yet, I'm adding a new script instead of replacing the existing one. I'm also renaming the old one to match the

Re: The generated-configure.sh script is dead - autoconf seems to write into the sources in the build process

On 2018-02-06 19:01, Volker Simonis wrote: On Tue, Feb 6, 2018 at 6:28 PM, Magnus Ihse Bursie wrote: On 2018-02-06 15:53, Volker Simonis wrote: Hi, as Matthias wrote, we're usually running configure from a newly created build directory which is outside the

Re: RFR: JDK-8196879: Forgot to add file in JDK-8196803

On 02/06/18 10:16, Erik Joelsson wrote: When pushing JDK-8196803 just now, I forgot to add the zlib.h file. Please review this correction. Bug: https://bugs.openjdk.java.net/browse/JDK-8196879 Webrev: http://cr.openjdk.java.net/~erikj/8196879/webrev.01/ Looks good. /Tim

RFR: JDK-8196879: Forgot to add file in JDK-8196803

When pushing JDK-8196803 just now, I forgot to add the zlib.h file. Please review this correction. Bug: https://bugs.openjdk.java.net/browse/JDK-8196879 Webrev: http://cr.openjdk.java.net/~erikj/8196879/webrev.01/ /Erik

Re: The generated-configure.sh script is dead - autoconf seems to write into the sources in the build process

On Tue, Feb 6, 2018 at 6:28 PM, Magnus Ihse Bursie wrote: > > > On 2018-02-06 15:53, Volker Simonis wrote: >> >> Hi, >> >> as Matthias wrote, we're usually running configure from a newly >> created build directory which is outside the source tree. Also, the >> build

Re: "no tests selected" running tests in the test/jdk directory

On 2018-02-06 02:39, Martin Buchholz wrote: OK, I did some reading up in doc/testing.md . I noticed TEST_MODE The test mode (`-agentvm`, `-samevm` or `-othervm`). but TEST_MODE=-agentvm is rejected - it must be TEST_MODE=agentvm. I suggest removing the dashes in the

Re: RFR: JDK-8196803: Fix build warnings in jdk libraries with Xcode 9

On 2018-02-05 23:54, Erik Joelsson wrote: When building with Xcode 9, we get some warnings triggered in jdk libraries. This patch tries to fix them. See bug description for more details on each of them. In short the following things are addressed: In

Re: The generated-configure.sh script is dead - autoconf seems to write into the sources in the build process

On 2018-02-06 18:22, Erik Joelsson wrote: Hello Volker, I think this is a reasonable idea, but have opinions on the implementation. I think this should apply even if you have a CUSTOM_ROOT defined. Thinking some more on this, isn't it always true that you want it in $PWD/.build? Or if we

Re: The generated-configure.sh script is dead - autoconf seems to write into the sources in the build process

On 2018-02-06 15:53, Volker Simonis wrote: Hi, as Matthias wrote, we're usually running configure from a newly created build directory which is outside the source tree. Also, the build user who calls configure may differ from the user owning the source tree. I'd therefor like to propose the

Re: The generated-configure.sh script is dead - autoconf seems to write into the sources in the build process

Hello Volker, I think this is a reasonable idea, but have opinions on the implementation. I think this should apply even if you have a CUSTOM_ROOT defined. Thinking some more on this, isn't it always true that you want it in $PWD/.build? Or if we want to get really strict about it, if PWD is

Re: RFR: 8173401: Update VERSION_FEATURE for JDK 11

Looks good! /Erik On 2018-02-05 17:25, David Holmes wrote: It's time to increment the actual version to 11 for JDK 11. Joe Darcy and I have worked through numerous test issues that delayed the update and I've been addressing a number of issues in hotspot related to obsolete/expired flag

Re: The generated-configure.sh script is dead, long live autoconf!

On Tue, Feb 6, 2018 at 10:36 AM, dalibor topic wrote: > On 06.02.2018 09:51, Thomas Stüfe wrote: > >> You are right, maybe adapting to autoconf 2.69 is the cleaner way to go >> instead of trying to make the builds run with an older autoconf. >> > It most likely is. > >

Re: "no tests selected" running tests in the test/jdk directory

.. and samevm mode no longer exists. -- Jon On 2/5/18 5:39 PM, Martin Buchholz wrote: OK, I did some reading up in doc/testing.md. I noticed TEST_MODE The test mode (`-agentvm`, `-samevm` or `-othervm`). but TEST_MODE=-agentvm is rejected - it must be TEST_MODE=agentvm. I suggest

Re: The generated-configure.sh script is dead - autoconf seems to write into the sources in the build process

Hi, as Matthias wrote, we're usually running configure from a newly created build directory which is outside the source tree. Also, the build user who calls configure may differ from the user owning the source tree. I'd therefor like to propose the following small change which checks from where

The generated-configure.sh script is dead - autoconf seems to write into the sources in the build process

Hello I noticed that after replacing generated-configure.sh and using autoconf ,the build process writes into the sources . Error looks like this : Runnable configure script is not present Generating runnable configure script mkdir: cannot create directory

Re: The generated-configure.sh script is dead, long live autoconf!

On 06.02.2018 09:51, Thomas Stüfe wrote: You are right, maybe adapting to autoconf 2.69 is the cleaner way to go instead of trying to make the builds run with an older autoconf. It most likely is. The older the autoconf is that one requires, the more problematic using the OS provided one

Re: The generated-configure.sh script is dead, long live autoconf!

Hi, On Mon, Feb 5, 2018 at 11:14 PM, Erik Joelsson wrote: > Hello, > > In that change I bumped the number from 2.61 to 2.67. The original 2.61 > was put there by Fredrik very early in the build-infra conversion and I > don't know where that came from. The main reason