Re: RFR: JDK-8196356: Changes to m4 files don't trigger autoconf execution at build time

2018-02-10 Thread Martin Buchholz
I agree. Once you make something lazy-initted you have a concurrency problem. And there's no CAS or lock on the filesystem. What happens if two configure processes run at exactly the same time, perhaps even with different versions of autoconf? If you lazy-generate configure, it must be written

Re: RFR: JDK-8196356: Changes to m4 files don't trigger autoconf execution at build time

2018-02-10 Thread Thomas Stüfe
On Sat, Feb 10, 2018 at 9:12 AM, Alan Bateman wrote: > On 08/02/2018 17:49, Erik Joelsson wrote: > >> The check for when to generate the generated configure script is not >> working quite as expected. It currently only compares timestamps if the >> local repository has

Re: RFR: JDK-8196356: Changes to m4 files don't trigger autoconf execution at build time

2018-02-10 Thread Alan Bateman
On 08/02/2018 17:49, Erik Joelsson wrote: The check for when to generate the generated configure script is not working quite as expected. It currently only compares timestamps if the local repository has any local changes in the make/autoconf directory. This used to make sense when we had a