Re: JDK10 build problem: "--module-path"?

2018-02-15 Thread Ted Neward
The temptation to do a “Well, actually…” here is strong. ;-) Seriously, thanks for taking my incredulity in the spirit it was intended. :-) Is it becoming more common for Java tools to accept different “styles” of arguments, or did this become a complete switch/rename? (You can tell how much

Re: JDK10 build problem: "--module-path"?

2018-02-15 Thread Ted Neward
So… Hmm. Anybody here know what the blessed way to get OpenJDK9 into a Docker image would be, then? Ted Neward Author, Speaker, Mentor http://www.newardassociates.com t: @tedneward | m: (425) 647-4526 From: Martin Buchholz Date: Thursday, February 15, 2018 at 8:50 AM

Re: RFR: JDK-8198227 Fix COMPARE_BUILD after forest consolidation

2018-02-15 Thread Tim Bell
Magnus: Looks good to me as well. Tim On 02/15/18 07:40, Erik Joelsson wrote: Looks good. /Erik On 2018-02-15 06:14, Magnus Ihse Bursie wrote: The new repo structure with the forest consolidation broke the COMPARE_BUILD functionality when using a closed repo. Bug:

Re: RFR(S): 8197906: Enable CDS mode execution of jtreg tests via make

2018-02-15 Thread Mikhailo Seledtsov
Hi Igor, Thank you very much for catching this, and for the explanation. I have updated the patch and running tests now. I assume the recommended update is small/trivial enough that it does not need another webrev; let me know otherwise. Thank you, Misha On 2/14/18, 9:00 AM, Igor Ignatyev

Re: RFR(S): 8197906: Enable CDS mode execution of jtreg tests via make

2018-02-15 Thread Mikhailo Seledtsov
Hi Magnus, Thank you for review and feedback. I will update my change based on your recommendation, the retest. If tests pass, I am planning to push. Thank you, Misha On 2/14/18, 12:04 PM, Magnus Ihse Bursie wrote: On 2018-02-14 16:26, Mikhailo Seledtsov wrote: Hi Igor, Thank you for

Re: Choosing which Visual Studio installation to use

2018-02-15 Thread Thomas Stüfe
Hi Erik, On Thu, Feb 15, 2018 at 4:22 PM, Erik Joelsson wrote: > Hello Thomas, > > If you have multiple versions installed, configure will pick the one to > use in order of most supported. To explicitly pick one, you can use > --with-toolchain-version=2010 (or some

Re: JDK10 build problem: "--module-path"?

2018-02-15 Thread Martin Buchholz
Looking at https://packages.ubuntu.com/search?suite=all=all=any=openjdk-9-jdk=names it seems like Ubuntu ships whatever openjdk-9 is available at time of creation of a specific version, and doesn't update it afterwards, not even for the quarterly security patches. On Thu, Feb 15, 2018 at 7:42 AM,

Re: JDK10 build problem: "--module-path"?

2018-02-15 Thread Erik Joelsson
I have hit this same problem once for the same reason Alan describes. Ubuntu provided me with a really old EA build of 9. /Erik On 2018-02-15 00:05, Alan Bateman wrote: On 15/02/2018 06:32, Ted Neward wrote: Really?!? I thought the javac -help only listed -modulepath. Not to disbelieve

Re: RFR: JDK-8198227 Fix COMPARE_BUILD after forest consolidation

2018-02-15 Thread Erik Joelsson
Looks good. /Erik On 2018-02-15 06:14, Magnus Ihse Bursie wrote: The new repo structure with the forest consolidation broke the COMPARE_BUILD functionality when using a closed repo. Bug: https://bugs.openjdk.java.net/browse/JDK-8198227 WebRev:

Re: macOS High Sierra, version 10.13.2 configure: error: Couldnotfind freetype! You might be able to fix this by running 'brewinstallfreetype'

2018-02-15 Thread Erik Joelsson
You could hack configure to disable that check and try a slightly newer xcode. Maybe 5.x or 6.x works well enough. It's likely that you then also need to add --disable-warnings-as-errors to configure. You could also try installing an older Macos as a virtual machine on your current mac. Note

Re: Choosing which Visual Studio installation to use

2018-02-15 Thread Erik Joelsson
Hello, Just want to clear some things up around this. We use Cygwin just as a unix emulation layer for running typical unix tools. OpenJDK can only be built on Windows using Visual Studio as the compiler toolchain. We currently don't support any other unix emulation layer. We have had

Re: JDK10 build problem: "--module-path"?

2018-02-15 Thread Jonathan Gibbons
Ted, Yes, I'm sure :-) This is the relevant line from the source code for JDK 9, listing --module-path and -p as alternatives for this option. MODULE_PATH("--module-path -p", "opt.arg.path", "opt.modulepath", STANDARD, FILEMANAGER),

Re: Choosing which Visual Studio installation to use

2018-02-15 Thread Erik Joelsson
Hello Thomas, If you have multiple versions installed, configure will pick the one to use in order of most supported. To explicitly pick one, you can use --with-toolchain-version=2010 (or some other number) and configure will look for that specific version of Visual Studio. Just pointing to

Re: RFR(xs): 8193909: Obsolete(remove) Co-operative Memory Management (CMM)

2018-02-15 Thread sangheon.kim
Hi Thomas, On 02/15/2018 03:32 AM, Thomas Schatzl wrote: Hi, On Wed, 2018-02-14 at 13:45 -0800, sangheon.kim wrote: Hi all, Could I have some reviews for CMM removal? This is closed CR but some public codes also need small modifications. This CR is for removing stuff related to an Oracle JDK

RFR: JDK-8198227 Fix COMPARE_BUILD after forest consolidation

2018-02-15 Thread Magnus Ihse Bursie
The new repo structure with the forest consolidation broke the COMPARE_BUILD functionality when using a closed repo. Bug: https://bugs.openjdk.java.net/browse/JDK-8198227 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8198227-fix-COMPARE_BUILD-in-CLOSED_ROOT/webrev.01

[PATCH] Add post custom extension hooks to two launchers

2018-02-15 Thread Ben Walsh
This patch simply adds a hook to two launchers to call a post custom extension if it is available. I would like to pair with a sponsor to contribute this patch ... diff -r 85c27aabf312

Re: RFR(xs): 8193909: Obsolete(remove) Co-operative Memory Management (CMM)

2018-02-15 Thread Thomas Schatzl
Hi, On Wed, 2018-02-14 at 13:45 -0800, sangheon.kim wrote: > Hi all, > > Could I have some reviews for CMM removal? > This is closed CR but some public codes also need small > modifications. > This CR is for removing stuff related to an Oracle JDK > module/package. > Changes are just removing

Re: JDK10 build problem: "--module-path"?

2018-02-15 Thread Alan Bateman
On 15/02/2018 06:32, Ted Neward wrote: Really?!? I thought the javac -help only listed -modulepath. Not to disbelieve you *grin*, but are you sure? The reason I ask is (barring some really bizarre misconfiguration) I should be using the OpenJDK9 as the boot JDK for this, and I'm getting the