RFR(S): 8196992: Resolve disabled warnings for libdt_socket

2018-02-22 Thread Chris Plummer
Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8196992 diff --git a/make/lib/Lib-jdk.jdwp.agent.gmk b/make/lib/Lib-jdk.jdwp.agent.gmk --- a/make/lib/Lib-jdk.jdwp.agent.gmk +++ b/make/lib/Lib-jdk.jdwp.agent.gmk @@ -43,7 +43,6 @@ OPTIMIZATION := LOW, \ CF

Re: RFR: JDK-8198569: SetupTextFileProcessing should use sed with 'g'

2018-02-22 Thread Tim Bell
Erik: I'm currently trying to use SetupTextFileProcessing with a file where the same replacement string appears twice on the same row. This doesn't work. To fix it, I would like to add /g on the sed replacement expressions. Webrev: http://cr.openjdk.java.net/~erikj/8198569/webrev.01/ Bug: http

RFR: JDK-8198569: SetupTextFileProcessing should use sed with 'g'

2018-02-22 Thread Erik Joelsson
I'm currently trying to use SetupTextFileProcessing with a file where the same replacement string appears twice on the same row. This doesn't work. To fix it, I would like to add /g on the sed replacement expressions. Webrev: http://cr.openjdk.java.net/~erikj/8198569/webrev.01/ Bug: https://bu

Re: RFR: JDK-8198243: Add build time check for global operator new/delete in object files

2018-02-22 Thread John Rose
On Feb 22, 2018, at 11:41 AM, Erik Joelsson wrote: > > We could grep for the mangled strings for the operators instead, which is > super fast. Problem is just figuring out all the possible combinations. Idea: Do a config-style move where you compile a test file of C++ code, strip out all the n

Re: RFR: JDK-8198243: Add build time check for global operator new/delete in object files

2018-02-22 Thread Erik Joelsson
On 2018-02-21 21:06, David Holmes wrote: On 22/02/2018 4:07 AM, Erik Joelsson wrote: Hello, On 2018-02-20 21:33, David Holmes wrote: a) how much time it adds to the build? I have not done extensive testing, but on my Linux workstation with 32 hw threads, building just hotspot release bui