Re: [NEW BUG]: Configure broken on MIPS

On Fri, Mar 23, 2018 at 6:22 AM, David Holmes wrote: > Hi Thomas, > > On 23/03/2018 2:55 PM, Thomas Stüfe wrote: > >> Hi David, >> >> would it not be pragmatic to accept Ao's patch - it looks fine to me - >> since it certainly would not make matters worse. And let Magnus follow up >> with a clean

Re: [NEW BUG]: Configure broken on MIPS

Hi Thomas, On 23/03/2018 2:55 PM, Thomas Stüfe wrote: Hi David, would it not be pragmatic to accept Ao's patch - it looks fine to me - since it certainly would not make matters worse. And let Magnus follow up with a cleanup change later? Well I hope Magnus's change is forthcoming. AFAICS it

Re: [NEW BUG]: Configure broken on MIPS

Hi David, would it not be pragmatic to accept Ao's patch - it looks fine to me - since it certainly would not make matters worse. And let Magnus follow up with a cleanup change later? Best Regards, Thomas On Fri, Mar 23, 2018 at 2:37 AM, David Holmes wrote: > On 23/03/2018 11:33 AM, Ao Qi wrot

Re: [NEW BUG]: Configure broken on MIPS

On 23/03/2018 11:33 AM, Ao Qi wrote: So what should be the next? Is that another problem, or should the MIPS broken configure be fixed together? There should be one proper fix to cover all affected platforms. David 2018-03-23 5:04 GMT+08:00 David Holmes : On 23/03/2018 12:13 AM, Erik Joelss

Re: [NEW BUG]: Configure broken on MIPS

So what should be the next? Is that another problem, or should the MIPS broken configure be fixed together? 2018-03-23 5:04 GMT+08:00 David Holmes : > On 23/03/2018 12:13 AM, Erik Joelsson wrote: >> >> Hello, >> >> The fix looks correct, but I'm starting to think that maybe the >> conditional shou

Re: [NEW BUG]: Configure broken on MIPS

On 23/03/2018 12:13 AM, Erik Joelsson wrote: Hello, The fix looks correct, but I'm starting to think that maybe the conditional should be inverted and instead list the architectures that actually use -m64? It seems a whole lot of them don't. Magnus indicated he was working on a better soluti

Re: [OpenJDK 2D-Dev] RFR: JDK-8071469 Cleanup include and exclude of sound native libraries after source code restructure

Hi Magnus, the fix looks good to me. --alex On 03/22/2018 00:41, Magnus Ihse Bursie wrote: On 2018-03-21 19:08, Alex Menkov wrote: Hi Magnus, > I have tested the following: >   * On my linux machine, failure to load libjsound.so was not fatal. In Platform.java:   54 loadLibraries();

Re: [11] RFR(XS) 8199896: [Graal] build Graal on all x86 platforms

Thank you, Erik Vladimir On 3/22/18 7:07 AM, Erik Joelsson wrote: Looks good. /Erik On 2018-03-21 18:04, Vladimir Kozlov wrote: Forgot to CC to build-dev. Note, this change does not have effect unless you disable AOT build. We are already building Graal on all x64 platforms as part of AOT

Re: RFR: JDK-8200083: Bump bootjdk requirement for JDK 11 to JDK 10

Magnus, There has always been a desire that most of JDK is free to use the latest language and API features, meaning we must use the latest javac to compile most most of JDK.   That is where the "interim javac" comes in. The interim JDK relies on javac and related tools being compilable by t

Re: RFR: JDK-8200083: Bump bootjdk requirement for JDK 11 to JDK 10

Hello, On 2018-03-21 15:07, Martin Buchholz wrote: Now that we are releasing jdks an order of magnitude faster than before, we should reconsider the N-1 boot jdk policy. The primary beneficiaries of this are compiler-dev, who might like to code using the very features they are implementing.

Re: RFR: JDK-8200083: Bump bootjdk requirement for JDK 11 to JDK 10

On 2018-03-21 23:10, Magnus Ihse Bursie wrote: Jon, 21 mars 2018 kl. 23:20 skrev Jonathan Gibbons : Holding javac and related tools back to the latest LTS would indeed be somewhat onerous. Can we use the interim JDK build to get around this? Something like, if we can build a interim JDK wi

Re: [NEW BUG]: Configure broken on MIPS

Hello, The fix looks correct, but I'm starting to think that maybe the conditional should be inverted and instead list the architectures that actually use -m64? It seems a whole lot of them don't. /Erik On 2018-03-21 23:24, Ao Qi wrote: Hi, I found configure of http://hg.openjdk.java.net/

Re: RFR: 8199705: Docs.gmk needs to be updated to remove the -html5 option

Looks good. /Erik On 2018-03-21 21:36, Bhavesh Patel wrote: Hi,     This is a simple fix to Docs.gmk. A fix for JDK-8182765 was pushed recently to javadoc enabling it to generate HTML 5 output by default. This makes the "-html5" option, de

Re: [11] RFR(XS) 8199896: [Graal] build Graal on all x86 platforms

Looks good. /Erik On 2018-03-21 18:04, Vladimir Kozlov wrote: Forgot to CC to build-dev. Note, this change does not have effect unless you disable AOT build. We are already building Graal on all x64 platforms as part of AOT build currently. Vladimir On 3/20/18 6:15 PM, Vladimir Kozlov wr

Re: RFR: JDK-8198652: Stop linking with -base:0x8000000 on Windows

On 2018-03-21 23:05, Erik Joelsson wrote: On Windows, we have been linking libjvm.so with -base:0x800 since forever. This may have been a good idea on earlier versions of windows, but with VS2017 it generates a warning and with ASLR, the address a given binary is loaded at will vary between

Re: RFR: JDK-8198652: Stop linking with -base:0x8000000 on Windows

Hi Erik, makes sense and looks fine. ..Thomas On Wed, Mar 21, 2018 at 11:05 PM, Erik Joelsson wrote: > On Windows, we have been linking libjvm.so with -base:0x800 since > forever. This may have been a good idea on earlier versions of windows, but > with VS2017 it generates a warning and wi

Re: [OpenJDK 2D-Dev] RFR: JDK-8071469 Cleanup include and exclude of sound native libraries after source code restructure

On 2018-03-21 19:08, Alex Menkov wrote: Hi Magnus, > I have tested the following: >   * On my linux machine, failure to load libjsound.so was not fatal. In Platform.java:   54 loadLibraries();   55 readProperties(); and readProperties calls native nIsBigEndian if libjsound loa

Re: RFR: JDK-8200083: Bump bootjdk requirement for JDK 11 to JDK 10

On Thu, Mar 22, 2018 at 7:37 AM, Ao Qi wrote: > 2018-03-22 6:41 GMT+08:00 John Paul Adrian Glaubitz > : > > On 03/22/2018 07:07 AM, Martin Buchholz wrote: > >> But for users, being able to bootstrap with an ancient jdk is definitely > >> convenient. > > > > Convenient is an understatement. Always