Re: RFR: JDK-8201439: Enable linux-arm-vfp-hflt profile to be configured with jib again

Erik: While not actively maintaining the arm port, it would be nice to at least be able to build it inside Oracle. I discovered that with just a minor tweak to the jib configuration, I could get configure to work again. Webrev: http://cr.openjdk.java.net/~erikj/8201439/webrev.01/ Bug:

Re: RFR: 8196516: libfontmanager must be built with LDFLAGS allowing unresolved symbols

Yes, I think this should be removed for AIX as we have done for Solaris + Linux, and I could have done that but I also had no way to test it .. without that capability I ran more risk of breaking AIX than fixing a problem that apparently hasn't been seen there. I am not sure if *headful* tests

[8u] RFR: 8035495: Improvements in autoconf integration AND 8035825

Hi, I'd like to request review of this backport from 9 to 8u: 8035495: Improvements in autoconf integration JBS: https://bugs.openjdk.java.net/browse/JDK-8035495 9 changeset: URL: http://hg.openjdk.java.net/jdk9/dev/rev/6e29cd9ac2b4 User: ihse Date: 2014-02-24 12:31:07 + 9 review

RFR: JDK-8201439: Enable linux-arm-vfp-hflt profile to be configured with jib again

While not actively maintaining the arm port, it would be nice to at least be able to build it inside Oracle. I discovered that with just a minor tweak to the jib configuration, I could get configure to work again. Webrev: http://cr.openjdk.java.net/~erikj/8201439/webrev.01/ Bug:

Re: 8201226 missing JNIEXPORT / JNICALL at some places in function declarations/implementations - was : RE: missing JNIEXPORT / JNICALL at some places in function declarations/implementations

On 11/04/2018 11:38, Magnus Ihse Bursie wrote: 11 apr. 2018 kl. 11:10 skrev Alexey Ivanov : On 11/04/2018 08:44, Baesken, Matthias wrote: JIMAGE_FindResource doesn't have JNICALL modifier now, does it? Hi Alexey, yes that's true . Please remove JNIEXPORT from

Re: 8201226 missing JNIEXPORT / JNICALL at some places in function declarations/implementations - was : RE: missing JNIEXPORT / JNICALL at some places in function declarations/implementations

I guess we also need to get an approval from core-libs (cc'd) as libzip and libjimage are modified. Regards, Alexey On 11/04/2018 10:56, Alexey Ivanov wrote: The change looks good to me. On 11/04/2018 10:20, Baesken, Matthias wrote: Was main() exported via map files? Seems main was

Re: 8201226 missing JNIEXPORT / JNICALL at some places in function declarations/implementations - was : RE: missing JNIEXPORT / JNICALL at some places in function declarations/implementations

The change looks good to me. On 11/04/2018 10:20, Baesken, Matthias wrote: Was main() exported via map files? Seems main was exported , I can find it in jdk10 in e.g. : make/mapfiles/launchers/mapfile-sparcv9 make/mapfiles/launchers/mapfile-x86_64 Thank you for confirming it. Then

RE: JDK 11 hotspot build fails with "Undefined symbol" on AIX

Hi Bhaktavatsal, As per [1], the jdk-hs repo will be closed tomorrow and finally merged with jdk. After that, only the jdk depot will continue to be active and you should not run into such type of inconsistencies any longer... Best regards Christoph [1]

Re: RFR: 8196516: libfontmanager must be built with LDFLAGS allowing unresolved symbols

Hi Magnus, On Tue, 2018-04-10 at 22:57 +0200, Magnus Ihse Bursie wrote: > On 2018-04-10 13:25, Severin Gehwolf wrote: > > Hi Erik, > > > > On Mon, 2018-04-09 at 09:20 -0700, Erik Joelsson wrote: > > > Hello Severin, > > > > > > I'm ok with this solution for now. > > > > Thanks for the review!

Re: RFR: 8196516: libfontmanager must be built with LDFLAGS allowing unresolved symbols

On Tue, 2018-04-10 at 09:34 -0700, Erik Joelsson wrote: > Looks good. Thanks! Thanks, Erik. Cheers, Severin > /Erik > > > On 2018-04-10 04:25, Severin Gehwolf wrote: > > Hi Erik, > > > > On Mon, 2018-04-09 at 09:20 -0700, Erik Joelsson wrote: > > > Hello Severin, > > > > > > I'm ok with

RE: 8201226 missing JNIEXPORT / JNICALL at some places in function declarations/implementations - was : RE: missing JNIEXPORT / JNICALL at some places in function declarations/implementations

> > Was main() exported via map files? > Seems main was exported , I can find it in jdk10 in e.g. : make/mapfiles/launchers/mapfile-sparcv9 make/mapfiles/launchers/mapfile-x86_64 Best regards, Matthias > -Original Message- > From: Alexey Ivanov [mailto:alexey.iva...@oracle.com] >

Re: 8201226 missing JNIEXPORT / JNICALL at some places in function declarations/implementations - was : RE: missing JNIEXPORT / JNICALL at some places in function declarations/implementations

On 11/04/2018 08:44, Baesken, Matthias wrote: JIMAGE_FindResource doesn't have JNICALL modifier now, does it? Hi Alexey, yes that's true . Please remove JNIEXPORT from main(): src/java.base/share/native/launcher/main.c src/jdk.pack/share/native/unpack200/main.cpp I would prefer to keep it

Re: RFR: 8196516: libfontmanager must be built with LDFLAGS allowing unresolved symbols

On Tue, 2018-04-10 at 14:51 -0700, Sergey Bylokhov wrote: > LIBS_aix := -lawt_headless, > I guess that AIX team should have a similar fix. Possibly. I have no way of testing it, though. So will leave it to AIX folk to have a look. My experience was that it isn't easily reproducible. Some

RE: 8201226 missing JNIEXPORT / JNICALL at some places in function declarations/implementations - was : RE: missing JNIEXPORT / JNICALL at some places in function declarations/implementations

> > JIMAGE_FindResource doesn't have JNICALL modifier now, does it? > Hi Alexey, yes that's true . > Please remove JNIEXPORT from main(): > src/java.base/share/native/launcher/main.c > src/jdk.pack/share/native/unpack200/main.cpp I would prefer to keep it for now . I notice some comments