> On Apr 27, 2018, at 2:11 AM, David Holmes wrote:
>
> On 27/04/2018 3:32 PM, Kim Barrett wrote:
>>> On Apr 26, 2018, at 6:49 PM, gary.ad...@oracle.com wrote:
>>>
>>> Adding build-dev and hotspot-runtime-dev aliases.
>>>
>>> Forwarded Message
>>> Subject:RFR: JDK-8202319:
On 27/04/2018 3:32 PM, Kim Barrett wrote:
On Apr 26, 2018, at 6:49 PM, gary.ad...@oracle.com wrote:
Adding build-dev and hotspot-runtime-dev aliases.
Forwarded Message
Subject:RFR: JDK-8202319: Fix compilation warnings in Solaris debug
builds for DevStudio 12.6
Date:
Hi Thomas,
Look at this blog:
https://www.ibm.com/developerworks/aix/library/au-aix-symbol-visibility-part2/index.html
if I understand it correctly, the xlc 12 default behavior should be like what
we'd expect from -qvisibility=hidden.
Best regards
Christoph
> -Original Message-
> Fr
> On Apr 26, 2018, at 6:49 PM, gary.ad...@oracle.com wrote:
>
> Adding build-dev and hotspot-runtime-dev aliases.
>
> Forwarded Message
> Subject: RFR: JDK-8202319: Fix compilation warnings in Solaris debug
> builds for DevStudio 12.6
> Date: Thu, 26 Apr 2018 12:35
Hi,
This was added by "8200178: Remove mapfiles for JDK native libraries".
But if the flag is not accepted, what is the default behavior? Do we
now export everything?
I'd like to understand this first before removing the flag to get rid
of the warnings.
Best Regards, Thomas
On Thu, Apr 26, 2018
> On Apr 25, 2018, at 10:51 AM, Andrew Hughes wrote:
>
> On 24 April 2018 at 20:17, Kim Barrett wrote:
>>> On Apr 23, 2018, at 3:51 AM, Michal Vala wrote:
>>>
>>> Hi,
>>>
>>> following discussion "RFR: build pragma error with gcc 4.4.7"[1], I'm
>>> posting updated patch replacing deprecated
Adding build-dev and hotspot-runtime-dev aliases.
Forwarded Message
Subject: RFR: JDK-8202319: Fix compilation warnings in Solaris debug
builds for DevStudio 12.6
Date: Thu, 26 Apr 2018 12:35:28 -0400
From: Gary Adams
Reply-To: gary.ad...@oracle.com
To: OpenJDK
>
> GraalWithLimitedMetaspace.java depends on UseAppCDS_Test in a similar way but
> it only performs dumping.
Ok, since GraalWithLimitedMetaspace.java still uses UseAppCDS_Test.java, it is
better to keep it for now.
Thanks,
Jiangli
>
> thanks,
> Calvin
>>
>>>>
eport all non-empty
directories in the shared path table entries before exiting VM.
Full webrev:
http://java.se.oracle.com:10065/mdash/jobs/jianzhou-jdk-20180426-0406-20150
I think the correct URL is:
http://cr.openjdk.java.net/~jiangli/8193213_8182731/webrev.02/ ?
Yes.
Thanks!
Jiangli
thanks
a and
UseAppCDS_Test.java?
>> - Removed UseAppCDS in various tests.
>> - Changed to keep the original version of the classlist and renamed to
>> classlist.raw.
>> - Changed check_nonempty_dir_in_shared_path_table() to report all non-empty
>> directories in the shared p
Hi Magnus,
I think I'll just delete the comment. Thanks for the review!
Thanks, Thomas
On Thu, Apr 26, 2018 at 7:26 PM, Magnus Ihse Bursie
wrote:
> Sounds reasonable.
>
> The code look good but the comment "Do not change default value." seems to be
> more of a comment on the removed code, so I
ble entries before exiting VM.
>>
>> Full webrev:
>> http://java.se.oracle.com:10065/mdash/jobs/jianzhou-jdk-20180426-0406-20150
>>
>> Tested all modified tests locally. Rerunning hs-tier1 ~ hs-tier5 tests.
>>
>> Thanks for all the suggestions!
>>
arious tests.
>> - Changed to keep the original version of the classlist and renamed to
>> classlist.raw.
>> - Changed check_nonempty_dir_in_shared_path_table() to report all non-empty
>> directories in the shared path table entries before exiting VM.
>> Full webrev:
Sounds reasonable.
The code look good but the comment "Do not change default value." seems to be
more of a comment on the removed code, so I think it just looks confusing
without adding anything of real value in the resulting code. Maybe rephrase
"default is already set" or so, or just delete?
slist and renamed to
classlist.raw.
- Changed check_nonempty_dir_in_shared_path_table() to report all non-empty
directories in the shared path table entries before exiting VM.
Full webrev:
http://java.se.oracle.com:10065/mdash/jobs/jianzhou-jdk-20180426-0406-20150
I think the correct URL is:
Thank you Goetz!
On Thu, Apr 26, 2018, 16:13 Lindenmaier, Goetz
wrote:
> Hi Thomas,
>
> this looks good and will simplify building on AIX.
>
> Thanks,
> Goetz.
>
> > -Original Message-
> > From: ppc-aix-port-dev [mailto:ppc-aix-port-dev-
> > boun...@openjdk.java.net] On Behalf Of Thoma
Thanks Erik!
On Thu, Apr 26, 2018, 18:09 Erik Joelsson wrote:
> Looks good.
>
> /Erik
>
>
> On 2018-04-26 07:03, Thomas Stüfe wrote:
> > Hi all,
> >
> > may I have reviews please:
> >
> > https://bugs.openjdk.java.net/browse/JDK-8202325
> >
> http://cr.openjdk.java.net/~stuefe/webrevs/8202325-ai
Looks ok.
/Erik
On 2018-04-26 07:13, Baesken, Matthias wrote:
Hello , could you please review this small adjustment to the symbol
visibility compilation settings on AIX ?
Currently we use XLC 12.1 to compile JDK on AIX .
However XLC 12.1 does not support the "-qvisibility=hidden"
Looks good.
/Erik
On 2018-04-26 07:03, Thomas Stüfe wrote:
Hi all,
may I have reviews please:
https://bugs.openjdk.java.net/browse/JDK-8202325
http://cr.openjdk.java.net/~stuefe/webrevs/8202325-aix-disable-warnings-as-errors/webrev.00/webrev/
We decided to disable warnings as errors by defa
Looks reasonable.
/Erik
On 2018-04-26 04:00, Archana Nogriya wrote:
If we have a conditional variable to set
"hotspot-$(JVM_VARIANT_MAIN)-gensrc" target then this can give way to
alternate VMs like eclipse openj9 to extend that to set it appropriately.
diff --git a/make/Main.gmk b/make/Main
-lkstat was also used to determine SPARC CPU features as I remember.
Vladimir
On 4/26/18 9:03 AM, Erik Joelsson wrote:
Should linking to the -lkstat library be conditional on jfr feature
being set, or perhaps it doesn't matter that much. In that case, adding
the library could be done in JvmFea
Should linking to the -lkstat library be conditional on jfr feature
being set, or perhaps it doesn't matter that much. In that case, adding
the library could be done in JvmFeatures.gmk instead.
/Erik
On 2018-04-26 02:45, Magnus Ihse Bursie wrote:
On 2018-04-25 13:06, Erik Gahlin wrote:
Gre
Looks good.
/Erik
On 2018-04-26 01:38, Kevin Walls wrote:
Thanks Erik -
I went ahead with the jdk's make/CopyFiles.gmk change, and added
SetupCopyFiles to the base repo's make/common/MakeBase.gmk.
I updated the webrev, to include base and jdk repos:
http://cr.openjdk.java.net/~kevinw/804
check_nonempty_dir_in_shared_path_table() to report all non-empty
directories in the shared path table entries before exiting VM.
Full webrev:
http://java.se.oracle.com:10065/mdash/jobs/jianzhou-jdk-20180426-0406-20150
Tested all modified tests locally. Rerunning hs-tier1 ~ hs-tier5 tests.
Thanks for all the suggestions
Hi Matthias,
after Bhaktavatsal Reddy's report about the problems with
"-qvisibility" with xlC 13 and taking into account that we can't test
this anyway because we don't currently have xlC 13
on our machines I think it would be best to completely remove this
option for now on AIX. Once we get xlC
Hi Matthias,
At this point, I think we can remove the flag as you found that it is not
supported in XLC < 13. And with XLC 13, it require more work to use this flag.
Thanks,
Bhaktavatsal Reddy
-"Baesken, Matthias" wrote: -
To: "Langer, Christoph" ,
"'build-dev@openjdk.java.net'" ,
Hello Christoph, I think all XLC versions < 12.1 are unsupported (and
probably not working anyway) for the OpenJDK build .
I am only aware of XLC versions 12.1 and 13.1which work / in case of
13.1 "might" work for OpenJDK compilation .
And for 12.1 I want to remove the f
Hi Matthias,
to me the change in principal looks good.
I'm wondering if it is possible to do a comparison like xlc < 13 (e.g. extract
major number before the first dot, then compare numerically) - but maybe it is
too complicated and the current single version compare suits our needs ?
Best reg
> Its right in time. I am facing "Undefined Symbol" errors with XLC 13.1 due to
> "-qvisibility=hidden" which hides all symbols by default. I workaround that by
> removing this flag
Hello, so it seems that I better remove the "-qvisibility="
completely for xlc (and not only for xlc12
Hi Matthias,
Its right in time. I am facing "Undefined Symbol" errors with XLC 13.1 due to
"-qvisibility=hidden" which hides all symbols by default. I workaround that by
removing this flag
-bash-4.4$ xlC -qversion
IBM XL C/C++ for AIX, V13.1.3 (5725-C72, 5765-J07)
Version: 13.01.0003.
Look
Hi Matthias,
I would prefer a numerical comparison to version < 13. Otherwise the
code looks like you want to just exclude 12.1 for some reason when in
reality you want to omit the flag for any compiler older than xlc 13.
Best Regards, Thomas
On Thu, Apr 26, 2018 at 4:13 PM, Baesken, Matthias
Hello , could you please review this small adjustment to the symbol
visibility compilation settings on AIX ?
Currently we use XLC 12.1 to compile JDK on AIX .
However XLC 12.1 does not support the "-qvisibility=hidden" setting
currently set on AIX.
It was introduced with XLC 13.1 . C
Hi Thomas,
this looks good and will simplify building on AIX.
Thanks,
Goetz.
> -Original Message-
> From: ppc-aix-port-dev [mailto:ppc-aix-port-dev-
> boun...@openjdk.java.net] On Behalf Of Thomas Stüfe
> Sent: Donnerstag, 26. April 2018 16:04
> To: build-dev ; ppc-aix-port-
> d...@op
Hi all,
may I have reviews please:
https://bugs.openjdk.java.net/browse/JDK-8202325
http://cr.openjdk.java.net/~stuefe/webrevs/8202325-aix-disable-warnings-as-errors/webrev.00/webrev/
We decided to disable warnings as errors by default on AIX. This is a
pragmatic decision - we will never be able
If we have a conditional variable to set "
hotspot-$(JVM_VARIANT_MAIN)-gensrc" target then this can give way to
alternate VMs like eclipse openj9 to extend that to set it appropriately.
diff --git a/make/Main.gmk b/make/Main.gmk
index 731e9c9934..444a835cb4 100644
--- a/make/Main.gmk
+++ b/make/M
Same here. I would like to have this fix in, but do not want to go
over Phils head.
I think Phil was the main objector, maybe he could reconsider?`
Thanks, Thomas
On Thu, Apr 26, 2018 at 10:39 AM, Magnus Ihse Bursie
wrote:
> I don't object, but it's not build code so I don't have the final say.
On 2018-04-25 13:06, Erik Gahlin wrote:
Greetings,
Could I have a review of 8199712: Flight Recorder
As mentioned in the preview [1] the tracing backend has been removed.
Event metadata has been consolidated into a single XML file and event
classes are now generated by GenerateJfrFiles.java.
I don't object, but it's not build code so I don't have the final say.
/Magnus
On 2018-04-25 17:43, Adam Farley8 wrote:
Hi All,
Does anyone have an objection to pushing this tiny change in?
It doesn't break anything, it fixes a build break on two supported
platforms, and it seems
like we ne
Thanks Erik -
I went ahead with the jdk's make/CopyFiles.gmk change, and added
SetupCopyFiles to the base repo's make/common/MakeBase.gmk.
I updated the webrev, to include base and jdk repos:
http://cr.openjdk.java.net/~kevinw/8042707/webrev.01/
I'm getting these build OK with VS2012, but th
() to report all non-empty
directories in the shared path table entries before exiting VM.
Full webrev:
http://java.se.oracle.com:10065/mdash/jobs/jianzhou-jdk-20180426-0406-20150
Tested all modified tests locally. Rerunning hs-tier1 ~ hs-tier5 tests.
Thanks for all the suggestions!
Jiangli
40 matches
Mail list logo
