Re: RFR: JDK-8202920: jvm.cfg generation incorrect

2018-05-10 Thread Aleksey Shipilev
On 05/11/2018 06:56 AM, David Holmes wrote: > On 11/05/2018 10:03 AM, Erik Joelsson wrote: >> On 2018-05-10 15:52, David Holmes wrote: >>> Given these jvm.cfg files have been slated for removal for a very long >>> time, I don't think you >>> want to add new configure options related to them. Even

Re: RFR: JDK-8202920: jvm.cfg generation incorrect

2018-05-10 Thread David Holmes
On 11/05/2018 10:03 AM, Erik Joelsson wrote: On 2018-05-10 15:52, David Holmes wrote: On 11/05/2018 8:41 AM, Erik Joelsson wrote: Here is a new webrev where the IGNORED are added last. http://cr.openjdk.java.net/~erikj/8202920/webrev.02/ It will still change the default on windows-x86 however

Re: Build failure on Fedora 28

2018-05-10 Thread Yasumasa Suenaga
Hi, I found 1 GCC optimization issue, but it is not enough. http://cr.openjdk.java.net/~ysuenaga/openjdk-fc28/gcc8-opt/gdb-before.txt I traced class loading from `modules`. Above log is copy of GDB console in ImageFileReader::verify_location(). The code expects `*next++` increments after referri

Re: RFR: JDK-8202920: jvm.cfg generation incorrect

2018-05-10 Thread Erik Joelsson
On 2018-05-10 15:52, David Holmes wrote: On 11/05/2018 8:41 AM, Erik Joelsson wrote: Here is a new webrev where the IGNORED are added last. http://cr.openjdk.java.net/~erikj/8202920/webrev.02/ It will still change the default on windows-x86 however. If we really care about this, then perhap

RFR: 8199807 & 8202738: AppCDS performs overly restrictive path matching check

2018-05-10 Thread Jiangli Zhou
Hi, Please review the following webrev that addresses the issue of copied/moved JDK image after generating a CDS archive. Thanks Karen Kinnear and Alan Baterman for initiating the investigation & discussions in this area (especially the ease of usage). Thanks Ioi for implementing a test case fo

Re: RFR: JDK-8202920: jvm.cfg generation incorrect

2018-05-10 Thread David Holmes
On 11/05/2018 8:41 AM, Erik Joelsson wrote: Here is a new webrev where the IGNORED are added last. http://cr.openjdk.java.net/~erikj/8202920/webrev.02/ It will still change the default on windows-x86 however. If we really care about this, then perhaps we need to add a configure flag that allo

Re: RFR: JDK-8202920: jvm.cfg generation incorrect

2018-05-10 Thread Erik Joelsson
Here is a new webrev where the IGNORED are added last. http://cr.openjdk.java.net/~erikj/8202920/webrev.02/ It will still change the default on windows-x86 however. If we really care about this, then perhaps we need to add a configure flag that allows the builder to pick the default variant.

Re: RFR: JDK-8202920: jvm.cfg generation incorrect

2018-05-10 Thread Erik Joelsson
On 2018-05-10 15:12, David Holmes wrote: Hi Erik, cc'ing Kumar as he is nominally the owner of the jvm.cfg files. On 11/05/2018 3:38 AM, Erik Joelsson wrote: I took a further look at the jvm.cfg generation and reworked it completely. This change removes all the predefined jvm.cfg files and re

Re: RFR: JDK-8202920: jvm.cfg generation incorrect

2018-05-10 Thread David Holmes
Hi Erik, cc'ing Kumar as he is nominally the owner of the jvm.cfg files. On 11/05/2018 3:38 AM, Erik Joelsson wrote: I took a further look at the jvm.cfg generation and reworked it completely. This change removes all the predefined jvm.cfg files and replaces them with a simple generation scrip

Re: RFR: JDK-8202919: JDK-8202683 broke macosx build

2018-05-10 Thread David Holmes
On 11/05/2018 2:36 AM, Erik Joelsson wrote: The macosx build fails with: jib > /usr/bin/printf: illegal option -- s jib > usage: printf format [arguments ...] jib > Copy-java.base.gmk:123: recipe for target '/scratch/mesos/slaves/555f5737-a945-4eb0-8d30-afb1fc816afd-S23/frameworks/1735e8a2-a1db

RE: [11] RFR for JDK-8202544: Hide unused exports in libzip

2018-05-10 Thread Langer, Christoph
Hi Alexey, looks good to me. Symbols don't seem to be needed outside libzip (java.base). Best regards Christoph > -Original Message- > From: build-dev [mailto:[email protected]] On Behalf Of > Alexey Ivanov > Sent: Mittwoch, 9. Mai 2018 16:35 > To: core-libs ; hotspot-de

Re: RFR: JDK-8202920: jvm.cfg generation incorrect

2018-05-10 Thread Aleksey Shipilev
On 05/10/2018 07:38 PM, Erik Joelsson wrote: > I took a further look at the jvm.cfg generation and reworked it completely. > This change removes all > the predefined jvm.cfg files and replaces them with a simple generation > script. This should produce > the same files as before JDK-8202683 for a

RFR: JDK-8202920: jvm.cfg generation incorrect

2018-05-10 Thread Erik Joelsson
I took a further look at the jvm.cfg generation and reworked it completely. This change removes all the predefined jvm.cfg files and replaces them with a simple generation script. This should produce the same files as before JDK-8202683 for any configuration Oracle builds officially and zero. F

Re: RFR: JDK-8202919: JDK-8202683 broke macosx build

2018-05-10 Thread Tim Bell
Erik: On 05/10/18 09:42, Aleksey Shipilev wrote: On 05/10/2018 06:36 PM, Erik Joelsson wrote: The macosx build fails with: jib > /usr/bin/printf: illegal option -- s jib > usage: printf format [arguments ...] jib > Copy-java.base.gmk:123: recipe for target '/scratch/mesos/slaves/555f5737-a945-

Re: RFR: JDK-8202919: JDK-8202683 broke macosx build

2018-05-10 Thread Aleksey Shipilev
On 05/10/2018 06:36 PM, Erik Joelsson wrote: > The macosx build fails with: > > jib > /usr/bin/printf: illegal option -- s > jib > usage: printf format [arguments ...] > jib > Copy-java.base.gmk:123: recipe for target > '/scratch/mesos/slaves/555f5737-a945-4eb0-8d30-afb1fc816afd-S23/frameworks/173

RFR: JDK-8202919: JDK-8202683 broke macosx build

2018-05-10 Thread Erik Joelsson
The macosx build fails with: jib > /usr/bin/printf: illegal option -- s jib > usage: printf format [arguments ...] jib > Copy-java.base.gmk:123: recipe for target '/scratch/mesos/slaves/555f5737-a945-4eb0-8d30-afb1fc816afd-S23/frameworks/1735e8a2-a1db-478c-8104-60c8b0af87dd-0196/executors/6b28d4

Re: RFR: JDK-8202914: Let custom makefile override jmod intput dir locations

2018-05-10 Thread Tim Bell
Erik: We need to be able to override some input dir locations from a custom makefile extension. Bug: https://bugs.openjdk.java.net/browse/JDK-8202914 Webrev: http://javaweb.us.oracle.com/~ejoelsso/webrev/8202914/webrev.01/ Looks good. Tim

RFR: JDK-8202914: Let custom makefile override jmod intput dir locations

2018-05-10 Thread Erik Joelsson
We need to be able to override some input dir locations from a custom makefile extension. Bug: https://bugs.openjdk.java.net/browse/JDK-8202914 Webrev: http://javaweb.us.oracle.com/~ejoelsso/webrev/8202914/webrev.01/ /Erik