Hi Erik,
Thank you so much for investigating a proper fix for the vm_version.o issue. I
will withdraw the build change from my original webrev.
Thanks again for taking over the bug!
Jiangli
> On May 11, 2018, at 2:33 PM, Erik Joelsson wrote:
>
> Received: from [10.132.185.167] (/10.132.185.1
Hello,
For the build change, it's very undesirable to always have to relink
libjvm on every incremental build. Such a change cannot be accepted.
I have a counter suggestion, which is still a bit of a hack, but it will
cause vm_version.cpp to be recompiled (almost) every time libjvm.so
needs
Here is a new attempt. This time I'm pretty sure it produces the same
jvm.cfg as all the predefined ones. It's easy to define a new default
variant for specific configurations (as is done for windows-x86). It
also handles the jvm variants that aren't server, client or minimal
correctly (by trea
Looks good to me,
Misha
On 5/8/18, 2:23 PM, Leonid Mesnik wrote:
Hi
Please review this change open sourcing vm testbase stress tests. These tests
have been developed a long time ago for internal test harness and don't looks
very nice now.
They are open sourced with minimal changes only. The
On 2018-05-10 21:56, David Holmes wrote:
On 11/05/2018 10:03 AM, Erik Joelsson wrote:
On 2018-05-10 15:52, David Holmes wrote:
On 11/05/2018 8:41 AM, Erik Joelsson wrote:
Here is a new webrev where the IGNORED are added last.
http://cr.openjdk.java.net/~erikj/8202920/webrev.02/
It will still
Pushed. Sorry for the mess!
-Aleksey
On 05/11/2018 05:35 PM, Erik Joelsson wrote:
> Please do, thanks!
>
> /Erik
>
>
> On 2018-05-11 05:39, Aleksey Shipilev wrote:
>> Thanks!
>>
>> Erik J., want me to push this?
>>
>> -Aleksey
>>
>> On 05/11/2018 09:41 AM, Thomas Stüfe wrote:
>>> Looks fine an
Please do, thanks!
/Erik
On 2018-05-11 05:39, Aleksey Shipilev wrote:
Thanks!
Erik J., want me to push this?
-Aleksey
On 05/11/2018 09:41 AM, Thomas Stüfe wrote:
Looks fine and trivial.
.. Thomas
On Fri, May 11, 2018 at 9:01 AM, Aleksey Shipilev wrote:
Hi,
As we can see, recent fix to
On 11.5.2018 12:31, Maurizio Cimadamore wrote:
Thumbs up - thanks for taking the comments into account.
Great job!
+1
Jan
Maurizio
On 04/05/18 22:59, Jonathan Gibbons wrote:
Here's an update to the previously proposed patch for JEP 330: Launch
Single-File Source-Code Programs.
It includ
Thanks!
Erik J., want me to push this?
-Aleksey
On 05/11/2018 09:41 AM, Thomas Stüfe wrote:
> Looks fine and trivial.
>
> .. Thomas
>
> On Fri, May 11, 2018 at 9:01 AM, Aleksey Shipilev wrote:
>> Hi,
>>
>> As we can see, recent fix to jvm.cfg configuration was messed up. Erik is
>> trying to
Hi Alexey,
good catch, I missed that.
Best regards
Christoph
> -Original Message-
> From: Alexey Ivanov [mailto:[email protected]]
> Sent: Freitag, 11. Mai 2018 13:21
> To: Langer, Christoph ; core-libs [email protected]>; hotspot-dev ;
> build-dev ; Magnus Ihse Bursie
>
>
Hi Christoph,
Thank you for your review.
I was checking the changeset before pushing and noticed I had forgotten
to remove JNIEXPORT modifier from ZIP_GetEntry in zip_util.h.
Here's the updated webrev:
http://cr.openjdk.java.net/~aivanov/8202544/jdk11/webrev.1/
The only difference with previ
Thumbs up - thanks for taking the comments into account.
Great job!
Maurizio
On 04/05/18 22:59, Jonathan Gibbons wrote:
Here's an update to the previously proposed patch for JEP 330: Launch
Single-File Source-Code Programs.
It includes all review feedback so far. The changes are mostly minor,
Looks fine and trivial.
.. Thomas
On Fri, May 11, 2018 at 9:01 AM, Aleksey Shipilev wrote:
> Hi,
>
> As we can see, recent fix to jvm.cfg configuration was messed up. Erik is
> trying to fix that with
> JDK-8202920 (thanks!). Meanwhile, it seems prudent to backout the offending
> change. Backo
Hi,
As we can see, recent fix to jvm.cfg configuration was messed up. Erik is
trying to fix that with
JDK-8202920 (thanks!). Meanwhile, it seems prudent to backout the offending
change. Backout applies
cleanly.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8202974
Fix:
http://cr.openjdk.ja
14 matches
Mail list logo
