+1
Kumar
Hi Erik,
As long as the end result is a jvm.cfg that matches the current ones
in the repo then this looks fine.
Thanks,
David
On 12/05/2018 3:46 AM, Erik Joelsson wrote:
Here is a new attempt. This time I'm pretty sure it produces the same
jvm.cfg as all the predefined ones. It'
> On May 14, 2018, at 2:56 PM, Magnus Ihse Bursie
> wrote:
>
> On 2018-05-11 23:33, Erik Joelsson wrote:
>> Hello,
>>
>> For the build change, it's very undesirable to always have to relink libjvm
>> on every incremental build. Such a change cannot be accepted.
>>
>> I have a counter suggest
Hi Erik,
As long as the end result is a jvm.cfg that matches the current ones in
the repo then this looks fine.
Thanks,
David
On 12/05/2018 3:46 AM, Erik Joelsson wrote:
Here is a new attempt. This time I'm pretty sure it produces the same
jvm.cfg as all the predefined ones. It's easy to def
On 2018-05-11 23:33, Erik Joelsson wrote:
Hello,
For the build change, it's very undesirable to always have to relink
libjvm on every incremental build. Such a change cannot be accepted.
I have a counter suggestion, which is still a bit of a hack, but it
will cause vm_version.cpp to be recom
On 2018-05-14 18:05, Erik Joelsson wrote:
Oh, I missed the new makefiles last time I looked at this.
in Copy-jdk.jfr.gmk, everything looks like it's indented an extra 4
steps. I'm assuming this is because it used to be conditional in the
previous closed file.
GensrcJfr.gmk, line 94, please m
On 2018-05-11 19:46, Erik Joelsson wrote:
Here is a new attempt. This time I'm pretty sure it produces the same
jvm.cfg as all the predefined ones. It's easy to define a new default
variant for specific configurations (as is done for windows-x86). It
also handles the jvm variants that aren't se
On 2018-05-14 17:50, Erik Joelsson wrote:
On 2018-05-13 00:37, Magnus Ihse Bursie wrote:
Just to mess a bit more with you all, maybe this code does not really
belong in "copy" "java.base", but rather more Hotspot and gensrc? The
jvm.cfg is, after all, describing the hotspot build configuration.
Thank you for review.
Leonid
> On May 8, 2018, at 2:41 PM, Erik Joelsson wrote:
>
> Build changes look good.
>
> /Erik
>
>
> On 2018-05-08 14:23, Leonid Mesnik wrote:
>> Hi
>>
>> Please review this change open sourcing vm testbase stress tests. These
>> tests have been developed a long tim
Misha
Thank you for review. I still need one more review from 'R'eviewer.
Leonid
> On May 11, 2018, at 9:10 AM, Mikhailo Seledtsov
> wrote:
>
> Looks good to me,
>
> Misha
>
> On 5/8/18, 2:23 PM, Leonid Mesnik wrote:
>> Hi
>>
>> Please review this change open sourcing vm testbase stress te
Changes look good to me,
Misha
On 05/09/2018 02:09 PM, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8199384/webrev.00/index.html
61414 lines changed: 61414 ins; 0 del; 0 mod;
Hi all,
could you please review this patch which open sources MLVM tests from VM
testbase?
these te
On 05/11/2018 07:46 PM, Erik Joelsson wrote:
> Here is a new attempt. This time I'm pretty sure it produces the same jvm.cfg
> as all the predefined
> ones. It's easy to define a new default variant for specific configurations
> (as is done for
> windows-x86). It also handles the jvm variants tha
Oh, I missed the new makefiles last time I looked at this.
in Copy-jdk.jfr.gmk, everything looks like it's indented an extra 4
steps. I'm assuming this is because it used to be conditional in the
previous closed file.
GensrcJfr.gmk, line 94, please move )) to the left.
Looking closer at Gens
On 2018-05-13 00:37, Magnus Ihse Bursie wrote:
Just to mess a bit more with you all, maybe this code does not really belong in "copy"
"java.base", but rather more Hotspot and gensrc? The jvm.cfg is, after all, describing
the hotspot build configuration.
Maybe, but I believe historically it's be
Here is an updated webrev:
http://cr.openjdk.java.net/~egahlin/8199712.1/ [1]
that incorporates:
- build changes
- new event prefix, i.e. "com.oracle.jdk.CPULoad" becomes "jdk.CPULoad"
- obsolete command line options EnableTracing and UseLockedTracing
- fixed typos in the Javadoc
- simplified #
Hello Christoph.
Our team tested your fixed code on Linux (RHEL7) and AIX (7.1).
resetCompositionState() was missing in
src/java.desktop/aix/classes/sun/awt/X11InputMethod.java
--- a/src/java.desktop/aix/classes/sun/awt/X11InputMetho
On 05/08/2018 12:35 AM, Igor Ignatyev wrote:
Hi all,
Hi Igor,
On 05/08/2018 12:35 AM, Igor Ignatyev wrote:
could you please review the patch which open sources GC tests from vm testbase?
it introduces the following test groups:
- vmTestbase_vm_g1classunloading
- vmTestbase_vm_gc_compact
- vm
Hi Phil,
Would an acceptable compromise be to deliver the source code change
and send the code to the upstream community, allowing them to include
the fix if/when they are able?
I believe Magnus was advocating this idea as well. See below.
Best Regards
Adam Farley
> Same here. I would like to
17 matches
Mail list logo
