Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

On 8/06/2018 6:11 AM, Erik Joelsson wrote: On 2018-06-07 11:56, [email protected] wrote: On 6 Jun 2018, at 06:17, David Holmes > wrote: Hi Erik, Jesper, So "benevolent dictatorship"?  ;-) My main concern is that the updated toolchains that support

Re: RFR (XL): JDK-8204572 SetupJdkLibrary should setup SRC and -I flags automatically

Hello Magnus, Very nice refactoring! JdkNativeCompilation.gmk line 126-127 looks a bit long. There is an extra space on 126. Also, why not addprefix for adding -I instead of clunky foreach? Not that I care greatly, but I usually prefer that construct. Otherwise looks good. /Erik On 2018-0

RFR (XL): JDK-8204572 SetupJdkLibrary should setup SRC and -I flags automatically

This change needs some background information. I've been working on simplifying and streamlining the compilation of native libraries of the JDK. Previously, I introduced the SetupJdkLibrary function, and started to get a better control of compiler flags. This patch continues on both paths. T

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

On 2018-06-07 11:56, [email protected] wrote: On 6 Jun 2018, at 06:17, David Holmes > wrote: Hi Erik, Jesper, So "benevolent dictatorship"?  ;-) My main concern is that the updated toolchains that support this have all been produced in a mad rus

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

> On 6 Jun 2018, at 06:17, David Holmes wrote: > > Hi Erik, Jesper, > > On 6/06/2018 2:59 AM, [email protected] > wrote: >>> On 5 Jun 2018, at 08:10, David Holmes wrote: >>> >>> Sorry to be late to this party ... >>> >>> On 5/06/2018 6:10 AM

RE: RFR : 8204541 Correctly support AIX xlC 13.1 symbol visibility flags

Hello Christoph According to build log, if <#include "osSupport.hpp"> was there: "/home/jdktest/sandbox/jdk/build/aix-ppc64-normal-server-release/support/headers/java.base/jdk_internal_jimage_NativeImageBuffer.h", line 15.27: 1540-0040 (S) The text "Java_jdk_internal_jimage_NativeImageBuffer_ge

RE: RFR : 8204541 Correctly support AIX xlC 13.1 symbol visibility flags

Hi Ichiroh, what's the exact error message if you #include "osSupport.hpp"? (I have no xlC 13 at hand to try myself...) Best regards Christoph > -Original Message- > From: Ichiroh Takiguchi [mailto:[email protected]] > Sent: Donnerstag, 7. Juni 2018 14:53 > To: build-dev@openj

RFR : 8204541 Correctly support AIX xlC 13.1 symbol visibility flags

Hello. Could you review it ? Bug:https://bugs.openjdk.java.net/browse/JDK-8204541 Change: http://cr.openjdk.java.net/~clanger/webrevs/8204541.0/ Thanks, Ichiroh Takiguchi IBM Japan, Ltd. Original Message Subject: RE: RFR : 8202322: AIX: symbol visibility flags not support

RE: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

Hi Ichiroh, your proposal seems to make sense. I have created a bug for this: https://bugs.openjdk.java.net/browse/JDK-8204541 Can you please generate a webrev (referencing this bug, -c option of webrev.ksh) and mail it over to me. Then I'll upload it and you can post an official RFR mail. Be