RFR: JDK-8204127: Change bundle format on Windows to zip

2018-06-08 Thread Erik Joelsson
The compressed archive bundles we create are all tar.gz format. On Windows that's not a very common format, requiring third party applications to handle, while the zip format can be natively extracted. This patch changes the bundle format for the JDK on Windows to zip. This only applies to the

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

2018-06-08 Thread Erik Joelsson
Doh, thanks, updated in place. /Erik On 2018-06-08 14:53, Daniel D. Daugherty wrote: On 6/8/18 5:50 PM, Erik Joelsson wrote: On 2018-06-07 17:30, David Holmes wrote: On 8/06/2018 6:11 AM, Erik Joelsson wrote: I just don't think the extra work is warranted or should be prioritized at this po

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

2018-06-08 Thread Daniel D. Daugherty
On 6/8/18 5:50 PM, Erik Joelsson wrote: On 2018-06-07 17:30, David Holmes wrote: On 8/06/2018 6:11 AM, Erik Joelsson wrote: I just don't think the extra work is warranted or should be prioritized at this point. I also cannot think of a combination of options required for what you are suggestin

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

2018-06-08 Thread Erik Joelsson
On 2018-06-07 17:30, David Holmes wrote: On 8/06/2018 6:11 AM, Erik Joelsson wrote: I just don't think the extra work is warranted or should be prioritized at this point. I also cannot think of a combination of options required for what you are suggesting that wouldn't be confusing to the user

Re: RFR (XL): JDK-8204572 SetupJdkLibrary should setup SRC and -I flags automatically

2018-06-08 Thread Erik Joelsson
Looks good. /Erik On 2018-06-08 01:50, Magnus Ihse Bursie wrote: On 2018-06-07 23:20, Erik Joelsson wrote: Hello Magnus, Very nice refactoring! Thanks! JdkNativeCompilation.gmk line 126-127 looks a bit long. There is an extra space on 126. Also, why not addprefix for adding -I instead o

Re: RFR: JDK-8204602 Add devkit for linux-arm32

2018-06-08 Thread Erik Joelsson
Looks ok to me. /Erik On 2018-06-08 01:38, Magnus Ihse Bursie wrote: With some simple changes, our devkit scripts can be made to generate devkits for cross-compiling on linux-x64 to linux-arm (32-bit). Also add a jib profile to use this new linux-arm devkit, as opposed to the legacy devkits

Re: [8u] RFR: 8196108: Add build support for VS 2015/2017

2018-06-08 Thread Magnus Ihse Bursie
On 2018-06-08 11:27, Kevin Walls wrote: Hi, I'd like to get a review of a backport to jdk8u of: 8196108: Add build support for VS 2015/2017 https://bugs.openjdk.java.net/browse/JDK-8196108 JDK 11 changeset: http://hg.openjdk.java.net/jdk/jdk/rev/bcce1fa183e7 Original review thread: http://ma

[8u] RFR: 8196108: Add build support for VS 2015/2017

2018-06-08 Thread Kevin Walls
Hi, I'd like to get a review of a backport to jdk8u of: 8196108: Add build support for VS 2015/2017 https://bugs.openjdk.java.net/browse/JDK-8196108 JDK 11 changeset: http://hg.openjdk.java.net/jdk/jdk/rev/bcce1fa183e7 Original review thread: http://mail.openjdk.java.net/pipermail/build-dev/2

Re: RFR (XL): JDK-8204572 SetupJdkLibrary should setup SRC and -I flags automatically

2018-06-08 Thread Magnus Ihse Bursie
On 2018-06-07 23:20, Erik Joelsson wrote: Hello Magnus, Very nice refactoring! Thanks! JdkNativeCompilation.gmk line 126-127 looks a bit long. There is an extra space on 126. Also, why not addprefix for adding -I instead of clunky foreach? Not that I care greatly, but I usually prefer that

RFR: JDK-8204602 Add devkit for linux-arm32

2018-06-08 Thread Magnus Ihse Bursie
With some simple changes, our devkit scripts can be made to generate devkits for cross-compiling on linux-x64 to linux-arm (32-bit). Also add a jib profile to use this new linux-arm devkit, as opposed to the legacy devkits used by the traditional linux-arm profiles. Note that this change does

RE: RFR : 8204541 Correctly support AIX xlC 13.1 symbol visibility flags

2018-06-08 Thread Langer, Christoph
Hi Ichiroh, Ok, so as per the output, via the include of osSupport.hpp, something must happen which undeclares "visibility" or makes it ambiguous. Looking at osSupport.hpp, I can't see anything special. It would just include pthread.h and declare some c++ classes. You could try to get and anal