RE: RFR(xs): 8204935: [aix] TOC overflow in libjvm.so (release build)

Hi Thomas, thanks for fixing and doing the cleanup right away. Looks good. Best regards, Goetz. > -Original Message- > From: ppc-aix-port-dev [mailto:ppc-aix-port-dev- > [email protected]] On Behalf Of Thomas Stüfe > Sent: Mittwoch, 13. Juni 2018 08:14 > To: build-dev ; ppc-ai

RFR(xs): 8204935: [aix] TOC overflow in libjvm.so (release build)

Hi all, may I have reviews for this small build fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8204935 webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8204935-aix-toc-overflow/webrev.00/webrev/ We finally have reached the point where even the standard (not gtest) release build libjvm.so

Re: RFR: JDK-8204922: Create bootcycle jib profiles

Looks good to me. /Magnus > 13 juni 2018 kl. 02:34 skrev Erik Joelsson : > > In order to test bootcycle builds more easily at Oracle, we need specific jib > profiles for them. This patch adds that. I also make the linux-aarch64 > profile explicitly build the aarch64 port instead of the arm64

Re: RFR: JDK-8204922: Create bootcycle jib profiles

Erik: In order to test bootcycle builds more easily at Oracle, we need specific jib profiles for them. This patch adds that. I also make the linux-aarch64 profile explicitly build the aarch64 port instead of the arm64 port as well as disable warnings-as-errors since we currently have the readdir

RFR: JDK-8204922: Create bootcycle jib profiles

In order to test bootcycle builds more easily at Oracle, we need specific jib profiles for them. This patch adds that. I also make the linux-aarch64 profile explicitly build the aarch64 port instead of the arm64 port as well as disable warnings-as-errors since we currently have the readdir warn

Re: [8u-dev] RFR for 8179675: Build with error on windows with new Cygwin grep

Looks good. /Erik On 2018-06-12 11:08, Alexey Ivanov wrote: Resending with clickable link to the webrev: http://cr.openjdk.java.net/~aivanov/8179675/jdk8/webrev.0/ -- Alexey On 12/06/2018 19:06, Alexey Ivanov wrote: Hi, Could you please review the following fix for 8u-dev? JBS: https://bu

Re: [8u-dev] RFR for 8179675: Build with error on windows with new Cygwin grep

Resending with clickable link to the webrev: http://cr.openjdk.java.net/~aivanov/8179675/jdk8/webrev.0/ -- Alexey On 12/06/2018 19:06, Alexey Ivanov wrote: Hi, Could you please review the following fix for 8u-dev? JBS: https://bugs.openjdk.java.net/browse/JDK-8179675 webrev: http://cr.openjdk

[8u-dev] RFR for 8179675: Build with error on windows with new Cygwin grep

Hi, Could you please review the following fix for 8u-dev? JBS: https://bugs.openjdk.java.net/browse/JDK-8179675 webrev: cr.openjdk.java.net/~aivanov/8179675/jdk8/webrev.0/ The problem is that newer grep v3.0 does not match the end-of-line if the input uses Windows line endings. The fix remov

Re: bash configure - LINK : fatal error LNK1104: cannot open file ...fixpath.exe

Hey Erik, I was running into warnings in the standard library being treated as errors with VS 2015, so --disable-warnings-as-errors did the trick :D The information I remembered turned out to be outdated. I went and looked at doc/building.html again and found that amber required at least VS

RE: bash configure - LINK : fatal error LNK1104: cannot open file ...fixpath.exe

Hi, You can find the patches here: https://github.com/peterbud/MINGW-packages/tree/openjdk/mingw-w64-openjdk I have managed to build OpenJDK on MSYS2 with gcc, both 32 and 64 bit, but that was obviously the beginning. Around 10% of the test cases were failing so more work would have been n

Re: [11] RFR(S) 8204113: Upgrade linker used in AOT tests to be same version as build toolchain

Thank you, Erik Vladimir On 6/12/18 6:41 AM, Erik Joelsson wrote: Looks good. /Erik On 2018-06-11 18:15, Vladimir Kozlov wrote: http://cr.openjdk.java.net/~kvn/8204113/webrev.01/ https://bugs.openjdk.java.net/browse/JDK-8204113 AOT tests need a local linker to generate AOT libraries. They

Re: bash configure - LINK : fatal error LNK1104: cannot open file ...fixpath.exe

Hello, Glad to hear you got Cygwin in order! The officially supported toolchain for jdk/jdk (current mainline for JDK 11) is VS 2017. We recently upgraded from 2013. Amber seems to be pretty much up to date with that from looking at the repo changes. You can check at the top of toolchain_wind

Re: [11] RFR(S) 8204113: Upgrade linker used in AOT tests to be same version as build toolchain

Looks good. /Erik On 2018-06-11 18:15, Vladimir Kozlov wrote: http://cr.openjdk.java.net/~kvn/8204113/webrev.01/ https://bugs.openjdk.java.net/browse/JDK-8204113 AOT tests need a local linker to generate AOT libraries. They load devkits from our infrastructure when there is no local linker o

Re: bash configure - LINK : fatal error LNK1104: cannot open file ...fixpath.exe

Hello guys, I tried the rebaseall and it worked. Tbh, I hadn't really looked into cygwin that much since I wanted to avoid having PATH conflicts between 3 different versions of tools (one windows, one msys, and one cygwin). I should have done that right away though since it was really easy to

Re: bash configure - LINK : fatal error LNK1104: cannot open file ...fixpath.exe

I second the advice to get cygwin up and running. Cygwin is the canonical way to build on windows. Unless you have really pressing reasons to use something else, I would use what (almost) everyone else uses. I have my windows build env up and running on a fresh windows machine usually in ~30 minut