Locally tested the fix below and via mach5 jobs.
The ~50 failed tests all completed successfully.
It'd be good for Erik to repeat his full testing with
this patch included in case it blocked other issues
from being observed.
This fix can be integrated after the sync from jdk/client.
Issue:
On 2018-06-14 12:49, Magnus Ihse Bursie wrote:
Would it have been to problematic to reverse the the logic, i.e.
having a "include translation" rather than an exclude? Feels more
brittle; if someone adds a translation the exclude list needs to be
updated. Also, a include mechanism could
Looks good to me.
Naoto
On 6/14/18 11:52 AM, Erik Joelsson wrote:
Hello,
Here is a new version of the patch:
http://cr.openjdk.java.net/~erikj/8204973/webrev.02/
Changes from last time:
* Made the regexp for finding locales more correct. It still does not
try to match 3 letter language
Would it have been to problematic to reverse the the logic, i.e. having
a "include translation" rather than an exclude? Feels more brittle; if
someone adds a translation the exclude list needs to be updated. Also, a
include mechanism could possibly be used, much simpler, by someone who
only
Hi Volker,
http://cr.openjdk.java.net/~simonis/webrevs/2018/8204965/make/autoconf/hotspot.m4.udiff.html
Seems like a roundabout way to have a platform specific default value.
Why not determine a default value beforehand:
if test "x$OPENJDK_TARGET_OS" = "xaix"; then
ENABLE_CDS_DEFAULT="false"
Hello,
Here is a new version of the patch:
http://cr.openjdk.java.net/~erikj/8204973/webrev.02/
Changes from last time:
* Made the regexp for finding locales more correct. It still does not
try to match 3 letter language strings because doing so triggers a large
amount of false positives in
Hi Volker,
The changes look good to me overall. I’ll refer to the JVMTI experts for
jvmtiEnv.cpp change. I have a question for the change in vmStructs.cpp. Any
reason why only _current_info needs CDS_ONLY?
//
Build changes look ok.
/Erik
On 2018-06-14 07:26, Volker Simonis wrote:
Hi,
can I please have a review for the following fix:
http://cr.openjdk.java.net/~simonis/webrevs/2018/8204965/
https://bugs.openjdk.java.net/browse/JDK-8204965
CDS does currently not work on AIX because of the way how
Hi,
can I please have a review for the following fix:
http://cr.openjdk.java.net/~simonis/webrevs/2018/8204965/
https://bugs.openjdk.java.net/browse/JDK-8204965
CDS does currently not work on AIX because of the way how we
reserve/commit memory on AIX. The problem is that we're using a
