[11] RFR(M) 8206135: Building jvm with AOT but without JVMCI should fail at configure time

2018-07-09 Thread Vladimir Kozlov
http://cr.openjdk.java.net/~kvn/8206135/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8206135 Several configure issues was found related to jvmci, graal and aot build. Main problem is related values specified with --with-jvm-features were ignored. For example, JVMCI module was still built

Re: RFR: JDK-8206323: Missing some legal notices in docs bundle

2018-07-09 Thread Tim Bell
Erik - Looks good to me as well. Tim On 07/09/18 10:15, mandy chung wrote: +1 Mandy On 7/9/18 9:40 AM, Erik Joelsson wrote: Hello, The docs bundle is missing some of the legal notices from the jdk.javadoc module. It should just include all the legal files from that module. This patch remov

Re: RFR: JDK-8206323: Missing some legal notices in docs bundle

2018-07-09 Thread mandy chung
+1 Mandy On 7/9/18 9:40 AM, Erik Joelsson wrote: Hello, The docs bundle is missing some of the legal notices from the jdk.javadoc module. It should just include all the legal files from that module. This patch removes the explicit list and uses wildcard to get all the files instead. Bug:

Re: JDK 12 RFR of build portions of JDK-802856: Remove javac support for 6/1.6 source and target values

2018-07-09 Thread Erik Joelsson
Looks good to me. /Erik On 2018-07-09 09:41, joe darcy wrote: Hello, Please review the build portions of JDK-802856: Remove javac support for 6/1.6 source and target values http://cr.openjdk.java.net/~darcy/8028563.4/ The langtools aspects of the change are out for review on compi

JDK 12 RFR of build portions of JDK-802856: Remove javac support for 6/1.6 source and target values

2018-07-09 Thread joe darcy
Hello, Please review the build portions of JDK-802856: Remove javac support for 6/1.6 source and target values http://cr.openjdk.java.net/~darcy/8028563.4/ The langtools aspects of the change are out for review on compiler-dev [1]. I've checked with Jan Lahoda who implemented much of

RFR: JDK-8206323: Missing some legal notices in docs bundle

2018-07-09 Thread Erik Joelsson
Hello, The docs bundle is missing some of the legal notices from the jdk.javadoc module. It should just include all the legal files from that module. This patch removes the explicit list and uses wildcard to get all the files instead. Bug: https://bugs.openjdk.java.net/browse/JDK-8206323 We

Re: generated sources and make

2018-07-09 Thread Maurizio Cimadamore
On 09/07/18 16:43, Erik Joelsson wrote: Hello, I would not like to change the behavior of the existing macro since that will have complications for many parts of the build. We could perhaps extend it into a special version for the intellij generator script. It would be possible to figure o

Re: generated sources and make

2018-07-09 Thread Erik Joelsson
Hello, I would not like to change the behavior of the existing macro since that will have complications for many parts of the build. We could perhaps extend it into a special version for the intellij generator script. It would be possible to figure out which modules have gensrc dirs by lookin

Re: [OpenJDK 2D-Dev] RFR: 8206106: [solaris sparc] jck tests api/javax_print/PrintService failing

2018-07-09 Thread Volker Simonis
Looks good! Thanks, Volker On Fri, Jul 6, 2018 at 7:06 PM, Phil Race wrote: > Updated suggested fix : > > --- a/src/java.desktop/unix/native/common/awt/CUPSfuncs.c > +++ b/src/java.desktop/unix/native/common/awt/CUPSfuncs.c > @@ -29,6 +29,16 @@ > #include > #include > #include > +/* > + *

generated sources and make

2018-07-09 Thread Maurizio Cimadamore
Hi, I was playing with the script for IntelliJ project generation, and I noted that make does not report generated source roots (e.g. those under support/gensrc) _unless_ such folders exist in the file system. This is a bit of a let down - normally one would create the IJ project on an empty