Re: [12] RFR(XS) 8208463: jdk.internal.vm.compiler's module-info.java.extra contains duplicated provides of the same service interface

2018-08-13 Thread Vladimir Kozlov
Thank you, Mandy Vladimir On 8/13/18 8:00 PM, mandy chung wrote: Hi Vladimir, This looks good.  I verified with my patch that enforces non-duplicate provides check and it builds successfully.  Thanks for fixing it. thanks Mandy On 8/13/18 5:06 PM, Vladimir Kozlov wrote: https://bugs.openjdk

Re: [12] RFR(XS) 8208463: jdk.internal.vm.compiler's module-info.java.extra contains duplicated provides of the same service interface

2018-08-13 Thread mandy chung
Hi Vladimir, This looks good. I verified with my patch that enforces non-duplicate provides check and it builds successfully. Thanks for fixing it. thanks Mandy On 8/13/18 5:06 PM, Vladimir Kozlov wrote: https://bugs.openjdk.java.net/browse/JDK-8208463 Before we did not care how module-info

[12] RFR(XS) 8208463: jdk.internal.vm.compiler's module-info.java.extra contains duplicated provides of the same service interface

2018-08-13 Thread Vladimir Kozlov
https://bugs.openjdk.java.net/browse/JDK-8208463 Before we did not care how module-info.java.extra is generated. The code in Gensrc-jdk.internal.vm.compiler.gmk make file simple ordered 'providers' files (which are packages names) by name and then use their contents to generate 'provides' inst

Re: RFR (S) 8208665: Amend cross-compilation docs with qemu-debootstrap recipe

2018-08-13 Thread Aleksey Shipilev
On 08/13/2018 05:16 PM, Martin Buchholz wrote: > Aleksey, your use of "base" platform seems a bit unusual.  Elsewhere in the > same document, it's > referred to as "build".  Otherwise looks good (thanks for documenting). Right. Got mixed up with Debian's "base system". Fixed here: http://cr.open

Re: RFR (S) 8208665: Amend cross-compilation docs with qemu-debootstrap recipe

2018-08-13 Thread Martin Buchholz
Aleksey, your use of "base" platform seems a bit unusual. Elsewhere in the same document, it's referred to as "build". Otherwise looks good (thanks for documenting). On Mon, Aug 13, 2018 at 3:26 AM, Aleksey Shipilev wrote: > RFE: > https://bugs.openjdk.java.net/browse/JDK-8208665 > > Webrev:

RE: [RFR]: 8209115: adjust libsplashscreen linux ppc64le builds for easier libpng update - was : RE: RFR 8195615 : libsplashscreen linux ppc64le build error after libpng update

2018-08-13 Thread Baesken, Matthias
Thanks for the review! > -Original Message- > From: David Holmes > Sent: Montag, 13. August 2018 09:00 > To: Baesken, Matthias ; Phil Race > > Cc: [email protected]; '[email protected]' [email protected]> > Subject: Re: [RFR]: 8209115: adjust libsplashscreen linux pp

RFR (S) 8208665: Amend cross-compilation docs with qemu-debootstrap recipe

2018-08-13 Thread Aleksey Shipilev
RFE: https://bugs.openjdk.java.net/browse/JDK-8208665 Webrev: http://cr.openjdk.java.net/~shade/8208665/webrev.02/ Not sure if building.html is supposed to be generated automatically? This is the recipe I have been using for creating artifacts on my personal CI server [1], and it seems to w

Re: [RFR]: 8209115: adjust libsplashscreen linux ppc64le builds for easier libpng update - was : RE: RFR 8195615 : libsplashscreen linux ppc64le build error after libpng update

2018-08-13 Thread David Holmes
Hi Matthias, On 13/08/2018 4:41 PM, Baesken, Matthias wrote: Thank‘s ! Can I have a second review please ? As the build team seem to be on vacation right now I can add that second Review. :) Cheers, David Best regards, Matthias From: Phil Race Sent: Freitag, 10. August 2018 20:12 To: B