Re: [Newbie question] Strange errors trying to build the JDK

Interesting - there is no actual error report in the log. Only this: lib/JvmMapfile.gmk:141: recipe for target '/home/zambonifofex/jdk/build/linux-x86_64-normal-server-release/hotspot/variant-server/libjvm/symbols-objects' failed Looking at the gmk file we have: $(JVM_OUTPUTDIR)/symbols-obje

Re: RFR(M/L) : 8209611 : use C++ compiler for hotspot tests

Hi David, thanks for looking at the webrev and all your comments. my answers are inlined. enjoy your vacation! -- Igor > On Aug 21, 2018, at 9:28 PM, David Holmes wrote: > > Hi Igor, > > On 22/08/2018 9:04 AM, Igor Ignatyev wrote: >> http://cr.openjdk.java.net/~iignatyev//8209611/webrev.02/

Re: RFR(M/L) : 8209611 : use C++ compiler for hotspot tests

Hi Igor, On 22/08/2018 9:04 AM, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8209611/webrev.02/index.html  is a new version of patch, which moves only vmTestbase tests. This seems okay in principle. I didn't

Re: Internal error: Invalid feature tested: fprof

Hi Petr, On 22/08/2018 12:03 AM, Petr Sumbera wrote: Hi, I'm building JDK 10 for Solaris and I'm getting following error: gmake[4]: Leaving directory '/builds/psumbera/userland-openjdk/components/openjdk-10/hotspot/make' lib/JvmFeatures.gmk:91: *** Internal error: Invalid feature tested: fpr

Re: [Newbie question] Strange errors trying to build the JDK

I am not sure if this is documented anywhere. Try searching for "Error 2". It usually will tell you where the error is. Thanks - Ioi On 8/21/18 4:51 PM, Gustavo Romero wrote: Hi, On 08/21/2018 08:00 PM, David Holmes wrote: Hi, You need to search further up the build log to try and find the

Re: [Newbie question] Strange errors trying to build the JDK

Hi, On 08/21/2018 08:00 PM, David Holmes wrote: Hi, You need to search further up the build log to try and find the actual error that occurred when building hotspot. Run "make hotspot" and it should be easier to see. In addition to David's suggestion you can also add before the command LOG

Re: RFR(M/L) : 8209611 : use C++ compiler for hotspot tests

http://cr.openjdk.java.net/~iignatyev//8209611/webrev.02/index.html is a new version of patch, which moves only vmTestbase tests. Thanks, -- Igor > On Aug 20, 2018, at 11:07 PM, Igor Ignatyev wrote: > >>> It has been discu

Re: [Newbie question] Strange errors trying to build the JDK

Hi, You need to search further up the build log to try and find the actual error that occurred when building hotspot. Run "make hotspot" and it should be easier to see. David On 20/08/2018 11:53 AM, Zambonifofex wrote: Hello, everyone. I am new to collaborating to the JDK, so sorry if this

Re: Linux + Clang + execstack

Adding the linker flag sounds good. Opened JDK-8209817. webrev coming soon. On Tue, Aug 21, 2018 at 4:14 AM Magnus Ihse Bursie < magnus.ihse.bur...@oracle.com> wrote: > On 2018-08-21 02:03, David Holmes wrote: > > On 21/08/2018 9:39 AM, Arthur Eubanks wrote: > >> On Mon, Aug 20, 2018 at 4:18 PM

Re: RFR: JDK 11 P1: 8209806: API docs should be updated to refer to javase11

Jon: Looks good to me as well. Tim On 08/21/18 12:00, Lance Andersen wrote: looks fine Jon On Aug 21, 2018, at 2:58 PM, Jonathan Gibbons wrote: Please review a simple high priority fix for JDK 11 that updates the link in the bottom of each page of the generated API docs. Instead of simp

Re: RFR: JDK 11 P1: 8209806: API docs should be updated to refer to javase11

looks fine Jon > On Aug 21, 2018, at 2:58 PM, Jonathan Gibbons > wrote: > > Please review a simple high priority fix for JDK 11 that updates the link in > the bottom of each page of the generated API docs. > > Instead of simply changing "10" to "11", the fix is to use the macro > $(VERSION_NU

RE: RFR: JDK 11 P1: 8209806: API docs should be updated to refer to javase11

Looks good to me. iris -Original Message- From: Jonathan Gibbons Sent: Tuesday, August 21, 2018 11:58 AM To: build-dev@openjdk.java.net Subject: RFR: JDK 11 P1: 8209806: API docs should be updated to refer to javase11 Please review a simple high priority fix for JDK 11 that updates the

Re: RFR: JDK 11 P1: 8209806: API docs should be updated to refer to javase11

+1 -Joe On 8/21/2018 11:58 AM, Jonathan Gibbons wrote: Please review a simple high priority fix for JDK 11 that updates the link in the bottom of each page of the generated API docs. Instead of simply changing "10" to "11", the fix is to use the macro $(VERSION_NUMBER) instead, in line with

RFR: JDK 11 P1: 8209806: API docs should be updated to refer to javase11

Please review a simple high priority fix for JDK 11 that updates the link in the bottom of each page of the generated API docs. Instead of simply changing "10" to "11", the fix is to use the macro $(VERSION_NUMBER) instead, in line with other URLs nearby in the same makefile, and in the ExtLin

Re: RFR 8208183: update HSDIS plugin license to UPL

2018/8/21 11:11:00 -0700, john.r.r...@oracle.com: > On Aug 21, 2018, at 9:41 AM, Andrew Haley wrote: >> On 08/21/2018 11:14 AM, Magnus Ihse Bursie wrote: >>> Am I correct in understanding that there are no more legal barriers >>> towards doing such a thing anymore? >> >> You'd still be linking G

Re: RFR 8208183: update HSDIS plugin license to UPL

On Aug 21, 2018, at 9:41 AM, Andrew Haley wrote: > > On 08/21/2018 11:14 AM, Magnus Ihse Bursie wrote: >> Am I correct in understanding that there are no more legal barriers >> towards doing such a thing anymore? > > You'd still be linking GPLv2-only code (libjvm) against GPLv3-or-later > code

Re: Internal error: Invalid feature tested: fprof

What version of bash and Gnu make do you have? What is your configure command line? /Magnus > 21 aug. 2018 kl. 16:03 skrev Petr Sumbera : > > Hi, > > I'm building JDK 10 for Solaris and I'm getting following error: > > gmake[4]: Leaving directory > '/builds/psumbera/userland-openjdk/componen

Re: RFR 8208183: update HSDIS plugin license to UPL

On 08/21/2018 11:14 AM, Magnus Ihse Bursie wrote: > Am I correct in understanding that there are no more legal barriers > towards doing such a thing anymore? You'd still be linking GPLv2-only code (libjvm) against GPLv3-or-later code (binutils). IANAL, but I suspect you can't get around the GPLv

[Newbie question] Strange errors trying to build the JDK

Hello, everyone. I am new to collaborating to the JDK, so sorry if this question is too newbie‐ish. I have recently been affected by a minor bug in the ‘java.desktop’ module on Linux. I figured I’d try to fix it by myself, so I followed the steps in the “How to Contribute” page, the “Building” pa

Re: RFR 8208183: update HSDIS plugin license to UPL

On Tue, Aug 21, 2018 at 12:14 PM, Magnus Ihse Bursie wrote: > >> Yes, please. And it would be absolutely fantastic to actually build it and >> ship it in default >> OpenJDK images :) > > > Am I correct in understanding that there are no more legal barriers towards > doing such a thing anymore? > >

Internal error: Invalid feature tested: fprof

Hi, I'm building JDK 10 for Solaris and I'm getting following error: gmake[4]: Leaving directory '/builds/psumbera/userland-openjdk/components/openjdk-10/hotspot/make' lib/JvmFeatures.gmk:91: *** Internal error: Invalid feature tested: fprof. Stop. gmake[3]: *** [make/Main.gmk:263: hotspot-s

Re: Linux + Clang + execstack

On 2018-08-21 02:03, David Holmes wrote: On 21/08/2018 9:39 AM, Arthur Eubanks wrote: On Mon, Aug 20, 2018 at 4:18 PM David Holmes > wrote:     Hi Arthur,     cc'ing build-dev as this is currently a build issue.     On 21/08/2018 3:11 AM, Arthur Eubanks wrote:

Where to find the 3rd party libraries used by --with-graalunit-lib

Hi, all, To run Graal unit test included in OpenJDK's jtreg tests, I need to add "-with-graalunit-lib" to specify the graalunit-lib path. But I can't find where I can get such libs. Could you point me to where or how to get them? Thanks! -- Best regards, Zhongwei

Re: RFR 8208183: update HSDIS plugin license to UPL

On 08/21/2018 12:14 PM, Magnus Ihse Bursie wrote: >> Yes, please. And it would be absolutely fantastic to actually build it and >> ship it in default >> OpenJDK images :) > > Am I correct in understanding that there are no more legal barriers towards > doing such a thing anymore? > > I can easi

Re: RFR 8208183: update HSDIS plugin license to UPL

On 2018-08-21 12:14, Magnus Ihse Bursie wrote: Yes, please. And it would be absolutely fantastic to actually build it and ship it in default OpenJDK images :) Am I correct in understanding that there are no more legal barriers towards doing such a thing anymore? I can easily add a new

Re: RFR 8208183: update HSDIS plugin license to UPL

Yes, please. And it would be absolutely fantastic to actually build it and ship it in default OpenJDK images :) Am I correct in understanding that there are no more legal barriers towards doing such a thing anymore? I can easily add a new make target to build hsdis. Adding a new binary t

Re: RFR 8208183: update HSDIS plugin license to UPL

On 08/21/2018 11:58 AM, Magnus Ihse Bursie wrote: > Now that hsdis has a more permissive license, would it make sense to include > the build of hsdis in > the rest of the OpenJDK build system, instead of having a separate Makefile? Yes, please. And it would be absolutely fantastic to actually bui

Re: RFR 8208183: update HSDIS plugin license to UPL

Now that hsdis has a more permissive license, would it make sense to include the build of hsdis in the rest of the OpenJDK build system, instead of having a separate Makefile? /Magnus On 2018-07-25 14:59, David Buck wrote: Hi! Please approve this license change for the HSDIS plugin source co

Re: RFR 8209064: Make intellij support more robust after changes for 2018.2

Hi Maurizio! Even if this only incidentally relates to the build, please always include build-dev when making changes in the "make" directory. As far as I can understand, your changes looks good. One question: the build.xml was previously stored as a "template", and copied to the output dire