Re: defpath extension won't work with jdk/submit

Adding the push path manually to hgrc works fine, so I use that as a workaround. Thanks, Thomas On Wed, Aug 29, 2018 at 8:01 AM, Thomas Stüfe wrote: > Thank you Tim. Happy to know it is not my setup. Lets see what ops says. > > Best, Thomas > > On Wed, Aug 29, 2018 at 1:58 AM, Tim Bell wrote: >

Re: defpath extension won't work with jdk/submit

Thank you Tim. Happy to know it is not my setup. Lets see what ops says. Best, Thomas On Wed, Aug 29, 2018 at 1:58 AM, Tim Bell wrote: > Thomas: > >> when trying to run hg defpath to set the paths to the jdk12 submit >> repo (http://hg.openjdk.java.net/jdk/submit), it fails: >> >> thomas@t450:/s

Re: RFR: JDK-8202951: Implementation of JEPJDK-8204247: Include default CDS (Class Data Sharing) archive in JDK binary

Looks good. Thanks! - Ioi On 8/28/18 6:32 PM, Jiangli Zhou wrote: Here is the updated webre with CheckDefaultArchiveFile.java changes.   http://cr.openjdk.java.net/~jiangli/8202951/webrev.01/ Thanks, Jiangli On 8/28/18 11:09 AM, Jiangli Zhou wrote: On 8/28/18 9:33 AM, Ioi Lam wrote: The J

Re: RFR: JDK-8202951: Implementation of JEPJDK-8204247: Include default CDS (Class Data Sharing) archive in JDK binary

Here is the updated webre with CheckDefaultArchiveFile.java changes.   http://cr.openjdk.java.net/~jiangli/8202951/webrev.01/ Thanks, Jiangli On 8/28/18 11:09 AM, Jiangli Zhou wrote: On 8/28/18 9:33 AM, Ioi Lam wrote: The JVM and test changes look good. I just have one comment: CheckDefault

Re: defpath extension won't work with jdk/submit

Thomas: when trying to run hg defpath to set the paths to the jdk12 submit repo (http://hg.openjdk.java.net/jdk/submit), it fails: thomas@t450:/shared/projects/openjdk/jdk-submit/source$ hg defpath -du stuefe abort: http://hg.openjdk.java.net/jdk/submit: Repository not found No hgrc files updat

Re: RFR: JDK-8202951: Implementation of JEPJDK-8204247: Include default CDS (Class Data Sharing) archive in JDK binary

On 8/28/18 9:33 AM, Ioi Lam wrote: The JVM and test changes look good. I just have one comment: CheckDefaultArchiveFile.java   51  if (!Platform.isDefaultCDSArchiveSupported()) {   52 if (Files.notExists(jsa)) {   53 System.out.println("Passed. " + vmString +  

defpath extension won't work with jdk/submit

Hi all, when trying to run hg defpath to set the paths to the jdk12 submit repo (http://hg.openjdk.java.net/jdk/submit), it fails: thomas@t450:/shared/projects/openjdk/jdk-submit/source$ hg defpath -du stuefe abort: http://hg.openjdk.java.net/jdk/submit: Repository not found No hgrc files updated

Re: RFR: JDK-8202951: Implementation of JEPJDK-8204247: Include default CDS (Class Data Sharing) archive in JDK binary

Thanks, Erik! Jiangli On 8/28/18 9:25 AM, Erik Joelsson wrote: Build changes look good to me (but should probably get review from someone else). /Erik On 2018-08-27 13:33, Jiangli Zhou wrote: Please review the implementation for JEP JDK-8204247 (https://bugs.openjdk.java.net/browse/JDK-82

Re: RFR(M/L) : 8209611 : use C++ compiler for hotspot tests

http://cr.openjdk.java.net/~iignatyev//8209611/webrev.02/index.html Reviewed. Best regards, Vladimir Ivanov On Aug 20, 2018, at 11:07 PM, Igor Ignatyev wrote: It has been discussed (not widely enough and I accept that) in 8209547 and the related email thread b/w JC(cc'ed) and myself. as

Re: RFR: JDK-8202951: Implementation of JEPJDK-8204247: Include default CDS (Class Data Sharing) archive in JDK binary

The JVM and test changes look good. I just have one comment: CheckDefaultArchiveFile.java   51  if (!Platform.isDefaultCDSArchiveSupported()) {   52 if (Files.notExists(jsa)) {   53 System.out.println("Passed. " + vmString +   54  

Re: RFR: JDK-8202951: Implementation of JEPJDK-8204247: Include default CDS (Class Data Sharing) archive in JDK binary

Build changes look good to me (but should probably get review from someone else). /Erik On 2018-08-27 13:33, Jiangli Zhou wrote: Please review the implementation for JEP JDK-8204247 (https://bugs.openjdk.java.net/browse/JDK-8204247). The goal of the JEP is to include a default CDS archive in

Re: RFR 8209064: Make intellij support more robust after changes for 2018.2

Looks ok to me. /Erik On 2018-08-27 07:07, Maurizio Cimadamore wrote: As I was about to push this, I realize there was a minor nit with the way in which build.xml files found some classes inside the generated .idea folder - that is, the path to this folder was defined in a relative way from

Re: RFR(M/L) : 8209611 : use C++ compiler for hotspot tests

Hi Erik, thanks for your review! -- Igor > On Aug 28, 2018, at 9:01 AM, Erik Joelsson wrote: > > Hello, > > I have nothing to add in addition to Magnus' comments. If that is fixed, this > looks good from a build point of view. > > /Erik > > > On 2018-08-28 07:51, Igor Ignatyev wrote: >> H

Re: RFR(M/L) : 8209611 : use C++ compiler for hotspot tests

Hello, I have nothing to add in addition to Magnus' comments. If that is fixed, this looks good from a build point of view. /Erik On 2018-08-28 07:51, Igor Ignatyev wrote: Hi Magnus, thanks for reviewing this. please see my answers inline. Cheers, -- Igor On Aug 28, 2018, at 4:14 AM, M

Re: RFR(M/L) : 8209611 : use C++ compiler for hotspot tests

Hi Magnus, thanks for reviewing this. please see my answers inline. Cheers, -- Igor > On Aug 28, 2018, at 4:14 AM, Magnus Ihse Bursie > wrote: > > Hi Igor, > > Sorry for my late arrival to this discussion. > > I tried to figure out what the latest version of your patch is. My guess is > t

Re: RFR(M/L) : 8209611 : use C++ compiler for hotspot tests

Hi Igor, Sorry for my late arrival to this discussion. I tried to figure out what the latest version of your patch is. My guess is that it is http://cr.openjdk.java.net/~iignatyev//8209611/webrev.02/ + the inlined patch from this mail? In JtregNativeHotspot.gmk, you are removing: ifeq ($(TOO