Re: 8209520: Build fails when native code coverage is enabled

Hi Thanks for background. Assuming these or similar issues were already discussed and it was decided to ignore warnings for code coverage builds I think it is fine to fix build. Current warnings don't look as real issues for me also. I moved components alias as bcc since now it is build-only c

Re: RFR: JDK-8202951: Implementation of JEPJDK-8204247: Include default CDS (Class Data Sharing) archive in JDK binary

Hi Erik and Magnus, I updated Images.gmk accordingly. Magnus, thanks for reviewing! http://cr.openjdk.java.net/~jiangli/8202951/webrev.02/make/Images.gmk.frames.html Complete webrev: http://cr.openjdk.java.net/~jiangli/8202951/webrev.02/ Please see comments below. On 8/29/18 8:45 AM, Erik Joe

Re: RFR: JDK-8210160 Remove deprecated configure arguments

Looks good. Thanks for taking care of this overdue cleanup! /Erik On 2018-08-29 05:20, Magnus Ihse Bursie wrote: The original intention with the BASIC_DEPRECATED_ARG_WITH/ENABLE function was to keep accepting the argument (so as not to break any scripts), but print a warning, and to do so for

Re: RFR: JDK-8210150 Allow custom-hook.m4 to include files from CUSTOM_CONFIG_DIR

Looks good. /Erik On 2018-08-29 04:58, Magnus Ihse Bursie wrote: This change in the "configure" script is needed for the custom-hook.m4 to be able to include additional files from the CUSTOM_CONFIG_DIR. Bug: https://bugs.openjdk.java.net/browse/JDK-8210150 WebRev: http://cr.openjdk.java.net

Re: RFR: JDK-8202951: Implementation of JEPJDK-8204247: Include default CDS (Class Data Sharing) archive in JDK binary

Hello Magnus, As the author of the build changes I will answer this. On 2018-08-29 04:53, Magnus Ihse Bursie wrote: On 2018-08-28 18:25, Erik Joelsson wrote: Build changes look good to me (but should probably get review from someone else). I'm (as usually) not as happy as Erik. ;-) In Image

Re: RFR (8u): 8209002: 8u192 installed exe and dll files have wrong file version

Looks good to me. /Erik On 2018-08-29 05:29, Kevin Walls wrote: Hi, I'd like to get a review of: 8209002: 8u192 installed exe and dll files have wrong file version https://bugs.openjdk.java.net/browse/JDK-8209002 Previous changes have changed the versions used by RC_FLAGS which changes the

RFR (8u): 8209002: 8u192 installed exe and dll files have wrong file version

Hi, I'd like to get a review of: 8209002: 8u192 installed exe and dll files have wrong file version https://bugs.openjdk.java.net/browse/JDK-8209002 Previous changes have changed the versions used by RC_FLAGS which changes the versions appearing in Windows binaries. Diff below, tests well fo

RFR: JDK-8210160 Remove deprecated configure arguments

The original intention with the BASIC_DEPRECATED_ARG_WITH/ENABLE function was to keep accepting the argument (so as not to break any scripts), but print a warning, and to do so for at least a whole release. We've been bad at actually removing these options, however. This fix removes all calls

RFR: JDK-8210150 Allow custom-hook.m4 to include files from CUSTOM_CONFIG_DIR

This change in the "configure" script is needed for the custom-hook.m4 to be able to include additional files from the CUSTOM_CONFIG_DIR. Bug: https://bugs.openjdk.java.net/browse/JDK-8210150 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8210150-split-up-custom-hook-m4-open/webrev.01 /Magnus

Re: RFR: JDK-8202951: Implementation of JEPJDK-8204247: Include default CDS (Class Data Sharing) archive in JDK binary

On 2018-08-28 18:25, Erik Joelsson wrote: Build changes look good to me (but should probably get review from someone else). I'm (as usually) not as happy as Erik. ;-) In Images.gmk, you have added this rule:   $@ -Xshare:dump -Xmx128M -Xms128M $(LOG_INFO) It took me a while to grasp.