Re: Solaris sparc build issue with OpenJDK 11(+28): /usr/gnu/bin/nm: jvmciCompilerToVMInit.o: Bad value

2018-09-06 Thread David Holmes
Hi Petr, On 7/09/2018 4:28 AM, Petr Sumbera wrote: Hi, I'm seeing this with sparc build (on Solaris trunk). On intel it builds just fine. gmake[4]: Entering directory '/builds2/psumbera/userland-openjdk/components/openjdk-11/jdk-11-76072a077ee1/make/gensrc' Compiling 89 properties into

Re: RFR: 8210425: [x86] sharedRuntimeTrig/sharedRuntimeTrans compiled without optimization

2018-09-06 Thread David Holmes
On 7/09/2018 12:32 AM, Severin Gehwolf wrote: Hi, On Thu, 2018-09-06 at 07:29 +1000, David Holmes wrote: Hi Severin, On 6/09/2018 4:36 AM, Severin Gehwolf wrote: Hi, On Linux x86 (32 and 64 bit) sharedRuntime{Trans,Trig}.ccp files get compiled with -O0. It appears to be for the same

Re: RFR: JDK-8202951: Implementation of JEPJDK-8204247: Include default CDS (Class Data Sharing) archive in JDK binary

2018-09-06 Thread Jiangli Zhou
Hi, The JEP (http://openjdk.java.net/jeps/341) for the default CDS archives is now a candidate. Please see Mark's email, 'New candidate JEP: 341: Default CDS Archives'. Please help test Erik's makefile patch for your platform if it is not built/tested in openjdk mainline to prevent any

Status of unshuffle

2018-09-06 Thread Martin Buchholz
The unshuffle infrastructure in ./bin/unshuffle_patch.sh ./bin/unshuffle_list.txt is highly version specific, and has naturally bitrotted. Maybe it should simply be removed from openjdk-current. Maybe a more flexible version of unshuffle could be built that would work for any source and dest

Re: RFR: 8210416: [linux] Poor StrictMath performance due to non-optimized compilation

2018-09-06 Thread Erik Joelsson
On 2018-09-06 10:29, Severin Gehwolf wrote: On Thu, 2018-09-06 at 09:55 -0700, Erik Joelsson wrote: Thanks, Erik. GCC supports -ffp-contract since 4.6. Clang has -ffp- contract too. Question is beginning from which version. That's why I'd expect for those flags to work on linux. Is there

Re: RFR: 8210416: [linux] Poor StrictMath performance due to non-optimized compilation

2018-09-06 Thread Severin Gehwolf
On Thu, 2018-09-06 at 09:55 -0700, Erik Joelsson wrote: > On 2018-09-06 03:12, Severin Gehwolf wrote: > > Hi David, > > > > On Thu, 2018-09-06 at 07:32 +1000, David Holmes wrote: > > > Hi Severin, > > > > > > Might as well raise this here too as it's really a build philosophy > > > issue.

Re: RFR: 8210416: [linux] Poor StrictMath performance due to non-optimized compilation

2018-09-06 Thread Erik Joelsson
On 2018-09-06 03:12, Severin Gehwolf wrote: Hi David, On Thu, 2018-09-06 at 07:32 +1000, David Holmes wrote: Hi Severin, Might as well raise this here too as it's really a build philosophy issue. Shouldn't flags like -ffp-contract=off (and the existing AIX -qfloat=nomaf) be toolchain

Re: RFR : [XS] 8209942: [epsilon] range function for EpsilonTLABElasticity causes compiler warning

2018-09-06 Thread Baesken, Matthias
Hi Erik, looks like gcc7 and current clang already print the macro and show it plus the position of the error / warning in it . See https://clang.llvm.org/diagnostics.html Automatic Macro Expansion for an example . With Visual Studio I could not find anything similar

Re: RFR: 8210425: [x86] sharedRuntimeTrig/sharedRuntimeTrans compiled without optimization

2018-09-06 Thread Severin Gehwolf
Hi, On Thu, 2018-09-06 at 07:29 +1000, David Holmes wrote: > Hi Severin, > > On 6/09/2018 4:36 AM, Severin Gehwolf wrote: > > Hi, > > > > On Linux x86 (32 and 64 bit) sharedRuntime{Trans,Trig}.ccp files get > > compiled with -O0. It appears to be for the same (historical?) reason > > as for

RE: [OpenJDK 2D-Dev] RFR JDK-8209786: gcc 7.3 compiler errors on zLinux

2018-09-06 Thread Lindenmaier, Goetz
Yes, that's fine. I can sponsor it tomorrow. I'm not in the office today. Best regards, Goetz. > -Original Message- > From: Andrew Leonard > Sent: Donnerstag, 6. September 2018 12:29 > To: Magnus Ihse Bursie ; Lindenmaier, Goetz > > Cc: 2d-dev <2d-...@openjdk.java.net>; Brian

Re: [OpenJDK 2D-Dev] RFR JDK-8209786: gcc 7.3 compiler errors on zLinux

2018-09-06 Thread Andrew Leonard
Thanks Magnus, Hi Goetz, we have agreement from both library owners, so I think we're good now? Thanks Andrew Andrew Leonard Java Runtimes Development IBM Hursley IBM United Kingdom Ltd Phone internal: 245913, external: 01962 815913 internet email: andrew_m_leon...@uk.ibm.com From:

Re: RFR: 8210416: [linux] Poor StrictMath performance due to non-optimized compilation

2018-09-06 Thread Severin Gehwolf
Hi Joe, On Wed, 2018-09-05 at 12:15 -0700, joe darcy wrote: > On 9/5/2018 6:12 AM, Severin Gehwolf wrote: > > Hi, > > > > Cross-posting this review-thread on core-libs-dev and build-dev as > > this > > is a build change, but affects fdlibm which is core-libs. > > > > With JDK-8170153

Re: RFR: 8210416: [linux] Poor StrictMath performance due to non-optimized compilation

2018-09-06 Thread Severin Gehwolf
Hi David, On Thu, 2018-09-06 at 07:32 +1000, David Holmes wrote: > Hi Severin, > > Might as well raise this here too as it's really a build philosophy > issue. Shouldn't flags like -ffp-contract=off (and the existing AIX > -qfloat=nomaf) be toolchain specific rather than platform specific?

Request for approval: 8210423: Backport of 8034788 breaks GCC version detection

2018-09-06 Thread Andrew Haley
The JDK8u backport of 8034788 changed the variable name CXX_VERSION (in configure) to CXX_VERSION_NUMBER. Unfortunately this was not done consistently, and as a result the version number check for GCC is broken. As a result of that brokenness, HotSpot built on all GCC versions >=6 is unstable.