Hi Dimitry,
Thanks for your kind response!
Thanks for the commit message of Jung's patch, I found that the bug had
been fixed in OpenJDK 12 by Zhengyu
https://bugs.openjdk.java.net/browse/JDK-8205965 But only backported to
11. So Jung could backport it for OpenJDK 8, thanks a lot!
But I
When I added support for git as SCM in the build, I forgot to update the
test that verifies the release file contents. This patch updates the
test to also look for hg/git in the SOURCE strings. While there I also
made the test more strict on the format and less strict when run against
non
Looks good.
/Erik
On 2018-09-10 14:34, Naoto Sato wrote:
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8209167
The proposed changeset is located at:
http://cr.openjdk.java.net/~naoto/8209167/webrev.01/
This fix is to remove the hand crafted
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8209167
The proposed changeset is located at:
http://cr.openjdk.java.net/~naoto/8209167/webrev.01/
This fix is to remove the hand crafted map file (lib/tzmappings) on
Windows, which maps Windows
On 09/10/2018 02:15 PM, Gustavo Romero wrote:
> Hi Severin,
>
> On 09/10/2018 06:27 AM, Severin Gehwolf wrote:
>> On Mon, 2018-09-10 at 10:05 +0100, Andrew Haley wrote:
>>> On 09/05/2018 02:12 PM, Severin Gehwolf wrote:
Is there a good
reason to not use -O3 -ffp-contract=off everywhere?
On Wed, 5 Sep 2018 at 10:52, Leslie Zhai wrote:
>
> Hi Andrew,
>
> Thanks for your response!
>
> I just quote it from here:
>
> http://mail.openjdk.java.net/pipermail/build-dev/2016-July/017464.html
>
> I spotted that jsig is just a single C file and so doesn't
> need the -std flag. In fact, it
Hello Robin,
Overall very nice work. A few things though:
The output dir compile_commands should use a dash instead to fit with
current patterns. That way the clean target will also be all dashes.
Main.gmk:888: I think you meant to add test-compile-commands here, which
also requires you to
I've filed JDK-8210551.
/Erik
On 2018-09-10 09:29, Erik Joelsson wrote:
I see. I was not aware of that issue, but we clearly need to file a
bug for it and fix it. In this case I think it's fine to us the macro
however.
/Erik
On 2018-09-10 03:29, Severin Gehwolf wrote:
Hi Erik,
On Fri,
I see. I was not aware of that issue, but we clearly need to file a bug
for it and fix it. In this case I think it's fine to us the macro however.
/Erik
On 2018-09-10 03:29, Severin Gehwolf wrote:
Hi Erik,
On Fri, 2018-09-07 at 10:19 -0700, Erik Joelsson wrote:
Instead of checking for
Hi all,
OpenJDK8 jdk8u-dev[1] is just able to work after compiled with LLVM
3.9.1 for X86:
$
./build/linux-x86_64-normal-server-slowdebug/images/j2sdk-image/bin/java
-version
openjdk version "1.8.0-internal-debug"
OpenJDK Runtime Environment (build
Looks good.
/Erik
On 2018-09-10 01:10, Magnus Ihse Bursie wrote:
On 2018-09-05 15:26, Alan Bateman wrote:
On 05/09/2018 13:58, Magnus Ihse Bursie wrote:
The file sdp.conf.template is copied only when building for solaris,
but it resides in the unix source directory.
SDP is legacy now and
Hello,
On 2018-09-10 01:27, Magnus Ihse Bursie wrote:
On 2018-09-07 19:30, Erik Joelsson wrote:
Hello again,
Resurrecting this review. It is now part of proposed JEP and some
details have changed. The alternate jvm variant is now called
"nonspeculative", and so is activated with the
Hi all,
Please review the following change that adds support for generating
compile_commands.json as a top-level make target. This is a popular format for
describing how to compile object files for a project, and is defined in [1].
This file can be used directly by IDEs such as Visual Studio
Hi Gustavo,
On Mon, 2018-09-10 at 10:15 -0300, Gustavo Romero wrote:
> Hi Severin,
>
> On 09/10/2018 06:27 AM, Severin Gehwolf wrote:
> > On Mon, 2018-09-10 at 10:05 +0100, Andrew Haley wrote:
> > > On 09/05/2018 02:12 PM, Severin Gehwolf wrote:
> > > > Is there a good
> > > > reason to not use
Hi Severin,
On 09/10/2018 06:27 AM, Severin Gehwolf wrote:
On Mon, 2018-09-10 at 10:05 +0100, Andrew Haley wrote:
On 09/05/2018 02:12 PM, Severin Gehwolf wrote:
Is there a good
reason to not use -O3 -ffp-contract=off everywhere?
Is there a good reason to use -O3 rather than -O2?
Not sure.
Hi Andrew,
On Mon, 2018-09-10 at 10:05 +0100, Andrew Haley wrote:
> On 09/05/2018 02:12 PM, Severin Gehwolf wrote:
> > Is there a good
> > reason to not use -O3 -ffp-contract=off everywhere?
>
> Is there a good reason to use -O3 rather than -O2? -O3 can bloat the
> code which can increase cache
On Fri, 2018-09-07 at 10:19 -0700, Erik Joelsson wrote:
> On 2018-09-07 09:56, Severin Gehwolf wrote:
> > On Fri, 2018-09-07 at 09:12 -0700, Erik Joelsson wrote:
> > > To me it sounds like we want this flag if the toolchain is either gcc or
> > > clang, so please make it conditional on that.
> >
On 10/09/2018 09:10, Magnus Ihse Bursie wrote:
:
Updated patch, which copies the SDP template for linux too:
diff --git a/make/copy/Copy-java.base.gmk b/make/copy/Copy-java.base.gmk
--- a/make/copy/Copy-java.base.gmk
+++ b/make/copy/Copy-java.base.gmk
@@ -183,7 +183,7 @@
TARGETS +=
Hi Erik,
On Fri, 2018-09-07 at 10:19 -0700, Erik Joelsson wrote:
> Instead of checking for compiler version, you could simply use the
> FLAGS_COMPILER_CHECK_ARGUMENTS macro. This would apply to both gcc and
> clang. We usually prefer this over version checks (unless a version is
> just known
On Mon, 2018-09-10 at 10:05 +0100, Andrew Haley wrote:
> On 09/05/2018 02:12 PM, Severin Gehwolf wrote:
> > Is there a good
> > reason to not use -O3 -ffp-contract=off everywhere?
>
> Is there a good reason to use -O3 rather than -O2?
Not sure. I was following what JDK-8170153 did, which was
On 09/05/2018 02:12 PM, Severin Gehwolf wrote:
> Is there a good
> reason to not use -O3 -ffp-contract=off everywhere?
Is there a good reason to use -O3 rather than -O2? -O3 can bloat the
code which can increase cache pressure, which is not always noticeable
in benchmarks but hurts real-world
On 2018-09-07 19:30, Erik Joelsson wrote:
Hello again,
Resurrecting this review. It is now part of proposed JEP and some
details have changed. The alternate jvm variant is now called
"nonspeculative", and so is activated with the command line flag
"-nonspeculative". This is all in line
On 2018-09-05 15:26, Alan Bateman wrote:
On 05/09/2018 13:58, Magnus Ihse Bursie wrote:
The file sdp.conf.template is copied only when building for solaris,
but it resides in the unix source directory.
SDP is legacy now and we should probably think about removing it, esp.
with the rsocket
23 matches
Mail list logo
