Re: gcc 7.3.1 build - warnings as errors in harfbuzz

Hi Matthias, I've looked a little at this error and it is quite strange. First of all, I can't reproduce it with a default gcc 7.3.0 and there doesn't exist an official version of gcc 7.3.1 (at least I couldn't find it). Also, I can't see the real error in the objected code. The values the

Re: gcc 7.3.1 build - warnings as errors in harfbuzz

GCC (since some version older than we support now) ignores disabling of unknown warning labels. This is a feature we depend on for these constructs. Without that it wouldn't be possible to list all the labels like this. (We used to check for this feature in GCC in configure and only use the

RE: gcc 7.3.1 build - warnings as errors in harfbuzz

Thanks. I am a bit worried that DISABLED_WARNINGS_gcc := format-truncation DISABLED_WARNINGS_CXX_gcc := format-truncation Could bring errors on older gcc versions , any ideas about this ? (will test with gcc 4.8 of course as well ) Best regards, Matthias > -Original Message- >

Re: gcc 7.3.1 build - warnings as errors in harfbuzz

I think that's fine. This is the granularity we have. /Erik On 2018-10-10 09:02, Baesken, Matthias wrote: Hi Erik, so I think I could disable the warning here : Awt2dLibraries.gmk - $(eval $(call SetupJdkLibrary, BUILD_LIBFONTMANAGER, \ NAME :=

RE: gcc 7.3.1 build - warnings as errors in harfbuzz

Hi Erik, so I think I could disable the warning here : Awt2dLibraries.gmk - $(eval $(call SetupJdkLibrary, BUILD_LIBFONTMANAGER, \ NAME := fontmanager, \ WARNINGS_AS_ERRORS_xlc := false, \ DISABLED_WARNINGS_gcc := format-truncation

Re: RFR: 8212008: Use of TREAT_EXIT_CODE_1_AS_0 hide problems with jtreg Java

Looks good. A side effect of this is that if no tests are found (also returns 1), make will fail. In our CI system, this will be interpreted as NOT_RUN "no tests found", which is actually an improvement from PASSED "total 0, passed 0, failed 0" as it will be more visible. /Erik On

RFR: 8212008: Use of TREAT_EXIT_CODE_1_AS_0 hide problems with jtreg Java

Hi, When running JDK and Hotspot jtreg tests through make, TREAT_EXIT_CODE_1_AS_0 is set to true. Any issue with the Java installation used to run jtreg won’t be reflected in the exit code. This has been seen a bunch of times in our internal CI system where we thought we ran tests but instead

Re: RFR: 8212004: Optional compile_commands.json field not compatible with older libclang

Looks good. /Erik On 2018-10-10 07:02, Robin Westberg wrote: Hi all, Please review this small change to remove the “output” field from the compile_commands.json file generated by “make compile-commands”. As it turns out, this optional field is incompatible with tooling built on libclang

Re: gcc 7.3.1 build - warnings as errors in harfbuzz

In this case, disabling the warning seems like the right thing to do. /Erik On 2018-10-10 06:14, Baesken, Matthias wrote: Hello , when compiling jdk/jdk with gcc 7.3.1on linux x86_64 (or also on linux ppc64) I run into this build error :

RFR: 8212004: Optional compile_commands.json field not compatible with older libclang

Hi all, Please review this small change to remove the “output” field from the compile_commands.json file generated by “make compile-commands”. As it turns out, this optional field is incompatible with tooling built on libclang versions older than 4.0. As this field provides no real benefit for

gcc 7.3.1 build - warnings as errors in harfbuzz

Hello , when compiling jdk/jdk with gcc 7.3.1on linux x86_64 (or also on linux ppc64) I run into this build error : /open_jdk/jdk_just_clone/jdk/src/java.desktop/share/native/libfontmanager/harfbuzz/hb-common.cc: In function 'void hb_variation_to_string(hb_variation_t*, char*,