Re: Stop using precompiled headers for Linux?

Below are the corresponding numbers from a Mac, (Mac Pro (Late 2013), 3.7 GHz, Quad-Core Intel Xeon E5, 16 GB). To be clear, the -npch is without precompiled headers. Here we see a slight degradation when disabling on both user time and wall clock time. My guess is that the user time increase i

Re: Stop using precompiled headers for Linux?

Hello, On 2018-10-30 13:17, Aleksey Shipilev wrote: On 10/30/2018 06:26 PM, Ioi Lam wrote: Is there any advantage of using precompiled headers on Linux? I have measured it recently on shenandoah repositories, and fastdebug/release build times have not improved with or without PCH. Actually, i

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

On 10/30/2018 10:11 AM, Andy Herrick wrote: On 10/24/2018 10:22 AM, Alan Bateman wrote: On 23/10/2018 16:49, Andy Herrick wrote: This patch implements the Java Packager Tool (jpackager) as described in JEP 343: Packaging Tool jpackager

Re: Stop using precompiled headers for Linux?

On 10/30/2018 06:26 PM, Ioi Lam wrote: > Is there any advantage of using precompiled headers on Linux? I have measured it recently on shenandoah repositories, and fastdebug/release build times have not improved with or without PCH. Actually, it gets worse when you touch a single header that is

Re: Stop using precompiled headers for Linux?

Last I checked, it did provide significant build speed improvements when building just hotspot, but that could need revisiting. We do have verification of --disable-precompiled-headers (in slowdebug) in builds-tier2 so we normally get notified if this fails. However, Mach5 has not been running

Re: Stop using precompiled headers for Linux?

It would help already if Oracle would disable precompiled headers for the submit test builds. ..Thomas On Tue, Oct 30, 2018 at 6:26 PM Ioi Lam wrote: > > Is there any advantage of using precompiled headers on Linux? It's on by > default and we keep having breakage where someone would forget to ad

Re: Stop using precompiled headers for Linux?

I'd be in favour of disabling by default. Roman > Is there any advantage of using precompiled headers on Linux? It's on by > default and we keep having breakage where someone would forget to add > #include. The latest instance is JDK-8213148. > > I just turn on precompiled headers explicitly in

Stop using precompiled headers for Linux?

Is there any advantage of using precompiled headers on Linux? It's on by default and we keep having breakage where someone would forget to add #include. The latest instance is JDK-8213148. I just turn on precompiled headers explicitly in all my builds. I don't see any difference in build time

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

inline On 10/30/2018 9:09 AM, Alan Bateman wrote: On 30/10/2018 14:11, Andy Herrick wrote: : If I read the webrev correctly then it adds two modules, one with the jpackager tool and the other with an API. It would be useful to get a bit more information on the split. Also I think the name

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

On 30/10/2018 14:11, Andy Herrick wrote: : What is the status of the JNLPConverter tool? I see it is included as a "demo" but maybe it would be better to host somewhere else as this is for developers migrating Java Web Start applications. Our current plan is to deliver it only as a demo. Thi

Re: RFR: JDK-8210958 Rename "make run-test" to "make test"

Looks good. /Erik On 2018-10-30 00:41, Magnus Ihse Bursie wrote: On 2018-10-23 10:45, Magnus Ihse Bursie wrote: On 2018-10-19 18:11, Erik Joelsson wrote: Looks good, and thanks for fixing test-make. I found the same issue today. Could you also change the make target we call for run-test

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

On 10/24/2018 10:22 AM, Alan Bateman wrote: On 23/10/2018 16:49, Andy Herrick wrote: This patch implements the Java Packager Tool (jpackager) as described in JEP 343: Packaging Tool jpackager is a simple packaging tool, based on the JavaFX

RFR: 8209093 - JEP 340: One AArch64 Port, Not Two

This JEP is now targeted to JDK 12. I’ve merged up to the latest sources and will be integrating these changes in the next day or two. Here’s the latest webrev post merge in the event anyone spots any last minute issues. http://cr.openjdk.java.net/~bobv/8209093/webrev.02

Re: RFR: JDK-8210958 Rename "make run-test" to "make test"

On 2018-10-23 10:45, Magnus Ihse Bursie wrote: On 2018-10-19 18:11, Erik Joelsson wrote: Looks good, and thanks for fixing test-make. I found the same issue today. Could you also change the make target we call for run-test/run-test-prebuilt profiles in jib-profiles.js? There's no target f