Re: Review Request : JDK-8213362 : Could not find libjava.dylib error when initializing JVM via JNI_CreateJavaVM

2018-11-05 Thread Priyanka Mangal
The Eclipse launcher is capable of loading the Java VM in the eclipse process using the Java Native Interface Invocation API.  The launcher is still capable of starting the Java VM in a separate process the same as previous version of Eclipse did.  Which method is used depends on how the VM

Re: RFR: JDK-8213227: Update jib src excludes to filter webrev and Jreg directories

2018-11-05 Thread David Holmes
Erik, I think this has broken the creation of the "release" file in the build. It no longer contains the "hg" tag, presumably because all the .hg directories that would have indicated hg was used have been stripped. CI tests are failing for test/jdk/build/releaseFile/CheckSource.java David

Re: RFR: JDK-8213339 Update precompiled.hpp with headers based on current frequency

2018-11-05 Thread Erik Joelsson
On 2018-11-05 01:41, Magnus Ihse Bursie wrote: If I were to spend more time on PCH, I'd rather spend it on either Windows (which is the slowest build platform in our CI), or Solaris, which does not have precompiled headers at all. (I actually looked into solstudio PCH as part of this fix to

Re: Stop using precompiled headers for Linux?

2018-11-05 Thread Aleksey Shipilev
On 11/05/2018 05:46 PM, Erik Joelsson wrote: >> If we decide to keep precompiled headers on by default, maybe we should add >> a simple no-PCH >> verification task in tier1? It only needs to build hotspot, so it should be >> quick. >> > That is a good point, so sure we can do that. Which debug

Re: Stop using precompiled headers for Linux?

2018-11-05 Thread Erik Joelsson
On 2018-11-03 01:51, Magnus Ihse Bursie wrote: On 2018-10-30 20:21, Erik Joelsson wrote: Last I checked, it did provide significant build speed improvements when building just hotspot, but that could need revisiting. We do have verification of --disable-precompiled-headers (in slowdebug) in

Re: Review Request : JDK-8213362 : Could not find libjava.dylib error when initializing JVM via JNI_CreateJavaVM

2018-11-05 Thread Alan Bateman
On 05/11/2018 14:21, Magnus Ihse Bursie wrote: Hi, Fix looks good, but maybe we should have a regression test of GetJREPath()? /Magnus The fix looks okay but I'm puzzled as to how Eclipse is running into this. Do they locate/call libjli/GetJREPath directly or is this happening then it is

Re: Review Request : JDK-8213362 : Could not find libjava.dylib error when initializing JVM via JNI_CreateJavaVM

2018-11-05 Thread Magnus Ihse Bursie
assumes that > `libjli.dylib` should be on `lib/jli/libjli.dylib` path. > So corrected the same. > > Testing: > mach5 : tier1-3 > http://java.se.oracle.com:10065/mdash/jobs/fmatte-jdk-20181105-0941-8721?search=result.status:* > > Thanks > Regards > Priyanka > >

Review Request : JDK-8213362 : Could not find libjava.dylib error when initializing JVM via JNI_CreateJavaVM

2018-11-05 Thread Priyanka Mangal
rectory. However `GetJREPath` method in `src/java.base/macosx/native/libjli/java_md_macosx.m` still assumes that `libjli.dylib` should be on `lib/jli/libjli.dylib` path. So corrected the same. Testing: mach5 : tier1-3 http://java.se.oracle.com:10065/mdash/jobs/fmatte-jdk-20181105-0941-8721?sear

Re: compiling openJdk 11 on windows 7 32bits fail

2018-11-05 Thread Magnus Ihse Bursie
On 2018-11-04 06:16, Franco Gastón Pellegrini wrote: I used this command: /bash ./configure --enable-debug --with-target-bits=32 --with-toolchain-version=2017 --with-jvm-variants=client --with-boot-jdk="/home/Franco/Java/jdk10/build/windows-x86-normal-client-fastdebug/jdk/";/ I tried Visual

Re: RFR: JDK-8213339 Update precompiled.hpp with headers based on current frequency

2018-11-05 Thread Magnus Ihse Bursie
On 2018-11-05 08:28, David Holmes wrote: Hi Thomas, On 5/11/2018 5:17 PM, Thomas Stüfe wrote: Hi David, On Sun, Nov 4, 2018 at 11:09 PM David Holmes wrote: On 4/11/2018 5:27 PM, Magnus Ihse Bursie wrote: 3 nov. 2018 kl. 23:24 skrev David Holmes : On 3/11/2018 10:09 PM, David Holmes